From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A14C04AAF for ; Sat, 18 May 2019 14:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 766E4208CB for ; Sat, 18 May 2019 14:15:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="mOGxjCQa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729416AbfEROPP (ORCPT ); Sat, 18 May 2019 10:15:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38947 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727594AbfEROPO (ORCPT ); Sat, 18 May 2019 10:15:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vxxOG4cgMteauDySbGtDK/NXhJ11L9YPT09u3ikHPG4=; b=mOGxjCQaZiIvy9wAyAvWyfhMjY HmsxsRwgpnHZipAOZiVubrnBmMNdz65OgrOMQstQFUuvakotatlwLgxkTjyJCKG3/+77ERCGsp2QU lM9XpB8h1RUS6Am+pqGxLVm4WqkdfCkVlSSooVLBt3+4lSToOK+SWc64rgoDPBLNr+jo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hS06y-0006Ek-HJ; Sat, 18 May 2019 16:14:56 +0200 Date: Sat, 18 May 2019 16:14:56 +0200 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, Florian Fainelli , Guenter Roeck , Heiner Kallweit , Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver Message-ID: <20190518141456.GK14298@lunn.ch> References: <20190517235123.32261-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517235123.32261-1-marex@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote: > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. Hi Marek > + }, { > + PHY_ID_MATCH_MODEL(PHY_ID_TJA1101), > + .name = "NXP TJA1101", > + .features = PHY_BASIC_T1_FEATURES, One thing i would like to do before this patch goes in is define ETHTOOL_LINK_MODE_100baseT1_Full_BIT in ethtool.h, and use it here. We could not do it earlier because were ran out of bits. But with PHYLIB now using bitmaps, rather than u32, we can. Once net-next reopens i will submit a patch adding it. I also see in the data sheet we should be able to correct detect its features using register 15. So we should extend genphy_read_abilities(). That will allow us to avoid changing PHY_BASIC_T1_FEATURES and possibly breaking backwards compatibility of other T1 PHY which currently say they are plain 100BaseT. Andrew