All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: maximmi@mellanox.com
Cc: jakub.kicinski@netronome.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	leonro@mellanox.com
Subject: Re: [PATCH net] Validate required parameters in inet6_validate_link_af
Date: Mon, 20 May 2019 11:04:47 -0700 (PDT)	[thread overview]
Message-ID: <20190520.110447.451570638406811414.davem@davemloft.net> (raw)
In-Reply-To: <20190520080755.2542-1-maximmi@mellanox.com>

From: Maxim Mikityanskiy <maximmi@mellanox.com>
Date: Mon, 20 May 2019 08:08:07 +0000

> +static int inet6_validate_link_af(const struct net_device *dev,
> +				  const struct nlattr *nla)
> +{
> +	struct inet6_dev *idev = NULL;
> +	struct nlattr *tb[IFLA_INET6_MAX + 1];
> +	int err;

Reverse christmas tree.

Otherwise patch looks good to me.

Thanks.

      reply	other threads:[~2019-05-20 18:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  8:08 [PATCH net] Validate required parameters in inet6_validate_link_af Maxim Mikityanskiy
2019-05-20 18:04 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520.110447.451570638406811414.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=leonro@mellanox.com \
    --cc=maximmi@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.