All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xiangxia.m.yue@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: vxlan: disallow removing to other namespace
Date: Mon, 20 May 2019 19:53:19 -0400 (EDT)	[thread overview]
Message-ID: <20190520.195319.201742803310676769.davem@davemloft.net> (raw)
In-Reply-To: <1558147343-93724-1-git-send-email-xiangxia.m.yue@gmail.com>

From: xiangxia.m.yue@gmail.com
Date: Fri, 17 May 2019 19:42:23 -0700

> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> Don't allow to remove the vxlan device to other namesapce,
> because we maintain the data of vxlan net device on original
> net-namespace.
> 
>     $ ip netns add ns100
>     $ ip link add vxlan100 type vxlan dstport 4789 external
>     $ ip link set dev vxlan100 netns ns100
>     $ ip netns exec ns100 ip link add vxlan200 type vxlan dstport 4789 external
>     $ ip netns exec ns100 ip link
>     ...
>     vxlan200: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>     vxlan100: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> 
> And we should create it on new net-namespace, so disallow removing it.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

I don't understand this change at all.

You keep saying "Remove" but I think you might mean simply "Move" because
the NETNS_LOCAL flag prevents moving not removing.

And why is it bad to allow vxlan devices to be moved between network
namespaces?  What problem would it cause and can you guarantee that
you are not breaking an existing user?

I'm not applying this as-is.

  reply	other threads:[~2019-05-20 23:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18  2:42 [PATCH] net: vxlan: disallow removing to other namespace xiangxia.m.yue
2019-05-20 23:53 ` David Miller [this message]
2019-05-21  5:53   ` Tonghao Zhang
2019-05-21  9:28     ` Nicolas Dichtel
2019-05-21 11:08       ` Tonghao Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520.195319.201742803310676769.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiangxia.m.yue@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.