From: David Miller <davem@davemloft.net>
To: weifeng.voon@intel.com
Cc: mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joabreu@synopsys.com,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
boon.leong.ong@intel.com, tee.min.tan@intel.com
Subject: Re: [PATCH net] net: stmmac: fix ethtool flow control not able to get/set
Date: Mon, 20 May 2019 20:55:13 -0400 (EDT) [thread overview]
Message-ID: <20190520.205513.1314405241609671077.davem@davemloft.net> (raw)
In-Reply-To: <1558414542-28550-1-git-send-email-weifeng.voon@intel.com>
From: Weifeng Voon <weifeng.voon@intel.com>
Date: Tue, 21 May 2019 12:55:42 +0800
> From: "Tan, Tee Min" <tee.min.tan@intel.com>
>
> Currently ethtool was not able to get/set the flow control due to a
> missing "!". It will always return -EOPNOTSUPP even the device is
> flow control supported.
>
> This patch fixes the condition check for ethtool flow control get/set
> function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.
>
> Fixes: 3c1bcc8614db (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”)
> Signed-off-by: Tan, Tee Min <tee.min.tan@intel.com>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@intel.com>
> Signed-off-by: Voon, Weifeng <weifeng.voon@intel.com@intel.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-05-21 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 4:55 [PATCH net] net: stmmac: fix ethtool flow control not able to get/set Weifeng Voon
2019-05-20 21:20 ` Andrew Lunn
2019-05-21 0:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520.205513.1314405241609671077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.