From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A59C072A4 for ; Mon, 20 May 2019 07:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 181C52085A for ; Mon, 20 May 2019 07:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730545AbfETHK6 (ORCPT ); Mon, 20 May 2019 03:10:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:41020 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729518AbfETHK5 (ORCPT ); Mon, 20 May 2019 03:10:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 56767AD5C; Mon, 20 May 2019 07:10:56 +0000 (UTC) Date: Mon, 20 May 2019 09:10:55 +0200 From: Johannes Thumshirn To: Matthew Garrett Cc: linux-integrity@vger.kernel.org, zohar@linux.vnet.ibm.com, dmitry.kasatkin@gmail.com, miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, Matthew Garrett Subject: Re: [PATCH V3 1/6] VFS: Add a call to obtain a file's hash Message-ID: <20190520071055.GB4985@x250> References: <20190517212448.14256-1-matthewgarrett@google.com> <20190517212448.14256-2-matthewgarrett@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190517212448.14256-2-matthewgarrett@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 17, 2019 at 02:24:43PM -0700, Matthew Garrett wrote: > + * vfs_gethash - obtain a file's hash [...] > +int vfs_get_hash(struct file *file, enum hash_algo hash, uint8_t *buf, Nit: the kernel-doc says it's called vfs_gethash(), but the function is called vfs_get_hash(). -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850