All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Martin Kealey <martin@kurahaupo.gen.nz>
Cc: netdev@vger.kernel.org
Subject: Re: patch for iproute2
Date: Mon, 20 May 2019 16:09:58 +0800	[thread overview]
Message-ID: <20190520080958.GV18865@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1905181350500.8326@feathers.ext.sig.nz>

On Sat, May 18, 2019 at 01:52:36PM +1000, Martin Kealey wrote:
> 
> Hello iproute2 maintainer.
> 
> (Sorry, I don't know your name)
> 
> I recently noticed a discrepancy: the internal documentation for the ip
> command says that an *RTT* value can be sufficed with "s" (second) or "ms"
> (millisecond), but in practice no suffix of any kind is accepted.
> 
> I found that that commit 697ac63905cb5ca5389cd840462ee9868123b77f to
> git://git.kernel.org/pub/scm/network/iproute2/iproute2.git caused this
> regression; it was over-zealous in disallowing non-digits in *all* contexts
> where a number is expected.
> 
> As far as I can tell, this does not have any kernel-related impact, merely
> it affects what arguments are accepted by the "ip" command.
> 
> I have a suitable patch for fixing this; what is the procedure for
> submitting it?

It's the same process with submitting patch to netdev[1]. If you are familiar
with git. Just format a patch and send it to detdev@. Be careful with the
subject prefix, Signed-off info and fixes tags.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/Documentation/networking/netdev-FAQ.rst#n257

Thanks
Hangbin

      reply	other threads:[~2019-05-20  8:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-18  3:52 patch for iproute2 Martin Kealey
2019-05-20  8:09 ` Hangbin Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520080958.GV18865@dhcp-12-139.nay.redhat.com \
    --to=liuhangbin@gmail.com \
    --cc=martin@kurahaupo.gen.nz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.