From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE29C04AAF for ; Mon, 20 May 2019 08:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28984206BA for ; Mon, 20 May 2019 08:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731325AbfETIh0 (ORCPT ); Mon, 20 May 2019 04:37:26 -0400 Received: from bmailout2.hostsharing.net ([83.223.90.240]:54071 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728889AbfETIh0 (ORCPT ); Mon, 20 May 2019 04:37:26 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 1FCF52800BC20; Mon, 20 May 2019 10:37:24 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id BE197AEB34; Mon, 20 May 2019 10:37:23 +0200 (CEST) Date: Mon, 20 May 2019 10:37:23 +0200 From: Lukas Wunner To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , LKML , Daniel Vetter , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , Bartlomiej Zolnierkiewicz , Hans de Goede , Yisheng Xie , linux-fbdev@vger.kernel.org Subject: Re: [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly Message-ID: <20190520083723.xgjrocuuhwq4mcms@wunner.de> References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> <20190520082216.26273-31-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520082216.26273-31-daniel.vetter@ffwll.ch> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 10:22:13AM +0200, Daniel Vetter wrote: > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3146,16 +3146,16 @@ void fbcon_fb_unregistered(struct fb_info *info) > } > > /* called with console_lock held */ > -static void fbcon_remap_all(int idx) That comment needs to be removed as well. Not an expert on fbcon code but this looks sane to me, so in case it helps: Acked-by: Lukas Wunner Thanks, Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Date: Mon, 20 May 2019 08:37:23 +0000 Subject: Re: [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly Message-Id: <20190520083723.xgjrocuuhwq4mcms@wunner.de> List-Id: References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> <20190520082216.26273-31-daniel.vetter@ffwll.ch> In-Reply-To: <20190520082216.26273-31-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , LKML , Daniel Vetter , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , Bartlomiej Zolnierkiewicz , Hans de Goede , Yisheng Xie , linux-fbdev@vger.kernel.org On Mon, May 20, 2019 at 10:22:13AM +0200, Daniel Vetter wrote: > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3146,16 +3146,16 @@ void fbcon_fb_unregistered(struct fb_info *info) > } > > /* called with console_lock held */ > -static void fbcon_remap_all(int idx) That comment needs to be removed as well. Not an expert on fbcon code but this looks sane to me, so in case it helps: Acked-by: Lukas Wunner Thanks, Lukas