From: Wolfram Sang <wsa@the-dreams.de>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Douglas Anderson <dianders@chromium.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-rockchip@lists.infradead.org,
Double Lo <double.lo@cypress.com>,
briannorris@chromium.org,
Madhan Mohan R <madhanmohan.r@cypress.com>,
mka@chromium.org, Wright Feng <wright.feng@cypress.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Jiong Wu <lohengrin1024@gmail.com>,
Ritesh Harjani <riteshh@codeaurora.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Avri Altman <avri.altman@wdc.com>, Martin Hicks <mort@bork.org>
Subject: Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors
Date: Mon, 20 May 2019 10:52:01 +0200 [thread overview]
Message-ID: <20190520085201.GA1021@kunai> (raw)
In-Reply-To: <36cae1d3-f11c-3c71-3f04-23fdc74f8866@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Mon, May 20, 2019 at 10:46:19AM +0200, Arend Van Spriel wrote:
> On 5/19/2019 11:06 AM, Wolfram Sang wrote:
> >
> > > Let's add an API that the SDIO card drivers can call that will
> > > temporarily disable the auto-tuning functionality. Then we can add a
> > > call to this in the Broadcom WiFi driver and any other driver that
> > > might have similar needs.
> >
> > Can't you fix the WiFi driver to return something else than -EILSEQ
> > before calling mmc_request_done() to skip the retuning?
>
> Not really. mmc_request_done() is for the host controller driver so the wifi
> driver is not involved.
Uh, right. Brown paper bag, please...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Arend Van Spriel
<arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Madhan Mohan R
<madhanmohan.r-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Martin Hicks <mort-THxEKynEWHc@public.gmane.org>,
Wolfram Sang
<wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chi-Hsien Lin
<chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Double Lo <double.lo-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Avri Altman <avri.altman-Sjgp3cTcYWE@public.gmane.org>,
mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
Ritesh Harjani <riteshh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Wright Feng <wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
Jiong Wu <lohengrin1024-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Adrian Hunter
<adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors
Date: Mon, 20 May 2019 10:52:01 +0200 [thread overview]
Message-ID: <20190520085201.GA1021@kunai> (raw)
In-Reply-To: <36cae1d3-f11c-3c71-3f04-23fdc74f8866-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]
On Mon, May 20, 2019 at 10:46:19AM +0200, Arend Van Spriel wrote:
> On 5/19/2019 11:06 AM, Wolfram Sang wrote:
> >
> > > Let's add an API that the SDIO card drivers can call that will
> > > temporarily disable the auto-tuning functionality. Then we can add a
> > > call to this in the Broadcom WiFi driver and any other driver that
> > > might have similar needs.
> >
> > Can't you fix the WiFi driver to return something else than -EILSEQ
> > before calling mmc_request_done() to skip the retuning?
>
> Not really. mmc_request_done() is for the host controller driver so the wifi
> driver is not involved.
Uh, right. Brown paper bag, please...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 200 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2019-05-20 8:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 22:54 [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Douglas Anderson
2019-05-17 22:54 ` Douglas Anderson
2019-05-17 22:54 ` [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 Douglas Anderson
2019-05-20 8:09 ` Arend Van Spriel
2019-05-20 18:20 ` Doug Anderson
2019-05-20 18:20 ` Doug Anderson
[not found] ` <20190517225420.176893-2-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-05-28 12:18 ` Kalle Valo
2019-05-28 15:51 ` Doug Anderson
2019-05-28 15:51 ` Doug Anderson
2019-05-28 16:09 ` Arend Van Spriel
2019-05-28 16:09 ` Arend Van Spriel
2019-05-28 16:11 ` Arend Van Spriel
2019-05-28 16:11 ` Arend Van Spriel
2019-06-04 3:20 ` Wright Feng
2019-06-04 3:20 ` Wright Feng
2019-06-04 16:01 ` Doug Anderson
2019-06-04 16:01 ` Doug Anderson
2019-06-04 16:48 ` Arend Van Spriel
2019-06-04 16:48 ` Arend Van Spriel
2019-05-29 14:51 ` Kalle Valo
2019-05-29 14:51 ` Kalle Valo
2019-05-28 12:18 ` Kalle Valo
2019-05-28 12:18 ` Kalle Valo
2019-05-17 22:54 ` [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors Douglas Anderson
2019-05-17 22:54 ` Douglas Anderson
2019-05-19 9:06 ` Wolfram Sang
2019-05-19 9:06 ` Wolfram Sang
2019-05-20 8:46 ` Arend Van Spriel
2019-05-20 8:52 ` Wolfram Sang [this message]
2019-05-20 8:52 ` Wolfram Sang
2019-05-26 18:42 ` Arend Van Spriel
2019-05-26 18:42 ` Arend Van Spriel
2019-05-28 10:04 ` Adrian Hunter
2019-05-28 11:21 ` Arend Van Spriel
2019-05-28 11:45 ` Adrian Hunter
2019-05-28 15:42 ` Doug Anderson
2019-05-17 22:54 ` [PATCH 3/3] brcmfmac: sdio: Disable auto-tuning around commands expected to fail Douglas Anderson
2019-05-18 15:09 ` [PATCH 0/3] brcmfmac: sdio: Deal better w/ transmission errors waking from sleep Avri Altman
2019-05-18 15:09 ` Avri Altman
2019-05-21 0:23 ` Brian Norris
2019-05-21 0:23 ` Brian Norris
2019-05-20 8:55 ` Arend Van Spriel
2019-05-20 8:55 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520085201.GA1021@kunai \
--to=wsa@the-dreams.de \
--cc=adrian.hunter@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=avri.altman@wdc.com \
--cc=briannorris@chromium.org \
--cc=chi-hsien.lin@cypress.com \
--cc=dianders@chromium.org \
--cc=double.lo@cypress.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lohengrin1024@gmail.com \
--cc=madhanmohan.r@cypress.com \
--cc=mka@chromium.org \
--cc=mort@bork.org \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
--cc=wsa+renesas@sang-engineering.com \
--subject='Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.