All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Mike Anderson <andmike@linux.ibm.com>,
	Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Alexey Kardashevskiy <aik@linux.ibm.com>,
	Ram Pai <linuxram@us.ibm.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Paul Mackerras <paulus@ozlabs.org>,
	iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
	Christoph Hellwig <hch@lst.de>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted
Date: Mon, 20 May 2019 09:16:57 -0400	[thread overview]
Message-ID: <20190520090939-mutt-send-email-mst__22003.1254737236$1558358244$gmane$org@kernel.org> (raw)
In-Reply-To: <87a7go71hz.fsf@morokweng.localdomain>

On Wed, Apr 17, 2019 at 06:42:00PM -0300, Thiago Jung Bauermann wrote:
> I rephrased it in terms of address translation. What do you think of
> this version? The flag name is slightly different too:
> 
> 
> VIRTIO_F_ACCESS_PLATFORM_NO_TRANSLATION This feature has the same
>     meaning as VIRTIO_F_ACCESS_PLATFORM both when set and when not set,
>     with the exception that address translation is guaranteed to be
>     unnecessary when accessing memory addresses supplied to the device
>     by the driver. Which is to say, the device will always use physical
>     addresses matching addresses used by the driver (typically meaning
>     physical addresses used by the CPU) and not translated further. This
>     flag should be set by the guest if offered, but to allow for
>     backward-compatibility device implementations allow for it to be
>     left unset by the guest. It is an error to set both this flag and
>     VIRTIO_F_ACCESS_PLATFORM.


OK so VIRTIO_F_ACCESS_PLATFORM is designed to allow unpriveledged
drivers. This is why devices fail when it's not negotiated.

This confuses me.
If driver is unpriveledged then what happens with this flag?
It can supply any address it wants. Will that corrupt kernel
memory?

-- 
MST

  parent reply	other threads:[~2019-05-20 13:16 UTC|newest]

Thread overview: 198+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 17:08 [RFC PATCH] virtio_ring: Use DMA API if guest memory is encrypted Thiago Jung Bauermann
2019-01-29 17:08 ` Thiago Jung Bauermann
2019-01-29 17:42 ` Thiago Jung Bauermann
2019-01-29 17:42   ` Thiago Jung Bauermann
2019-01-29 19:02   ` Michael S. Tsirkin
2019-01-29 19:02     ` Michael S. Tsirkin
2019-01-30  2:24     ` Jason Wang
2019-01-30  2:24       ` Jason Wang
2019-01-30  2:36       ` Michael S. Tsirkin
2019-01-30  2:36       ` Michael S. Tsirkin
2019-01-30  2:36         ` Michael S. Tsirkin
2019-01-30  3:05         ` Jason Wang
2019-01-30  3:05         ` Jason Wang
2019-01-30  3:05           ` Jason Wang
2019-01-30  3:26           ` Michael S. Tsirkin
2019-01-30  3:26           ` Michael S. Tsirkin
2019-01-30  3:26             ` Michael S. Tsirkin
2019-01-30  7:44         ` Christoph Hellwig
2019-01-30  7:44         ` Christoph Hellwig
2019-01-30  7:44           ` Christoph Hellwig
2019-02-04 18:15           ` Thiago Jung Bauermann
2019-02-04 18:15           ` Thiago Jung Bauermann
2019-02-04 18:15             ` Thiago Jung Bauermann
2019-02-04 21:38             ` Michael S. Tsirkin
2019-02-04 21:38               ` Michael S. Tsirkin
2019-02-05  7:24               ` Christoph Hellwig
2019-02-05  7:24                 ` Christoph Hellwig
2019-02-05 16:13                 ` Michael S. Tsirkin
2019-02-05 16:13                 ` Michael S. Tsirkin
2019-02-05 16:13                   ` Michael S. Tsirkin
2019-02-05 16:13                   ` Michael S. Tsirkin
2019-02-05  7:24               ` Christoph Hellwig
2019-02-04 21:38             ` Michael S. Tsirkin
2019-03-26 16:53           ` Michael S. Tsirkin
2019-03-26 16:53           ` Michael S. Tsirkin
2019-03-26 16:53             ` Michael S. Tsirkin
2019-01-30  2:24     ` Jason Wang
2019-02-04 18:14     ` Thiago Jung Bauermann
2019-02-04 18:14     ` Thiago Jung Bauermann
2019-02-04 18:14       ` Thiago Jung Bauermann
2019-02-04 20:23       ` Michael S. Tsirkin
2019-02-04 20:23         ` Michael S. Tsirkin
2019-03-20 16:13         ` Thiago Jung Bauermann
2019-03-20 16:13           ` Thiago Jung Bauermann
2019-03-20 16:13           ` Thiago Jung Bauermann
2019-03-20 21:17           ` Michael S. Tsirkin
2019-03-20 21:17           ` Michael S. Tsirkin
2019-03-20 21:17             ` Michael S. Tsirkin
2019-03-22  0:05             ` Thiago Jung Bauermann
2019-03-22  0:05             ` Thiago Jung Bauermann
2019-03-22  0:05               ` Thiago Jung Bauermann
2019-03-23 21:01               ` Michael S. Tsirkin
2019-03-23 21:01                 ` Michael S. Tsirkin
2019-03-23 21:01                 ` Michael S. Tsirkin
2019-03-25  0:57                 ` David Gibson
2019-03-25  0:57                   ` David Gibson
2019-03-25  0:57                   ` David Gibson
2019-04-17 21:42                   ` Thiago Jung Bauermann
2019-04-17 21:42                     ` Thiago Jung Bauermann
2019-04-17 21:42                     ` Thiago Jung Bauermann
2019-04-17 21:42                     ` Thiago Jung Bauermann
2019-04-17 21:42                 ` Thiago Jung Bauermann
2019-04-17 21:42                 ` Thiago Jung Bauermann
2019-04-17 21:42                   ` Thiago Jung Bauermann
2019-04-17 21:42                   ` Thiago Jung Bauermann
2019-04-17 21:42                   ` Thiago Jung Bauermann
2019-04-19 23:09                   ` Michael S. Tsirkin
2019-04-19 23:09                   ` Michael S. Tsirkin
2019-04-19 23:09                     ` Michael S. Tsirkin
2019-04-19 23:09                     ` Michael S. Tsirkin
2019-04-25  1:01                     ` Thiago Jung Bauermann
2019-04-25  1:01                       ` Thiago Jung Bauermann
2019-04-25  1:01                       ` Thiago Jung Bauermann
2019-04-25  1:18                       ` Michael S. Tsirkin
2019-04-25  1:18                       ` Michael S. Tsirkin
2019-04-25  1:18                         ` Michael S. Tsirkin
2019-04-25  1:18                         ` Michael S. Tsirkin
2019-04-25  1:18                         ` Michael S. Tsirkin
2019-04-26 23:56                         ` Thiago Jung Bauermann
2019-04-26 23:56                         ` Thiago Jung Bauermann
2019-04-26 23:56                           ` Thiago Jung Bauermann
2019-04-26 23:56                           ` Thiago Jung Bauermann
2019-05-20 13:08                           ` Michael S. Tsirkin
2019-05-20 13:08                             ` Michael S. Tsirkin
2019-05-20 13:08                             ` Michael S. Tsirkin
2019-05-20 13:08                             ` Michael S. Tsirkin
2019-04-25  1:01                     ` Thiago Jung Bauermann
2019-05-20 13:16                   ` Michael S. Tsirkin [this message]
2019-05-20 13:16                   ` Michael S. Tsirkin
2019-05-20 13:16                     ` Michael S. Tsirkin
2019-05-20 13:16                     ` Michael S. Tsirkin
2019-06-04  1:13                     ` Thiago Jung Bauermann
2019-06-04  1:13                       ` Thiago Jung Bauermann
2019-06-04  1:13                       ` Thiago Jung Bauermann
2019-06-04  1:42                       ` Michael S. Tsirkin
2019-06-04  1:42                         ` Michael S. Tsirkin
2019-06-04  1:42                         ` Michael S. Tsirkin
2019-06-04  1:42                         ` Michael S. Tsirkin
2019-06-28  1:58                         ` Thiago Jung Bauermann
2019-06-28  1:58                         ` Thiago Jung Bauermann
2019-06-28  1:58                           ` Thiago Jung Bauermann
2019-06-28  1:58                           ` Thiago Jung Bauermann
2019-07-01 14:17                           ` Michael S. Tsirkin
2019-07-01 14:17                           ` Michael S. Tsirkin
2019-07-01 14:17                             ` Michael S. Tsirkin
2019-07-01 14:17                             ` Michael S. Tsirkin
2019-07-14  5:51                             ` Thiago Jung Bauermann
2019-07-14  5:51                             ` Thiago Jung Bauermann
2019-07-14  5:51                               ` Thiago Jung Bauermann
2019-07-14  5:51                               ` Thiago Jung Bauermann
2019-07-15 14:35                               ` Michael S. Tsirkin
2019-07-15 14:35                               ` Michael S. Tsirkin
2019-07-15 14:35                                 ` Michael S. Tsirkin
2019-07-15 14:35                                 ` Michael S. Tsirkin
2019-07-15 20:29                                 ` Thiago Jung Bauermann
2019-07-15 20:29                                   ` Thiago Jung Bauermann
2019-07-15 20:29                                   ` Thiago Jung Bauermann
2019-07-15 20:36                                   ` Michael S. Tsirkin
2019-07-15 20:36                                   ` Michael S. Tsirkin
2019-07-15 20:36                                     ` Michael S. Tsirkin
2019-07-15 20:36                                     ` Michael S. Tsirkin
2019-07-15 22:03                                     ` Thiago Jung Bauermann
2019-07-15 22:03                                       ` Thiago Jung Bauermann
2019-07-15 22:03                                       ` Thiago Jung Bauermann
2019-07-15 22:03                                       ` Thiago Jung Bauermann
2019-07-15 22:16                                       ` Michael S. Tsirkin
2019-07-15 22:16                                       ` Michael S. Tsirkin
2019-07-15 22:16                                         ` Michael S. Tsirkin
2019-07-15 22:16                                         ` Michael S. Tsirkin
2019-07-15 23:05                                         ` Thiago Jung Bauermann
2019-07-15 23:05                                           ` Thiago Jung Bauermann
2019-07-15 23:05                                           ` Thiago Jung Bauermann
2019-07-15 23:05                                         ` Thiago Jung Bauermann
2019-07-15 23:24                                       ` Benjamin Herrenschmidt
2019-07-15 23:24                                       ` Benjamin Herrenschmidt
2019-07-15 23:24                                         ` Benjamin Herrenschmidt
2019-07-15 23:24                                         ` Benjamin Herrenschmidt
2019-07-15 20:29                                 ` Thiago Jung Bauermann
2019-07-18  3:39                               ` Thiago Jung Bauermann
2019-07-18  3:39                                 ` Thiago Jung Bauermann
2019-07-18  3:39                               ` Thiago Jung Bauermann
2019-06-04  1:13                     ` Thiago Jung Bauermann
2019-03-20 16:13         ` Thiago Jung Bauermann
2019-02-04 20:23       ` Michael S. Tsirkin
2019-01-29 19:02   ` Michael S. Tsirkin
2019-01-29 17:42 ` Thiago Jung Bauermann
2019-08-10 18:57 ` Michael S. Tsirkin
2019-08-10 18:57   ` Michael S. Tsirkin
2019-08-10 18:57   ` Michael S. Tsirkin
2019-08-10 22:07   ` Ram Pai
2019-08-10 22:07   ` Ram Pai
2019-08-10 22:07     ` Ram Pai
2019-08-11  5:56     ` Christoph Hellwig
2019-08-11  5:56       ` Christoph Hellwig
2019-08-11  5:56       ` Christoph Hellwig
2019-08-11  6:46       ` Ram Pai
2019-08-11  6:46         ` Ram Pai
2019-08-11  6:46         ` Ram Pai
2019-08-11  8:44         ` Michael S. Tsirkin
2019-08-11  8:44           ` Michael S. Tsirkin
2019-08-11  8:44           ` Michael S. Tsirkin
2019-08-12 12:13         ` Christoph Hellwig
2019-08-12 12:13         ` Christoph Hellwig
2019-08-12 12:13           ` Christoph Hellwig
2019-08-12 20:29           ` Ram Pai
2019-08-12 20:29             ` Ram Pai
2019-08-12 20:29           ` Ram Pai
2019-08-11  8:42       ` Michael S. Tsirkin
2019-08-11  8:42         ` Michael S. Tsirkin
2019-08-11  8:42       ` Michael S. Tsirkin
2019-08-11  8:55       ` Michael S. Tsirkin
2019-08-11  8:55       ` Michael S. Tsirkin
2019-08-11  8:55         ` Michael S. Tsirkin
2019-08-12 12:15         ` Christoph Hellwig
2019-08-12 12:15         ` Christoph Hellwig
2019-08-12 12:15           ` Christoph Hellwig
2019-09-06  5:07           ` Michael S. Tsirkin
2019-09-06  5:07             ` Michael S. Tsirkin
2019-09-06  5:07             ` Michael S. Tsirkin
2019-08-12  9:51       ` David Gibson
2019-08-12  9:51       ` David Gibson
2019-08-12  9:51         ` David Gibson
2019-08-13 13:26         ` Christoph Hellwig
2019-08-13 13:26           ` Christoph Hellwig
2019-08-13 14:24           ` David Gibson
2019-08-13 14:24             ` David Gibson
2019-08-13 15:45             ` Ram Pai
2019-08-13 15:45               ` Ram Pai
2019-08-13 15:45               ` Ram Pai
2019-08-26 17:48               ` Ram Pai
2019-08-26 17:48                 ` Ram Pai
2019-08-26 17:48               ` Ram Pai
2019-08-13 14:24           ` David Gibson
2019-08-13 13:26         ` Christoph Hellwig
2019-08-11  8:12     ` Michael S. Tsirkin
2019-08-11  8:12       ` Michael S. Tsirkin
2019-08-11  8:12       ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2019-01-29 17:08 Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190520090939-mutt-send-email-mst__22003.1254737236$1558358244$gmane$org@kernel.org' \
    --to=mst@redhat.com \
    --cc=aik@linux.ibm.com \
    --cc=andmike@linux.ibm.com \
    --cc=bauerman@linux.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jean-philippe.brucker@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=linuxram@us.ibm.com \
    --cc=paulus@ozlabs.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.