From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26A6C04AAC for ; Mon, 20 May 2019 10:24:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA0D220675 for ; Mon, 20 May 2019 10:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730798AbfETKY2 (ORCPT ); Mon, 20 May 2019 06:24:28 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:35158 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbfETKY2 (ORCPT ); Mon, 20 May 2019 06:24:28 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1hSfT0-0007Ka-4K; Mon, 20 May 2019 12:24:26 +0200 Date: Mon, 20 May 2019 12:24:26 +0200 From: Phil Sutter To: Hangbin Liu Cc: netdev@vger.kernel.org, David Ahern , Stephen Hemminger Subject: Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric Message-ID: <20190520102426.GM4851@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Hangbin Liu , netdev@vger.kernel.org, David Ahern , Stephen Hemminger References: <20190520075648.15882-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520075648.15882-1-liuhangbin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Mon, May 20, 2019 at 03:56:48PM +0800, Hangbin Liu wrote: > When calles rtnl_dsfield_n2a(), we get the dsfield name from > /etc/iproute2/rt_dsfield. But different distribution may have > different names. So add a new parameter '-Numeric' to only show > the dsfield number. > > This parameter is only used for tos value at present. We could enable > this for other fields if needed in the future. Rationale is to ensure expected output irrespective of host configuration, especially in test scripts. Concrete example motivating this patch was net/fib_rule_tests.sh in kernel self-tests. > Suggested-by: Phil Sutter > Signed-off-by: Hangbin Liu Acked-by: Phil Sutter Thanks for doing this, Hangbin! Phil