From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_HK_NAME_DR,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECCBC04E87 for ; Mon, 20 May 2019 16:48:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9203121743 for ; Mon, 20 May 2019 16:48:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9203121743 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:38544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSlT0-0002tM-0A for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 12:48:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSlIY-00020m-Lf for qemu-devel@nongnu.org; Mon, 20 May 2019 12:38:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSlIX-0005sk-Gg for qemu-devel@nongnu.org; Mon, 20 May 2019 12:38:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54950) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSlIX-0005sF-7w for qemu-devel@nongnu.org; Mon, 20 May 2019 12:38:01 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97BE1F74A0 for ; Mon, 20 May 2019 16:38:00 +0000 (UTC) Received: from work-vm (ovpn-116-127.ams2.redhat.com [10.36.116.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A8A858821; Mon, 20 May 2019 16:37:59 +0000 (UTC) Date: Mon, 20 May 2019 17:37:57 +0100 From: "Dr. David Alan Gilbert" To: Paolo Bonzini Message-ID: <20190520163756.GI2726@work-vm> References: <20190520030839.6795-1-peterx@redhat.com> <20190520030839.6795-14-peterx@redhat.com> <5d9174bc-0f3b-100f-e400-eeb94680020a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d9174bc-0f3b-100f-e400-eeb94680020a@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 20 May 2019 16:38:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 13/15] qmp: Expose manual_dirty_log_protect via "query-kvm" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , qemu-devel@nongnu.org, Peter Xu , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Paolo Bonzini (pbonzini@redhat.com) wrote: > On 20/05/19 05:08, Peter Xu wrote: > > Expose the new capability via "query-kvm" QMP command too so we know > > whether that's turned on on the source VM when we want. > > > > Signed-off-by: Peter Xu > > Is this useful? We could I guess make a migration capability in order > to benchmark with the old code, but otherwise I would just make this a > "hidden" optimization just like many others (same for patch 14). > > In other words, there are many other capabilities that we could inform > the user about, I don't see what makes manual_dirty_log_protect special. Yes agreed, if your kernel has it then just use it. Dave > Paolo > > > --- > > accel/kvm/kvm-all.c | 5 +++++ > > include/sysemu/kvm.h | 2 ++ > > qapi/misc.json | 6 +++++- > > qmp.c | 1 + > > 4 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > > index 062bf8b5b0..c79d6b51e2 100644 > > --- a/accel/kvm/kvm-all.c > > +++ b/accel/kvm/kvm-all.c > > @@ -169,6 +169,11 @@ int kvm_memcrypt_encrypt_data(uint8_t *ptr, uint64_t len) > > return 1; > > } > > > > +bool kvm_manual_dirty_log_protect_enabled(void) > > +{ > > + return kvm_state && kvm_state->manual_dirty_log_protect; > > +} > > + > > /* Must be with slots_lock held */ > > static KVMSlot *kvm_get_free_slot(KVMMemoryListener *kml) > > { > > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > > index a6d1cd190f..30757f1425 100644 > > --- a/include/sysemu/kvm.h > > +++ b/include/sysemu/kvm.h > > @@ -547,4 +547,6 @@ int kvm_set_one_reg(CPUState *cs, uint64_t id, void *source); > > int kvm_get_one_reg(CPUState *cs, uint64_t id, void *target); > > struct ppc_radix_page_info *kvm_get_radix_page_info(void); > > int kvm_get_max_memslots(void); > > +bool kvm_manual_dirty_log_protect_enabled(void); > > + > > #endif > > diff --git a/qapi/misc.json b/qapi/misc.json > > index 8b3ca4fdd3..ce7a76755a 100644 > > --- a/qapi/misc.json > > +++ b/qapi/misc.json > > @@ -253,9 +253,13 @@ > > # > > # @present: true if KVM acceleration is built into this executable > > # > > +# @manual-dirty-log-protect: true if manual dirty log protect is enabled > > +# > > # Since: 0.14.0 > > ## > > -{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} } > > +{ 'struct': 'KvmInfo', 'data': > > + {'enabled': 'bool', 'present': 'bool', > > + 'manual-dirty-log-protect': 'bool' } } > > > > ## > > # @query-kvm: > > diff --git a/qmp.c b/qmp.c > > index b92d62cd5f..047bef032e 100644 > > --- a/qmp.c > > +++ b/qmp.c > > @@ -73,6 +73,7 @@ KvmInfo *qmp_query_kvm(Error **errp) > > > > info->enabled = kvm_enabled(); > > info->present = kvm_available(); > > + info->manual_dirty_log_protect = kvm_manual_dirty_log_protect_enabled(); > > > > return info; > > } > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK