From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F38CC04AAC for ; Mon, 20 May 2019 21:03:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 069AC2171F for ; Mon, 20 May 2019 21:03:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 069AC2171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:41864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSpQy-0008TD-BL for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 17:03:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSpPD-0007gS-1n for qemu-devel@nongnu.org; Mon, 20 May 2019 17:01:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSpPA-0008TJ-WA for qemu-devel@nongnu.org; Mon, 20 May 2019 17:01:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50530) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSpP8-0008Fe-UW for qemu-devel@nongnu.org; Mon, 20 May 2019 17:01:08 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4796910C94; Mon, 20 May 2019 21:00:47 +0000 (UTC) Received: from localhost (ovpn-116-14.gru2.redhat.com [10.97.116.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81FA760BFC; Mon, 20 May 2019 21:00:41 +0000 (UTC) Date: Mon, 20 May 2019 18:00:40 -0300 From: Eduardo Habkost To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Message-ID: <20190520210040.GD10764@habkost.net> References: <20190215103239.28640-1-berrange@redhat.com> <20190215103239.28640-3-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20190215103239.28640-3-berrange@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 20 May 2019 21:00:49 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 2/2] Revert "globals: Allow global properties to be optional" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gonglei , Gerd Hoffmann , qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 15, 2019 at 10:32:39AM +0000, Daniel P. Berrang=E9 wrote: > This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa. >=20 > Relying on setting properties on parents types which may not > be relevant to certain sub-classes had unexpected side-effects > causing bugs in device config defaults. It is preferrable to > be explicit about which devices get which properties, even if > this needs repetition. >=20 > Signed-off-by: Daniel P. Berrang=E9 Reviewed-by: Eduardo Habkost --=20 Eduardo