From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3157C04E87 for ; Mon, 20 May 2019 21:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1EFC216B7 for ; Mon, 20 May 2019 21:20:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZBKI0me1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbfETVUt (ORCPT ); Mon, 20 May 2019 17:20:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41070 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726966AbfETVUq (ORCPT ); Mon, 20 May 2019 17:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=67UFBnzAcIhooBj87Gxyu93VVsiphW6C7t7vJSiFn+g=; b=ZBKI0me1jsOwkTLddaEYW8HZt/ 4M3BvguGwnK696sXVWqWwzWVGXj1UyIjPLK9VI/QRalKwEdn8BTuS0VxgsS7umz0AWQ7+/7HqivD9 Cc3g7LcjM5aBeDfAxJtspBPAB2e6/v/8MskU3C/Tpc4IIjXiDeZAd0wVIxOiyC1Pmzt4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hSpi5-00048K-5r; Mon, 20 May 2019 23:20:41 +0200 Date: Mon, 20 May 2019 23:20:41 +0200 From: Andrew Lunn To: Weifeng Voon Cc: "David S. Miller" , Maxime Coquelin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Abreu , Giuseppe Cavallaro , Alexandre Torgue , Ong Boon Leong , Tan Tee Min Subject: Re: [PATCH net] net: stmmac: fix ethtool flow control not able to get/set Message-ID: <20190520212041.GL22024@lunn.ch> References: <1558414542-28550-1-git-send-email-weifeng.voon@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1558414542-28550-1-git-send-email-weifeng.voon@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 12:55:42PM +0800, Weifeng Voon wrote: > From: "Tan, Tee Min" > > Currently ethtool was not able to get/set the flow control due to a > missing "!". It will always return -EOPNOTSUPP even the device is > flow control supported. > > This patch fixes the condition check for ethtool flow control get/set > function for ETHTOOL_LINK_MODE_Asym_Pause_BIT. > > Fixes: 3c1bcc8614db (“net: ethernet: Convert phydev advertize and supported from u32 to link mode”) > Signed-off-by: Tan, Tee Min > Reviewed-by: Ong Boon Leong > Signed-off-by: Voon, Weifeng Upps, my bad. Sorry. Reviewed-by: Andrew Lunn Andrew