From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4E8C04AAC for ; Mon, 20 May 2019 23:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B735F2173E for ; Mon, 20 May 2019 23:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558393246; bh=Bu2rVGOXLnzO4SsZwbzdIEo5OFrZN2qCWtzam2Ok+qw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NqXH/zq7vx5XKbLOcfcBxNxdP9NuOt/uIfYTudaSFEwh5ixI5fXnjU3jTT4e+W2aU DT2ah0Nk6AYxT/NzyCbaFDoKHw2yPq5DbjRe+jFBIsl5D2ecyGxfk+8dvWTCDdzG+q hM/2pllkd2+ORfJ9T32lwD90VvCAwz+qoAHbx/Go= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727272AbfETXAq (ORCPT ); Mon, 20 May 2019 19:00:46 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38911 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbfETXAp (ORCPT ); Mon, 20 May 2019 19:00:45 -0400 Received: by mail-pg1-f195.google.com with SMTP id j26so7497295pgl.5; Mon, 20 May 2019 16:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=14OretOU5ipUcLEuT7rLji+Wv0tITSxaTbRALv2BYJU=; b=s/6Ba07Du0GM/eBHid2PM64mJOAPVhS2AQFxuMRkuxXaVVaUF7jUNvzCY9j4jrvtLa ZBSLBfSk3lEsP2K9LJSRhD087itqoDf2gm2LrIStZkbXXzi1km4iIknMALxVDvpI9BkW mqp/jpulVqzejTGmK4XvylGX2e/rqdK2d9ZIILqvL4UTwPqcaJR87vIvohObrV0FfRLj R5Xh9K9veerDfYMJ6xzG/tlIW2p0OHL3nsEX5TdC3FsvmK98iR8ViijbCa8XdySXxPNk QaQKmscloJBA+lpCl+HuJcYOsP8E1zI3PmHINz8qbP21WnhoUh9bOWAEZGpCCdKSkyC1 0QLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=14OretOU5ipUcLEuT7rLji+Wv0tITSxaTbRALv2BYJU=; b=iojSC8JGX1hBeO5a3hZLV9e3qzcs2ZUFQ4JlTYBhQjP+YqpG1VDuWYnh7vle6AMUv5 sBM6exGiNPpQsD7Bny9DaeeKl+E0r5VtxB7XXu5mQxkOXzenx0UIobt3F1FqfEaB36jz gUEVXQYmnjYiyFWWzLuLsqfWzfF8ZMIk96VhC75IBmws6GOTq/7WG7jrA5GiwoIdWTaY YBRlnuIiDhnw6H0X2aQ1XRWr3GgpN3JjXDo5G9np6N1CV+KBVt9VUN8O/2bnNc5ciejN G4HcWoFuWbYqiYzm+QOhzd9jdiXw6gKS+ARusBnM4+EnWLyzsQgziFqy5H4MqXhEnLzf f4qg== X-Gm-Message-State: APjAAAVeH/Oj2bxQnlxffrBuye1dKicVZ65BaFsiz6ToZvoPAS93UZ63 hVbQ67YVhQ8L0JZ6vaFpFiM= X-Google-Smtp-Source: APXvYqwlCwv6iVt8qa4j7b5TNvEw9bZfLYV97XhCwcJ2kySvzUYz1Edq9V5cLMHIvd7IezTZ2SqKPA== X-Received: by 2002:a63:5fcc:: with SMTP id t195mr16800007pgb.120.1558393244797; Mon, 20 May 2019 16:00:44 -0700 (PDT) Received: from google.com ([2401:fa00:d:0:98f1:8b3d:1f37:3e8]) by smtp.gmail.com with ESMTPSA id g9sm18206791pgs.78.2019.05.20.16.00.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 16:00:43 -0700 (PDT) Date: Tue, 21 May 2019 08:00:38 +0900 From: Minchan Kim To: Michal Hocko Cc: Andrew Morton , LKML , linux-mm , Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Daniel Colascione , Shakeel Butt , Sonny Rao , Brian Geffon , linux-api@vger.kernel.org Subject: Re: [RFC 3/7] mm: introduce MADV_COLD Message-ID: <20190520230038.GD10039@google.com> References: <20190520035254.57579-1-minchan@kernel.org> <20190520035254.57579-4-minchan@kernel.org> <20190520082703.GX6836@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520082703.GX6836@dhcp22.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 10:27:03AM +0200, Michal Hocko wrote: > [Cc linux-api] > > On Mon 20-05-19 12:52:50, Minchan Kim wrote: > > When a process expects no accesses to a certain memory range > > for a long time, it could hint kernel that the pages can be > > reclaimed instantly but data should be preserved for future use. > > This could reduce workingset eviction so it ends up increasing > > performance. > > > > This patch introduces the new MADV_COLD hint to madvise(2) > > syscall. MADV_COLD can be used by a process to mark a memory range > > as not expected to be used for a long time. The hint can help > > kernel in deciding which pages to evict proactively. > > As mentioned in other email this looks like a non-destructive > MADV_DONTNEED alternative. > > > Internally, it works via reclaiming memory in process context > > the syscall is called. If the page is dirty but backing storage > > is not synchronous device, the written page will be rotate back > > into LRU's tail once the write is done so they will reclaim easily > > when memory pressure happens. If backing storage is > > synchrnous device(e.g., zram), hte page will be reclaimed instantly. > > Why do we special case async backing storage? Please always try to > explain _why_ the decision is made. I didn't make any decesion. ;-) That's how current reclaim works to avoid latency of freeing page in interrupt context. I had a patchset to resolve the concern a few years ago but got distracted. > > I haven't checked the implementation yet so I cannot comment on that. > > > Signed-off-by: Minchan Kim > > --- > > include/linux/swap.h | 1 + > > include/uapi/asm-generic/mman-common.h | 1 + > > mm/madvise.c | 123 +++++++++++++++++++++++++ > > mm/vmscan.c | 74 +++++++++++++++ > > 4 files changed, 199 insertions(+) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 64795abea003..7f32a948fc6a 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -365,6 +365,7 @@ extern int vm_swappiness; > > extern int remove_mapping(struct address_space *mapping, struct page *page); > > extern unsigned long vm_total_pages; > > > > +extern unsigned long reclaim_pages(struct list_head *page_list); > > #ifdef CONFIG_NUMA > > extern int node_reclaim_mode; > > extern int sysctl_min_unmapped_ratio; > > diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h > > index f7a4a5d4b642..b9b51eeb8e1a 100644 > > --- a/include/uapi/asm-generic/mman-common.h > > +++ b/include/uapi/asm-generic/mman-common.h > > @@ -43,6 +43,7 @@ > > #define MADV_WILLNEED 3 /* will need these pages */ > > #define MADV_DONTNEED 4 /* don't need these pages */ > > #define MADV_COOL 5 /* deactivatie these pages */ > > +#define MADV_COLD 6 /* reclaim these pages */ > > > > /* common parameters: try to keep these consistent across architectures */ > > #define MADV_FREE 8 /* free pages only if memory pressure */ > > diff --git a/mm/madvise.c b/mm/madvise.c > > index c05817fb570d..9a6698b56845 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -42,6 +42,7 @@ static int madvise_need_mmap_write(int behavior) > > case MADV_WILLNEED: > > case MADV_DONTNEED: > > case MADV_COOL: > > + case MADV_COLD: > > case MADV_FREE: > > return 0; > > default: > > @@ -416,6 +417,125 @@ static long madvise_cool(struct vm_area_struct *vma, > > return 0; > > } > > > > +static int madvise_cold_pte_range(pmd_t *pmd, unsigned long addr, > > + unsigned long end, struct mm_walk *walk) > > +{ > > + pte_t *orig_pte, *pte, ptent; > > + spinlock_t *ptl; > > + LIST_HEAD(page_list); > > + struct page *page; > > + int isolated = 0; > > + struct vm_area_struct *vma = walk->vma; > > + unsigned long next; > > + > > + next = pmd_addr_end(addr, end); > > + if (pmd_trans_huge(*pmd)) { > > + spinlock_t *ptl; > > + > > + ptl = pmd_trans_huge_lock(pmd, vma); > > + if (!ptl) > > + return 0; > > + > > + if (is_huge_zero_pmd(*pmd)) > > + goto huge_unlock; > > + > > + page = pmd_page(*pmd); > > + if (page_mapcount(page) > 1) > > + goto huge_unlock; > > + > > + if (next - addr != HPAGE_PMD_SIZE) { > > + int err; > > + > > + get_page(page); > > + spin_unlock(ptl); > > + lock_page(page); > > + err = split_huge_page(page); > > + unlock_page(page); > > + put_page(page); > > + if (!err) > > + goto regular_page; > > + return 0; > > + } > > + > > + if (isolate_lru_page(page)) > > + goto huge_unlock; > > + > > + list_add(&page->lru, &page_list); > > +huge_unlock: > > + spin_unlock(ptl); > > + reclaim_pages(&page_list); > > + return 0; > > + } > > + > > + if (pmd_trans_unstable(pmd)) > > + return 0; > > +regular_page: > > + orig_pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); > > + for (pte = orig_pte; addr < end; pte++, addr += PAGE_SIZE) { > > + ptent = *pte; > > + if (!pte_present(ptent)) > > + continue; > > + > > + page = vm_normal_page(vma, addr, ptent); > > + if (!page) > > + continue; > > + > > + if (page_mapcount(page) > 1) > > + continue; > > + > > + if (isolate_lru_page(page)) > > + continue; > > + > > + isolated++; > > + list_add(&page->lru, &page_list); > > + if (isolated >= SWAP_CLUSTER_MAX) { > > + pte_unmap_unlock(orig_pte, ptl); > > + reclaim_pages(&page_list); > > + isolated = 0; > > + pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); > > + orig_pte = pte; > > + } > > + } > > + > > + pte_unmap_unlock(orig_pte, ptl); > > + reclaim_pages(&page_list); > > + cond_resched(); > > + > > + return 0; > > +} > > + > > +static void madvise_cold_page_range(struct mmu_gather *tlb, > > + struct vm_area_struct *vma, > > + unsigned long addr, unsigned long end) > > +{ > > + struct mm_walk warm_walk = { > > + .pmd_entry = madvise_cold_pte_range, > > + .mm = vma->vm_mm, > > + }; > > + > > + tlb_start_vma(tlb, vma); > > + walk_page_range(addr, end, &warm_walk); > > + tlb_end_vma(tlb, vma); > > +} > > + > > + > > +static long madvise_cold(struct vm_area_struct *vma, > > + unsigned long start_addr, unsigned long end_addr) > > +{ > > + struct mm_struct *mm = vma->vm_mm; > > + struct mmu_gather tlb; > > + > > + if (vma->vm_flags & (VM_LOCKED|VM_HUGETLB|VM_PFNMAP)) > > + return -EINVAL; > > + > > + lru_add_drain(); > > + tlb_gather_mmu(&tlb, mm, start_addr, end_addr); > > + madvise_cold_page_range(&tlb, vma, start_addr, end_addr); > > + tlb_finish_mmu(&tlb, start_addr, end_addr); > > + > > + return 0; > > +} > > + > > static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, > > unsigned long end, struct mm_walk *walk) > > > > @@ -806,6 +926,8 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > > return madvise_willneed(vma, prev, start, end); > > case MADV_COOL: > > return madvise_cool(vma, start, end); > > + case MADV_COLD: > > + return madvise_cold(vma, start, end); > > case MADV_FREE: > > case MADV_DONTNEED: > > return madvise_dontneed_free(vma, prev, start, end, behavior); > > @@ -828,6 +950,7 @@ madvise_behavior_valid(int behavior) > > case MADV_DONTNEED: > > case MADV_FREE: > > case MADV_COOL: > > + case MADV_COLD: > > #ifdef CONFIG_KSM > > case MADV_MERGEABLE: > > case MADV_UNMERGEABLE: > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index a28e5d17b495..1701b31f70a8 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2096,6 +2096,80 @@ static void shrink_active_list(unsigned long nr_to_scan, > > nr_deactivate, nr_rotated, sc->priority, file); > > } > > > > +unsigned long reclaim_pages(struct list_head *page_list) > > +{ > > + int nid = -1; > > + unsigned long nr_isolated[2] = {0, }; > > + unsigned long nr_reclaimed = 0; > > + LIST_HEAD(node_page_list); > > + struct reclaim_stat dummy_stat; > > + struct scan_control sc = { > > + .gfp_mask = GFP_KERNEL, > > + .priority = DEF_PRIORITY, > > + .may_writepage = 1, > > + .may_unmap = 1, > > + .may_swap = 1, > > + }; > > + > > + while (!list_empty(page_list)) { > > + struct page *page; > > + > > + page = lru_to_page(page_list); > > + list_del(&page->lru); > > + > > + if (nid == -1) { > > + nid = page_to_nid(page); > > + INIT_LIST_HEAD(&node_page_list); > > + nr_isolated[0] = nr_isolated[1] = 0; > > + } > > + > > + if (nid == page_to_nid(page)) { > > + list_add(&page->lru, &node_page_list); > > + nr_isolated[!!page_is_file_cache(page)] += > > + hpage_nr_pages(page); > > + continue; > > + } > > + > > + nid = page_to_nid(page); > > + > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_ANON, > > + nr_isolated[0]); > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_FILE, > > + nr_isolated[1]); > > + nr_reclaimed += shrink_page_list(&node_page_list, > > + NODE_DATA(nid), &sc, TTU_IGNORE_ACCESS, > > + &dummy_stat, true); > > + while (!list_empty(&node_page_list)) { > > + struct page *page = lru_to_page(page_list); > > + > > + list_del(&page->lru); > > + putback_lru_page(page); > > + } > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_ANON, > > + -nr_isolated[0]); > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_FILE, > > + -nr_isolated[1]); > > + nr_isolated[0] = nr_isolated[1] = 0; > > + INIT_LIST_HEAD(&node_page_list); > > + } > > + > > + if (!list_empty(&node_page_list)) { > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_ANON, > > + nr_isolated[0]); > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_FILE, > > + nr_isolated[1]); > > + nr_reclaimed += shrink_page_list(&node_page_list, > > + NODE_DATA(nid), &sc, TTU_IGNORE_ACCESS, > > + &dummy_stat, true); > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_ANON, > > + -nr_isolated[0]); > > + mod_node_page_state(NODE_DATA(nid), NR_ISOLATED_FILE, > > + -nr_isolated[1]); > > + } > > + > > + return nr_reclaimed; > > +} > > + > > /* > > * The inactive anon list should be small enough that the VM never has > > * to do too much work. > > -- > > 2.21.0.1020.gf2820cf01a-goog > > > > -- > Michal Hocko > SUSE Labs