All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/pkg-infra: host variant inherits DL_SUBDIR
Date: Mon, 20 May 2019 23:01:19 +0200	[thread overview]
Message-ID: <20190520230119.05902d36@windsurf.home> (raw)
In-Reply-To: <20190428174458.10458-1-yann.morin.1998@free.fr>

On Sun, 28 Apr 2019 19:44:58 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> We have no clear separation between variables that should be
> automatically inherited by the host variant, from the target
> variant, and those variables that should not be inherited.
> 
> However, it clearly makes sense that the host variant does inherit
> all the download variables, of which the sub-directory.
> 
> Notes: currently, only three packages define HOST_FOO_DL_SUBDIR,
> but they all are host-only packages anyway, so needs not be fixed:
>   - gcc-initial
>   - gcc-final
>   - python3-setuptools
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/pkg-generic.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

Following the comments from Arnout, I marked this patch as Changes
Requested in patchwork. Could you send an updated version ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2019-05-20 21:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28 17:44 [Buildroot] [PATCH] core/pkg-infra: host variant inherits DL_SUBDIR Yann E. MORIN
2019-04-29 20:28 ` Arnout Vandecappelle
2019-05-20 21:01 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520230119.05902d36@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.