From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD81AC04AAC for ; Mon, 20 May 2019 23:36:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 936BD20863 for ; Mon, 20 May 2019 23:36:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 936BD20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrpV-0003SO-PU for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 19:36:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSrQs-0007Sg-Nn for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSrQr-00087a-SV for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:02 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSrQr-00087N-OG for qemu-devel@nongnu.org; Mon, 20 May 2019 19:11:01 -0400 Received: by mail-qt1-f193.google.com with SMTP id j53so18342669qta.9 for ; Mon, 20 May 2019 16:11:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/K1CzhcIoF7fjAc30rHRUsge+GK+glXAnsnZpkxETzA=; b=XXkQ3zx+wyYXU45f2+jQaZF2dlcXIU3xznFn+fN9JP8ctDfkfJLgnr0KNLMc+B4hwT +NTwTUixKeO9bLr0RoVBeyJVkrsbZhmtKKwT7oJv73sJlMQP1oFWQdqgc2PshzGh79FP Z2AprlMlopNZmXwaBMrgdr/XVCGjECShcKh1ZLcOXSUIWUE4TFUtWyoC7vOWWO97Qf3Y 3cmoAHt15EIpO8TlmYIbI49tLhqvXslW21Yk3yajiH3Ymnjr3Cjk5dPUybEJs4lZPZ8+ Ww/6L09Zj233+Ulm3I3iEVwhd52LkebHggWuc4TGXrbevAKxeX7Q5HlyRQPLIzlQA6F6 uGRQ== X-Gm-Message-State: APjAAAUc2xbd+XZrri5re5ZJQqujavwhlD4hFoLvmyXhjicp7fVxJKPB sUYY05Uq+TgtRMzTaZhdhGeTPKfXM3Y= X-Google-Smtp-Source: APXvYqxoONLWRzCQrgT6CBbhquNH0TPoP8OWzvFrI+zQvC2n593uu+BgpCbFzH1EZYfcaR6XDZHfaA== X-Received: by 2002:a0c:d909:: with SMTP id p9mr49615208qvj.42.1558393860861; Mon, 20 May 2019 16:11:00 -0700 (PDT) Received: from redhat.com (pool-173-76-105-71.bstnma.fios.verizon.net. [173.76.105.71]) by smtp.gmail.com with ESMTPSA id e54sm11315139qtc.26.2019.05.20.16.10.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 16:11:00 -0700 (PDT) Date: Mon, 20 May 2019 19:10:59 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190419003053.8260-3-richardw.yang@linux.intel.com> References: <20190520231008.20140-1-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190520231008.20140-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PULL v2 16/36] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Shannon Zhao , qemu-arm@nongnu.org, Wei Yang , Igor Mammedov , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190520231059.uq8wlctxn1swGFWKw_IUpRtEZKj9XXnY53zz5Wk_5jE@z> From: Wei Yang mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190419003053.8260-3-richardw.yang@linux.intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bf9c0bc2f4..12dbaf3846 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- MST