All of lore.kernel.org
 help / color / mirror / Atom feed
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH] nvme-pci: fix single segment optimization
Date: Tue, 21 May 2019 09:08:08 +0800	[thread overview]
Message-ID: <20190521010806.GB14268@ming.t460p> (raw)
In-Reply-To: <20190520111601.GC5137@lst.de>

On Mon, May 20, 2019@01:16:01PM +0200, Christoph Hellwig wrote:
> Given that the code only showed up in 5.2 I'd rather try to fix the
> block layer issue, lets see what Jens says.  But if not I defintively
> want the comment from my earlier patch, and to me the
> !req->bio->bi_next && req->bio->bi_vcnt == 1 check also seems slighly

The check on 'req->bio->bi_vcnt == 1' should really be avoided, and it
isn't needed too.

thanks,
Ming

      reply	other threads:[~2019-05-21  1:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 22:50 [PATCH] nvme-pci: fix single segment optimization Ming Lei
2019-05-20 11:16 ` Christoph Hellwig
2019-05-21  1:08   ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521010806.GB14268@ming.t460p \
    --to=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.