From: Adrian Bunk <bunk@stusta.de>
To: Armin Kuster <akuster808@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [warrior][patch 21/34] packagegroup-meta-networking: replace DISTRO_FEATURE by DISTRO_FEATURES
Date: Tue, 21 May 2019 12:41:32 +0300 [thread overview]
Message-ID: <20190521094132.GF15108@localhost> (raw)
In-Reply-To: <b1fdd51d97dca34a7221649831fc3e0d832219b5.1558410874.git.akuster808@gmail.com>
On Mon, May 20, 2019 at 08:56:21PM -0700, Armin Kuster wrote:
>...
> --- a/meta-networking/recipes-core/packagegroups/packagegroup-meta-networking.bb
> +++ b/meta-networking/recipes-core/packagegroups/packagegroup-meta-networking.bb
> @@ -38,8 +38,9 @@ RDEPENDS_packagegroup-meta-networking-connectivity = "\
> inetutils wolfssl lftp miniupnpd networkmanager \
> networkmanager-openvpn rdist nanomsg python-networkmanager \
> wireless-regdb \
> - ${@bb.utils.contains("DISTRO_FEATURE", "bluez5 x11", "blueman", "", d)} \
> - ${@bb.utils.contains("DISTRO_FEATURE", "pam", "samba", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "bluez5 x11", "blueman", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "pam", "samba", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "pam", "samba", "", d)} \
> "
>
> RDEPENDS_packagegroup-meta-networking-daemons = "\
> @@ -47,7 +48,7 @@ RDEPENDS_packagegroup-meta-networking-daemons = "\
> ptpd igmpproxy opensaf squid \
> atftp postfix iscsi-initiator-utils vsftpd cyrus-sasl \
> pure-ftpd vblade tftp-hpa ncftp \
> - ${@bb.utils.contains("DISTRO_FEATURE", "systemd", "networkd-dispatcher", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "networkd-dispatcher", "", d)} \
> "
>
> RDEPENDS_packagegroup-meta-networking-devtools = "\
> @@ -56,7 +57,7 @@ RDEPENDS_packagegroup-meta-networking-devtools = "\
>
> RDEPENDS_packagegroup-meta-networking-extended = "\
> corosync \
> - ${@bb.utils.contains("DISTRO_FEATURE", "systemd", "dlm", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "dlm", "", d)} \
> "
>
> RDEPENDS_packagegroup-meta-networking-filter = "\
> @@ -85,7 +86,7 @@ RDEPENDS_packagegroup-meta-networking-protocols = "\
> tsocks freediameter xl2tpd babeld mdns net-snmp \
> quagga pptp-linux zeroconf nopoll openflow rp-pppoe \
> radiusclient-ng openl2tp usrsctp \
> - ${@bb.utils.contains("DISTRO_FEATURE", "pam", "dante", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "pam", "dante", "", d)} \
> "
>
> RDEPENDS_packagegroup-meta-networking-support = "\
> @@ -104,7 +105,7 @@ RDEPENDS_packagegroup-meta-networking-support = "\
> netcat-openbsd fetchmail yp-tools ypbind-mt yp-tools \
> arptables macchanger nghttp2 strongswan fping \
> dnssec-conf libesmtp cifs-utils open-isns \
> - ${@bb.utils.contains("DISTRO_FEATURE", "pam", "libldb", "", d)} \
> + ${@bb.utils.contains("DISTRO_FEATURES", "pam", "libldb", "", d)} \
> ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "non-commercial", "netperf", "", d)} \
> ${@bb.utils.contains_any("TRANSLATED_TARGET_ARCH", "i586 x86-64", "spice", "", d)} \
> "
>...
This adds packages to packagegroups in a stable series.
I'd say removing the broken DISTRO_FEATURE lines would be better
than changing what gets installed to images in warrior.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-05-21 9:41 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 3:56 [warrior][patch 00/34] Patch review Armin Kuster
2019-05-21 3:56 ` [warrior][patch 01/34] cpupower: remove LIC_FILES_CHKSUM Armin Kuster
2019-05-21 3:56 ` [warrior][patch 02/34] python-pyasn1: upgrade 0.4.4 -> 0.4.5 Armin Kuster
2019-05-21 6:40 ` Adrian Bunk
2019-05-21 14:52 ` akuster808
2019-05-21 18:05 ` Adrian Bunk
2019-05-21 3:56 ` [warrior][patch 03/34] php: upgrade 7.3.2 -> 7.3.4 Armin Kuster
2019-05-21 6:41 ` Adrian Bunk
2019-05-21 3:56 ` [warrior][patch 04/34] postgresql: fix compile error Armin Kuster
2019-05-21 3:56 ` [warrior][patch 05/34] openhpi: update openhpi-fix-testfail-errors.patch Armin Kuster
2019-05-21 3:56 ` [warrior][patch 06/34] phpmyadmin: upgrade 4.8.3 -> 4.8.5 Armin Kuster
2019-05-21 6:41 ` Adrian Bunk
2019-05-21 3:56 ` [warrior][patch 07/34] xfce4-vala: auto-detect vala api version Armin Kuster
2019-05-21 3:56 ` [warrior][patch 08/34] gnome-desktop3: set correct meson gtk doc option Armin Kuster
2019-05-21 8:08 ` Adrian Bunk
2019-05-21 16:37 ` akuster808
2019-05-21 3:56 ` [warrior][patch 09/34] esound: fix SRC_URI for multilib Armin Kuster
2019-05-21 3:56 ` [warrior][patch 10/34] opusfile: " Armin Kuster
2019-05-21 3:56 ` [warrior][patch 11/34] miniupnpd: " Armin Kuster
2019-05-21 3:56 ` [warrior][patch 12/34] zbar: " Armin Kuster
2019-05-21 3:56 ` [warrior][patch 13/34] cpupower: Inherit bash completion class Armin Kuster
2019-05-21 3:56 ` [warrior][patch 14/34] python-urllib3: Set CVE_PRODUCT Armin Kuster
2019-05-21 3:56 ` [warrior][patch 15/34] python3-pillow: " Armin Kuster
2019-05-21 3:56 ` [warrior][patch 16/34] python-requests: " Armin Kuster
2019-05-21 3:56 ` [warrior][patch 17/34] evince: add patch to fix build with recent gobject-introspection Armin Kuster
2019-05-21 9:33 ` Adrian Bunk
2019-05-21 16:38 ` akuster808
2019-05-21 3:56 ` [warrior][patch 18/34] php: correct httpd path Armin Kuster
2019-05-21 3:56 ` [warrior][patch 19/34] pmtools: use update-alternatives for acpidump Armin Kuster
2019-05-21 3:56 ` [warrior][patch 20/34] xfce4-cpufreq-plugin: Fix memory leak and reduce CPU load Armin Kuster
2019-05-21 3:56 ` [warrior][patch 21/34] packagegroup-meta-networking: replace DISTRO_FEATURE by DISTRO_FEATURES Armin Kuster
2019-05-21 9:41 ` Adrian Bunk [this message]
2019-05-21 9:55 ` Martin Jansa
2019-05-21 3:56 ` [warrior][patch 22/34] meta-xfce: add meta-networking to layer depends Armin Kuster
2019-05-21 3:56 ` [warrior][patch 23/34] itstool: rework - it went out too early Armin Kuster
2019-05-21 3:56 ` [warrior][patch 24/34] mongodb: Fix build with gcc Armin Kuster
2019-05-21 3:56 ` [warrior][patch 25/34] ebtables: add UPSTREAM_CHECK_URI Armin Kuster
2019-05-21 9:43 ` Adrian Bunk
2019-05-21 3:56 ` [warrior][patch 26/34] netkit-rsh: add tag to CVE patch Armin Kuster
2019-05-21 3:56 ` [warrior][patch 27/34] ipsec-tools: fix CVE tag in patch Armin Kuster
2019-05-21 3:56 ` [warrior][patch 28/34] gd: set CVE_PRODUCT Armin Kuster
2019-05-21 3:56 ` [warrior][patch 29/34] doxygen: replace ninja 1.9.0 fix with official one Armin Kuster
2019-05-21 3:56 ` [warrior][patch 30/34] samba: update to 4.8.11 Armin Kuster
2019-05-21 3:56 ` [warrior][patch 31/34] openvpn: update to 2.4.7 Armin Kuster
2019-05-21 6:55 ` Adrian Bunk
2019-05-21 3:56 ` [warrior][patch 32/34] efivar: prevent native efivar depending on target kernel Armin Kuster
2019-05-21 3:56 ` [warrior][patch 33/34] libdbi-perl: prevent native libdbi-perl depending on target perl Armin Kuster
2019-05-21 3:56 ` [warrior][patch 34/34] aufs-util: prevent native aufs-util depending on target kernel Armin Kuster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521094132.GF15108@localhost \
--to=bunk@stusta.de \
--cc=akuster808@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.