All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Doron <arilou@gmail.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, Jon Doron <arilou@gmail.com>
Subject: [Qemu-devel] [PATCH v10 19/20] gdbstub: Clear unused variables in gdb_handle_packet
Date: Tue, 21 May 2019 12:59:47 +0300	[thread overview]
Message-ID: <20190521095948.8204-20-arilou@gmail.com> (raw)
In-Reply-To: <20190521095948.8204-1-arilou@gmail.com>

Signed-off-by: Jon Doron <arilou@gmail.com>
---
 gdbstub.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/gdbstub.c b/gdbstub.c
index 097b7d1231..9dd934a079 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -2270,17 +2270,11 @@ static void handle_target_halt(GdbCmdContext *gdb_ctx, void *user_ctx)
 
 static int gdb_handle_packet(GDBState *s, const char *line_buf)
 {
-    const char *p;
-    int ch;
-    uint8_t mem_buf[MAX_PACKET_LENGTH];
-    char buf[sizeof(mem_buf) + 1 /* trailing NUL */];
     const GdbCmdParseEntry *cmd_parser = NULL;
 
     trace_gdbstub_io_command(line_buf);
 
-    p = line_buf;
-    ch = *p++;
-    switch(ch) {
+    switch (line_buf[0]) {
     case '!':
         put_packet(s, "OK");
         break;
@@ -2497,8 +2491,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
         break;
     default:
         /* put empty packet */
-        buf[0] = '\0';
-        put_packet(s, buf);
+        put_packet(s, "");
         break;
     }
 
-- 
2.21.0



  parent reply	other threads:[~2019-05-21 10:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  9:59 [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 01/20] gdbstub: Add infrastructure to parse cmd packets Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 02/20] gdbstub: Implement deatch (D pkt) with new infra Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 03/20] gdbstub: Implement thread_alive (T " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 04/20] gdbstub: Implement continue (c " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 05/20] gdbstub: Implement continue with signal (C " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 06/20] gdbstub: Implement set_thread (H " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 07/20] gdbstub: Implement breakpoint commands (Z/z " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 09/20] gdbstub: Implement get register (p " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 10/20] gdbstub: Implement write memory (M " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 11/20] gdbstub: Implement read memory (m " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 12/20] gdbstub: Implement write all registers (G " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 13/20] gdbstub: Implement read all registers (g " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 14/20] gdbstub: Implement file io (F " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 15/20] gdbstub: Implement step (s " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 16/20] gdbstub: Implement v commands " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 17/20] gdbstub: Implement generic set/query (Q/q pkt) " Jon Doron
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 18/20] gdbstub: Implement target halted (? " Jon Doron
2019-05-21  9:59 ` Jon Doron [this message]
2019-05-21  9:59 ` [Qemu-devel] [PATCH v10 20/20] gdbstub: Implement qemu physical memory mode Jon Doron
2019-05-23 10:36 ` [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521095948.8204-20-arilou@gmail.com \
    --to=arilou@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.