From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7100CC46460 for ; Tue, 21 May 2019 10:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46C2B21743 for ; Tue, 21 May 2019 10:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="m29HCqX2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727595AbfEUK1Z (ORCPT ); Tue, 21 May 2019 06:27:25 -0400 Received: from vps.xff.cz ([195.181.215.36]:38106 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfEUK1Z (ORCPT ); Tue, 21 May 2019 06:27:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1558434441; bh=H6MrKqqtdax1I2XXyrIgpDdBNiCoz5e/dUQ3W4MknQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m29HCqX2SN+8L1d5/7f5EvQHqPXlEn9XXs31rwizmVmEdBITHL/a3TU6OMvTBHDcw yUjXEsxaziEiajsSIS0H84WyhAC2+H0eBJWcb+jZqN2avYXfv90LK3Q1e+1qfkVgAJ uJODrBg6bk4nHXnynQwSIMwDEaWMaD5TL+M7adhA= Date: Tue, 21 May 2019 12:27:21 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Cc: Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Message-ID: <20190521102721.5hgks6guzlhubj6d@core.my.home> Mail-Followup-To: Maxime Ripard , Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190521080515.qlni2lnmcwh7itl7@flea> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Tue, May 21, 2019 at 10:05:15AM +0200, Maxime Ripard wrote: > On Sat, May 18, 2019 at 01:27:39AM +0800, Frank Lee wrote: > > On Fri, May 17, 2019 at 3:36 PM Maxime Ripard wrote: > > > > > > On Fri, May 17, 2019 at 01:51:56AM +0800, Frank Lee wrote: > > > > > > +struct sun50i_thermal_chip { > > > > > > + int sensor_num; > > > > > > + int offset; > > > > > > + int scale; > > > > > > + int ft_deviation; > > > > > > + int temp_calib_base; > > > > > > + int temp_data_base; > > > > > > + int (*enable)(struct tsens_device *tmdev); > > > > > > + int (*disable)(struct tsens_device *tmdev); > > > > > > +}; > > > > > > > > > > I'm not super fond of having a lot of quirks that are not needed. If > > > > > we ever need those quirks when adding support for a new SoC, then > > > > > yeah, we should totally have some, but only when and if it's needed. > > > > > > > > > > Otherwise, the driver is more complicated for no particular reason. > > > > > > > > This is unavoidable because of the difference in soc. > > > > > > I know, but this isn't my point. > > > > > > My point is that at this time of the driver development, we don't know > > > what is going to be needed to support all of those SoCs. > > > > > > Some of the parameters you added might not be needed, some parameters > > > might be missing, we don't know. So let's keep it simple for now. > > > > > > > > > +static int tsens_probe(struct platform_device *pdev) > > > > > > +{ > > > > > > + struct tsens_device *tmdev; > > > > > > + struct device *dev = &pdev->dev; > > > > > > + int ret; > > > > > > + > > > > > > + tmdev = devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > > > > > + if (!tmdev) > > > > > > + return -ENOMEM; > > > > > > + > > > > > > + tmdev->dev = dev; > > > > > > + tmdev->chip = of_device_get_match_data(&pdev->dev); > > > > > > + if (!tmdev->chip) > > > > > > + return -EINVAL; > > > > > > + > > > > > > + ret = tsens_init(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + ret = tsens_register(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + ret = tmdev->chip->enable(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > > > > > > > + platform_set_drvdata(pdev, tmdev); > > > > > > > > > > Your registration should be the very last thing you do. Otherwise, you > > > > > have a small window where the get_temp callback can be called, but the > > > > > driver will not be functional yet. > > > > > > > > No. Anyway, ths data qcquisition is ms level. > > > > > > That's kind of irrelevant. There's nothing preventing get_temp to be > > > called right away. > > > > As Ondřej said, > > > > Registration after enabling will lead to call tz update on non-registered tz > > from an interrupt handler. > > I'm probably missing something but you're not using the interrupts, so > how could an interrupt handler call it? > > Also, other drivers seem to be doing that just fine (mtk_thermal for > example), so surely there's a way? Last version is using the interrupts. Drivers do it in various ways. For example imx_thermal (and others like hisi_thermal) does it the suggested way. It enables interrupts after thermal zone registration, so that IRQ handler doesn't get invoked before the tzd is registered. regards, o. > > > > > > + ret = tsens_calibrate(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + /* > > > > > > + * clkin = 24MHz > > > > > > + * T acquire = clkin / (SUN50I_THS_CTRL0_T_ACQ + 1) > > > > > > + * = 20us > > > > > > + */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0, > > > > > > + SUN50I_THS_CTRL0_T_ACQ(479)); > > > > > > + /* average over 4 samples */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC, > > > > > > + SUN50I_THS_FILTER_EN | > > > > > > + SUN50I_THS_FILTER_TYPE(1)); > > > > > > + /* period = (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; ~10ms */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC, > > > > > > + SUN50I_H6_THS_PC_TEMP_PERIOD(58)); > > > > > > + /* enable sensor */ > > > > > > + val = GENMASK(tmdev->chip->sensor_num - 1, 0); > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_ENABLE, val); > > > > > > + > > > > > > + return 0; > > > > > > + > > > > > > +assert_reset: > > > > > > + reset_control_assert(tmdev->reset); > > > > > > + > > > > > > + return ret; > > > > > > > > > > Can't we do that with runtime_pm? > > > > > > > > Saving energy doesn't make much sense compared to system security. > > > > > > I'm not sure what you mean by security. > > > > Protect system hardware from damage. > > The point of runtime_pm is to keep the device on as long as it is > used, so it wouldn't change anything there. > > I mean, you can even enable it in the probe if you want, my point is > that the hooks that you have are exact equivalents to the one provided > by runtime_pm already, so there's no need to define them in the first > place. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ond=C5=99ej?= Jirman Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Date: Tue, 21 May 2019 12:27:21 +0200 Message-ID: <20190521102721.5hgks6guzlhubj6d@core.my.home> References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190521080515.qlni2lnmcwh7itl7@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org Hi Maxime, On Tue, May 21, 2019 at 10:05:15AM +0200, Maxime Ripard wrote: > On Sat, May 18, 2019 at 01:27:39AM +0800, Frank Lee wrote: > > On Fri, May 17, 2019 at 3:36 PM Maxime Ripard wrote: > > > > > > On Fri, May 17, 2019 at 01:51:56AM +0800, Frank Lee wrote: > > > > > > +struct sun50i_thermal_chip { > > > > > > + int sensor_num; > > > > > > + int offset; > > > > > > + int scale; > > > > > > + int ft_deviation; > > > > > > + int temp_calib_base; > > > > > > + int temp_data_base; > > > > > > + int (*enable)(struct tsens_device *tmdev); > > > > > > + int (*disable)(struct tsens_device *tmdev); > > > > > > +}; > > > > > > > > > > I'm not super fond of having a lot of quirks that are not needed. If > > > > > we ever need those quirks when adding support for a new SoC, then > > > > > yeah, we should totally have some, but only when and if it's needed. > > > > > > > > > > Otherwise, the driver is more complicated for no particular reason. > > > > > > > > This is unavoidable because of the difference in soc. > > > > > > I know, but this isn't my point. > > > > > > My point is that at this time of the driver development, we don't know > > > what is going to be needed to support all of those SoCs. > > > > > > Some of the parameters you added might not be needed, some parameters > > > might be missing, we don't know. So let's keep it simple for now. > > > > > > > > > +static int tsens_probe(struct platform_device *pdev) > > > > > > +{ > > > > > > + struct tsens_device *tmdev; > > > > > > + struct device *dev = &pdev->dev; > > > > > > + int ret; > > > > > > + > > > > > > + tmdev = devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > > > > > + if (!tmdev) > > > > > > + return -ENOMEM; > > > > > > + > > > > > > + tmdev->dev = dev; > > > > > > + tmdev->chip = of_device_get_match_data(&pdev->dev); > > > > > > + if (!tmdev->chip) > > > > > > + return -EINVAL; > > > > > > + > > > > > > + ret = tsens_init(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + ret = tsens_register(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + ret = tmdev->chip->enable(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > > > > > > > + platform_set_drvdata(pdev, tmdev); > > > > > > > > > > Your registration should be the very last thing you do. Otherwise, you > > > > > have a small window where the get_temp callback can be called, but the > > > > > driver will not be functional yet. > > > > > > > > No. Anyway, ths data qcquisition is ms level. > > > > > > That's kind of irrelevant. There's nothing preventing get_temp to be > > > called right away. > > > > As Ondřej said, > > > > Registration after enabling will lead to call tz update on non-registered tz > > from an interrupt handler. > > I'm probably missing something but you're not using the interrupts, so > how could an interrupt handler call it? > > Also, other drivers seem to be doing that just fine (mtk_thermal for > example), so surely there's a way? Last version is using the interrupts. Drivers do it in various ways. For example imx_thermal (and others like hisi_thermal) does it the suggested way. It enables interrupts after thermal zone registration, so that IRQ handler doesn't get invoked before the tzd is registered. regards, o. > > > > > > + ret = tsens_calibrate(tmdev); > > > > > > + if (ret) > > > > > > + return ret; > > > > > > + > > > > > > + /* > > > > > > + * clkin = 24MHz > > > > > > + * T acquire = clkin / (SUN50I_THS_CTRL0_T_ACQ + 1) > > > > > > + * = 20us > > > > > > + */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0, > > > > > > + SUN50I_THS_CTRL0_T_ACQ(479)); > > > > > > + /* average over 4 samples */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC, > > > > > > + SUN50I_THS_FILTER_EN | > > > > > > + SUN50I_THS_FILTER_TYPE(1)); > > > > > > + /* period = (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; ~10ms */ > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC, > > > > > > + SUN50I_H6_THS_PC_TEMP_PERIOD(58)); > > > > > > + /* enable sensor */ > > > > > > + val = GENMASK(tmdev->chip->sensor_num - 1, 0); > > > > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_ENABLE, val); > > > > > > + > > > > > > + return 0; > > > > > > + > > > > > > +assert_reset: > > > > > > + reset_control_assert(tmdev->reset); > > > > > > + > > > > > > + return ret; > > > > > > > > > > Can't we do that with runtime_pm? > > > > > > > > Saving energy doesn't make much sense compared to system security. > > > > > > I'm not sure what you mean by security. > > > > Protect system hardware from damage. > > The point of runtime_pm is to keep the device on as long as it is > used, so it wouldn't change anything there. > > I mean, you can even enable it in the probe if you want, my point is > that the hooks that you have are exact equivalents to the one provided > by runtime_pm already, so there's no need to define them in the first > place. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6AEC04E87 for ; Tue, 21 May 2019 10:27:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01AD021743 for ; Tue, 21 May 2019 10:27:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="owS/0j5X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="m29HCqX2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01AD021743 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4qPSGEO6iDpTBPIabVdObVZ9STOEXIYeLzaTOWkzaJ8=; b=owS/0j5XFpsJY/ e9qXVNzPZhnJfatiFoQIPhsSGH1bJEH0iQt8KVfZWGNozTaXBoPpiCFzLJxllkQCgzoCDcOmVtaJ9 YlHnOD3wdrcobc8Y7f4dkquSgRbVDDWMZ6nBJOh39xEg9nLiDxT9x2muOn94q3lhJJ9LQ8uVDXeuJ KVxEb+LvIM1F59xHoH03Rnr44u/mZQ4+J0CcgU091yLsyOh4EixcVHWwOaWCccV1IekBqM7dI8r+D kNpVbsZ5ugAakMEMyXqdrW7T5GwkyI7bmuR5581TUSnHvFOSZrbl/A+y4XDH59IfIg+wC3KjAKXRp chGXWJcFvKghwMcZ+UCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT1zT-0005Ac-Qc; Tue, 21 May 2019 10:27:27 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT1zP-0005AC-SM for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 10:27:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1558434441; bh=H6MrKqqtdax1I2XXyrIgpDdBNiCoz5e/dUQ3W4MknQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m29HCqX2SN+8L1d5/7f5EvQHqPXlEn9XXs31rwizmVmEdBITHL/a3TU6OMvTBHDcw yUjXEsxaziEiajsSIS0H84WyhAC2+H0eBJWcb+jZqN2avYXfv90LK3Q1e+1qfkVgAJ uJODrBg6bk4nHXnynQwSIMwDEaWMaD5TL+M7adhA= Date: Tue, 21 May 2019 12:27:21 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Message-ID: <20190521102721.5hgks6guzlhubj6d@core.my.home> Mail-Followup-To: Maxime Ripard , Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190521080515.qlni2lnmcwh7itl7@flea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_032724_423473_776C8E46 X-CRM114-Status: GOOD ( 33.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Frank Lee , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, marc.w.gonzalez@free.fr, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Daniel Lezcano , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, Linux PM , Eduardo Valentin , olof@lixom.net, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , enric.balletbo@collabora.com, David Miller Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWF4aW1lLAoKT24gVHVlLCBNYXkgMjEsIDIwMTkgYXQgMTA6MDU6MTVBTSArMDIwMCwgTWF4 aW1lIFJpcGFyZCB3cm90ZToKPiBPbiBTYXQsIE1heSAxOCwgMjAxOSBhdCAwMToyNzozOUFNICsw ODAwLCBGcmFuayBMZWUgd3JvdGU6Cj4gPiBPbiBGcmksIE1heSAxNywgMjAxOSBhdCAzOjM2IFBN IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+IHdyb3RlOgo+ID4gPgo+ ID4gPiBPbiBGcmksIE1heSAxNywgMjAxOSBhdCAwMTo1MTo1NkFNICswODAwLCBGcmFuayBMZWUg d3JvdGU6Cj4gPiA+ID4gPiA+ICtzdHJ1Y3Qgc3VuNTBpX3RoZXJtYWxfY2hpcCB7Cj4gPiA+ID4g PiA+ICsgICAgIGludCAgICAgc2Vuc29yX251bTsKPiA+ID4gPiA+ID4gKyAgICAgaW50ICAgICBv ZmZzZXQ7Cj4gPiA+ID4gPiA+ICsgICAgIGludCAgICAgc2NhbGU7Cj4gPiA+ID4gPiA+ICsgICAg IGludCAgICAgZnRfZGV2aWF0aW9uOwo+ID4gPiA+ID4gPiArICAgICBpbnQgICAgIHRlbXBfY2Fs aWJfYmFzZTsKPiA+ID4gPiA+ID4gKyAgICAgaW50ICAgICB0ZW1wX2RhdGFfYmFzZTsKPiA+ID4g PiA+ID4gKyAgICAgaW50ICAgICAoKmVuYWJsZSkoc3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXYp Owo+ID4gPiA+ID4gPiArICAgICBpbnQgICAgICgqZGlzYWJsZSkoc3RydWN0IHRzZW5zX2Rldmlj ZSAqdG1kZXYpOwo+ID4gPiA+ID4gPiArfTsKPiA+ID4gPiA+Cj4gPiA+ID4gPiBJJ20gbm90IHN1 cGVyIGZvbmQgb2YgaGF2aW5nIGEgbG90IG9mIHF1aXJrcyB0aGF0IGFyZSBub3QgbmVlZGVkLiBJ Zgo+ID4gPiA+ID4gd2UgZXZlciBuZWVkIHRob3NlIHF1aXJrcyB3aGVuIGFkZGluZyBzdXBwb3J0 IGZvciBhIG5ldyBTb0MsIHRoZW4KPiA+ID4gPiA+IHllYWgsIHdlIHNob3VsZCB0b3RhbGx5IGhh dmUgc29tZSwgYnV0IG9ubHkgd2hlbiBhbmQgaWYgaXQncyBuZWVkZWQuCj4gPiA+ID4gPgo+ID4g PiA+ID4gT3RoZXJ3aXNlLCB0aGUgZHJpdmVyIGlzIG1vcmUgY29tcGxpY2F0ZWQgZm9yIG5vIHBh cnRpY3VsYXIgcmVhc29uLgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBpcyB1bmF2b2lkYWJsZSBiZWNh dXNlIG9mIHRoZSBkaWZmZXJlbmNlIGluIHNvYy4KPiA+ID4KPiA+ID4gSSBrbm93LCBidXQgdGhp cyBpc24ndCBteSBwb2ludC4KPiA+ID4KPiA+ID4gTXkgcG9pbnQgaXMgdGhhdCBhdCB0aGlzIHRp bWUgb2YgdGhlIGRyaXZlciBkZXZlbG9wbWVudCwgd2UgZG9uJ3Qga25vdwo+ID4gPiB3aGF0IGlz IGdvaW5nIHRvIGJlIG5lZWRlZCB0byBzdXBwb3J0IGFsbCBvZiB0aG9zZSBTb0NzLgo+ID4gPgo+ ID4gPiBTb21lIG9mIHRoZSBwYXJhbWV0ZXJzIHlvdSBhZGRlZCBtaWdodCBub3QgYmUgbmVlZGVk LCBzb21lIHBhcmFtZXRlcnMKPiA+ID4gbWlnaHQgYmUgbWlzc2luZywgd2UgZG9uJ3Qga25vdy4g U28gbGV0J3Mga2VlcCBpdCBzaW1wbGUgZm9yIG5vdy4KPiA+ID4KPiA+ID4gPiA+ID4gK3N0YXRp YyBpbnQgdHNlbnNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ID4gPiA+ ID4gK3sKPiA+ID4gPiA+ID4gKyAgICAgc3RydWN0IHRzZW5zX2RldmljZSAqdG1kZXY7Cj4gPiA+ ID4gPiA+ICsgICAgIHN0cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gPiA+ID4gPiA+ ICsgICAgIGludCByZXQ7Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKyAgICAgdG1kZXYgPSBk ZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKnRtZGV2KSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ID4gPiA+ ICsgICAgIGlmICghdG1kZXYpCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIC1FTk9N RU07Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gKyAgICAgdG1kZXYtPmRldiA9IGRldjsKPiA+ ID4gPiA+ID4gKyAgICAgdG1kZXYtPmNoaXAgPSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBk ZXYtPmRldik7Cj4gPiA+ID4gPiA+ICsgICAgIGlmICghdG1kZXYtPmNoaXApCj4gPiA+ID4gPiA+ ICsgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4g KyAgICAgcmV0ID0gdHNlbnNfaW5pdCh0bWRldik7Cj4gPiA+ID4gPiA+ICsgICAgIGlmIChyZXQp Cj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ID4gPiA+ID4gKwo+ID4g PiA+ID4gPiArICAgICByZXQgPSB0c2Vuc19yZWdpc3Rlcih0bWRldik7Cj4gPiA+ID4gPiA+ICsg ICAgIGlmIChyZXQpCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ID4g PiA+ID4gKwo+ID4gPiA+ID4gPiArICAgICByZXQgPSB0bWRldi0+Y2hpcC0+ZW5hYmxlKHRtZGV2 KTsKPiA+ID4gPiA+ID4gKyAgICAgaWYgKHJldCkKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICBy ZXR1cm4gcmV0Owo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiArICAgICBwbGF0Zm9ybV9zZXRfZHJ2 ZGF0YShwZGV2LCB0bWRldik7Cj4gPiA+ID4gPgo+ID4gPiA+ID4gWW91ciByZWdpc3RyYXRpb24g c2hvdWxkIGJlIHRoZSB2ZXJ5IGxhc3QgdGhpbmcgeW91IGRvLiBPdGhlcndpc2UsIHlvdQo+ID4g PiA+ID4gaGF2ZSBhIHNtYWxsIHdpbmRvdyB3aGVyZSB0aGUgZ2V0X3RlbXAgY2FsbGJhY2sgY2Fu IGJlIGNhbGxlZCwgYnV0IHRoZQo+ID4gPiA+ID4gZHJpdmVyIHdpbGwgbm90IGJlIGZ1bmN0aW9u YWwgeWV0Lgo+ID4gPiA+Cj4gPiA+ID4gTm8uIEFueXdheSwgdGhzIGRhdGEgcWNxdWlzaXRpb24g aXMgbXMgbGV2ZWwuCj4gPiA+Cj4gPiA+IFRoYXQncyBraW5kIG9mIGlycmVsZXZhbnQuIFRoZXJl J3Mgbm90aGluZyBwcmV2ZW50aW5nIGdldF90ZW1wIHRvIGJlCj4gPiA+IGNhbGxlZCByaWdodCBh d2F5Lgo+ID4KPiA+IEFzIE9uZMWZZWogc2FpZCwKPiA+Cj4gPiBSZWdpc3RyYXRpb24gYWZ0ZXIg ZW5hYmxpbmcgd2lsbCBsZWFkIHRvIGNhbGwgdHogdXBkYXRlIG9uIG5vbi1yZWdpc3RlcmVkIHR6 Cj4gPiBmcm9tIGFuIGludGVycnVwdCBoYW5kbGVyLgo+IAo+IEknbSBwcm9iYWJseSBtaXNzaW5n IHNvbWV0aGluZyBidXQgeW91J3JlIG5vdCB1c2luZyB0aGUgaW50ZXJydXB0cywgc28KPiBob3cg Y291bGQgYW4gaW50ZXJydXB0IGhhbmRsZXIgY2FsbCBpdD8KPiAKPiBBbHNvLCBvdGhlciBkcml2 ZXJzIHNlZW0gdG8gYmUgZG9pbmcgdGhhdCBqdXN0IGZpbmUgKG10a190aGVybWFsIGZvcgo+IGV4 YW1wbGUpLCBzbyBzdXJlbHkgdGhlcmUncyBhIHdheT8KCkxhc3QgdmVyc2lvbiBpcyB1c2luZyB0 aGUgaW50ZXJydXB0cy4KCkRyaXZlcnMgZG8gaXQgaW4gdmFyaW91cyB3YXlzLiBGb3IgZXhhbXBs ZSBpbXhfdGhlcm1hbCAoYW5kIG90aGVycyBsaWtlCmhpc2lfdGhlcm1hbCkgZG9lcyBpdCB0aGUg c3VnZ2VzdGVkIHdheS4gSXQgZW5hYmxlcyBpbnRlcnJ1cHRzIGFmdGVyIHRoZXJtYWwKem9uZSBy ZWdpc3RyYXRpb24sIHNvIHRoYXQgSVJRIGhhbmRsZXIgZG9lc24ndCBnZXQgaW52b2tlZCBiZWZv cmUgdGhlIHR6ZCBpcwpyZWdpc3RlcmVkLgoKcmVnYXJkcywKCW8uCgo+ID4gPiA+ID4gPiArICAg ICByZXQgPSB0c2Vuc19jYWxpYnJhdGUodG1kZXYpOwo+ID4gPiA+ID4gPiArICAgICBpZiAocmV0 KQo+ID4gPiA+ID4gPiArICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gPiA+ICsKPiA+ ID4gPiA+ID4gKyAgICAgLyoKPiA+ID4gPiA+ID4gKyAgICAgICogY2xraW4gPSAyNE1Iego+ID4g PiA+ID4gPiArICAgICAgKiBUIGFjcXVpcmUgPSBjbGtpbiAvIChTVU41MElfVEhTX0NUUkwwX1Rf QUNRICsgMSkKPiA+ID4gPiA+ID4gKyAgICAgICogICAgICAgICAgID0gMjB1cwo+ID4gPiA+ID4g PiArICAgICAgKi8KPiA+ID4gPiA+ID4gKyAgICAgcmVnbWFwX3dyaXRlKHRtZGV2LT5yZWdtYXAs IFNVTjUwSV9USFNfQ1RSTDAsCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICBTVU41MElf VEhTX0NUUkwwX1RfQUNRKDQ3OSkpOwo+ID4gPiA+ID4gPiArICAgICAvKiBhdmVyYWdlIG92ZXIg NCBzYW1wbGVzICovCj4gPiA+ID4gPiA+ICsgICAgIHJlZ21hcF93cml0ZSh0bWRldi0+cmVnbWFw LCBTVU41MElfSDZfVEhTX01GQywKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgIFNVTjUw SV9USFNfRklMVEVSX0VOIHwKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgIFNVTjUwSV9U SFNfRklMVEVSX1RZUEUoMSkpOwo+ID4gPiA+ID4gPiArICAgICAvKiBwZXJpb2QgPSAoU1VONTBJ X0g2X1RIU19QQ19URU1QX1BFUklPRCArIDEpICogNDA5NiAvIGNsa2luOyB+MTBtcyAqLwo+ID4g PiA+ID4gPiArICAgICByZWdtYXBfd3JpdGUodG1kZXYtPnJlZ21hcCwgU1VONTBJX0g2X1RIU19Q QywKPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgIFNVTjUwSV9INl9USFNfUENfVEVNUF9Q RVJJT0QoNTgpKTsKPiA+ID4gPiA+ID4gKyAgICAgLyogZW5hYmxlIHNlbnNvciAqLwo+ID4gPiA+ ID4gPiArICAgICB2YWwgPSBHRU5NQVNLKHRtZGV2LT5jaGlwLT5zZW5zb3JfbnVtIC0gMSwgMCk7 Cj4gPiA+ID4gPiA+ICsgICAgIHJlZ21hcF93cml0ZSh0bWRldi0+cmVnbWFwLCBTVU41MElfSDZf VEhTX0VOQUJMRSwgdmFsKTsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICAgICByZXR1cm4g MDsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArYXNzZXJ0X3Jlc2V0Ogo+ID4gPiA+ID4gPiAr ICAgICByZXNldF9jb250cm9sX2Fzc2VydCh0bWRldi0+cmVzZXQpOwo+ID4gPiA+ID4gPiArCj4g PiA+ID4gPiA+ICsgICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gPgo+ID4gPiA+ID4gQ2FuJ3Qgd2Ug ZG8gdGhhdCB3aXRoIHJ1bnRpbWVfcG0/Cj4gPiA+ID4KPiA+ID4gPiBTYXZpbmcgZW5lcmd5IGRv ZXNuJ3QgbWFrZSBtdWNoIHNlbnNlIGNvbXBhcmVkIHRvIHN5c3RlbSBzZWN1cml0eS4KPiA+ID4K PiA+ID4gSSdtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4gYnkgc2VjdXJpdHkuCj4gPgo+ID4gUHJv dGVjdCBzeXN0ZW0gaGFyZHdhcmUgZnJvbSBkYW1hZ2UuCj4gCj4gVGhlIHBvaW50IG9mIHJ1bnRp bWVfcG0gaXMgdG8ga2VlcCB0aGUgZGV2aWNlIG9uIGFzIGxvbmcgYXMgaXQgaXMKPiB1c2VkLCBz byBpdCB3b3VsZG4ndCBjaGFuZ2UgYW55dGhpbmcgdGhlcmUuCj4gCj4gSSBtZWFuLCB5b3UgY2Fu IGV2ZW4gZW5hYmxlIGl0IGluIHRoZSBwcm9iZSBpZiB5b3Ugd2FudCwgbXkgcG9pbnQgaXMKPiB0 aGF0IHRoZSBob29rcyB0aGF0IHlvdSBoYXZlIGFyZSBleGFjdCBlcXVpdmFsZW50cyB0byB0aGUg b25lIHByb3ZpZGVkCj4gYnkgcnVudGltZV9wbSBhbHJlYWR5LCBzbyB0aGVyZSdzIG5vIG5lZWQg dG8gZGVmaW5lIHRoZW0gaW4gdGhlIGZpcnN0Cj4gcGxhY2UuCj4gCj4gTWF4aW1lCj4gCj4gLS0K PiBNYXhpbWUgUmlwYXJkLCBCb290bGluCj4gRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdp bmVlcmluZwo+IGh0dHBzOi8vYm9vdGxpbi5jb20KCgoKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 Cj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=