From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E63C04AAF for ; Tue, 21 May 2019 12:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 103892173E for ; Tue, 21 May 2019 12:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728080AbfEUMmI (ORCPT ); Tue, 21 May 2019 08:42:08 -0400 Received: from mga06.intel.com ([134.134.136.31]:37645 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbfEUMmH (ORCPT ); Tue, 21 May 2019 08:42:07 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 05:42:07 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga006.fm.intel.com with ESMTP; 21 May 2019 05:42:03 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hT45i-00081U-Q2; Tue, 21 May 2019 15:42:02 +0300 Date: Tue, 21 May 2019 15:42:02 +0300 From: Andy Shevchenko To: Esben Haabendal Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, Lee Jones , Enrico Weigelt , Jiri Slaby , Darwin Dingel , Jisheng Zhang , Sebastian Andrzej Siewior , He Zhe , Marek Vasut , Douglas Anderson , Paul Burton , linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] serial: 8250: Add support for using platform_device resources Message-ID: <20190521124202.GE9224@smile.fi.intel.com> References: <20190430140416.4707-1-esben@geanix.com> <20190521113426.16790-1-esben@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521113426.16790-1-esben@geanix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 01:34:26PM +0200, Esben Haabendal wrote: > Allow getting memory resource (mapbase or iobase) as well as irq from > platform_device resources. > > The UPF_DEV_RESOURCES flag must be set for devices where platform_device > resources are to be used. When not set, driver behaves as before. > > This allows use of the serial8250 driver together with devices with > resources added by platform_device_add_resources(), such as mfd child > devices added with mfd_add_devices(). > > When UPF_DEV_RESOURCES flag is set, the following platform_data fields should > not be used: mapbase, iobase, mapsize, and irq. They are superseded by the > resources attached to the device. > Same comment here: Requesting resource is orthogonal to the retrieving or slicing them. > + if (p->flags & UPF_DEV_RESOURCES) { > + serial8250_probe_resources(dev, i, p, &uart); This can be easily detected by checking for the resources directly, like res = platform_get_resource(...); if (res) new_scheme(); else old_scheme(); Otherwise looks good. > - if (!request_mem_region(port->mapbase, size, "serial")) { > + if (!(port->flags & UPF_DEV_RESOURCES) && > + !request_mem_region(port->mapbase, size, "serial")) { > - release_mem_region(port->mapbase, size); > + if (!(port->flags & UPF_DEV_RESOURCES)) > + release_mem_region(port->mapbase, size); > - if (!request_region(port->iobase, size, "serial")) > + if (!(port->flags & UPF_DEV_RESOURCES) && > + !request_region(port->iobase, size, "serial")) > - release_mem_region(port->mapbase, size); > + if (!(port->flags & UPF_DEV_RESOURCES)) > + release_mem_region(port->mapbase, size); > - release_region(port->iobase, size); > + if (!(port->flags & UPF_DEV_RESOURCES)) > + release_region(port->iobase, size); All these changes are not related to what you describe in the commit message. is a workaround for the bug in the parent MFD driver of the 8250. -- With Best Regards, Andy Shevchenko