From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
KT Liao <kt.liao@emc.com.tw>, Rob Herring <robh+dt@kernel.org>,
Aaron Ma <aaron.ma@canonical.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value
Date: Tue, 21 May 2019 15:27:11 +0200 [thread overview]
Message-ID: <20190521132712.2818-10-benjamin.tissoires@redhat.com> (raw)
In-Reply-To: <20190521132712.2818-1-benjamin.tissoires@redhat.com>
*_traces are the number of antennas. width_* is thus the space between 2
antennas. Which means, we should subtract 1 to the number of antennas
to divide the touchpad by the number of holes between each antenna.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
--
new in v2
---
drivers/input/mouse/elan_i2c_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 6f4feedb7765..3375eaa9a72e 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -398,8 +398,8 @@ static int elan_query_device_parameters(struct elan_tp_data *data)
if (error)
return error;
}
- data->width_x = data->max_x / x_traces;
- data->width_y = data->max_y / y_traces;
+ data->width_x = data->max_x / (x_traces - 1);
+ data->width_y = data->max_y / (y_traces - 1);
if (device_property_read_u32(&client->dev,
"touchscreen-x-mm", &x_mm) ||
--
2.21.0
next prev parent reply other threads:[~2019-05-21 13:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 13:27 [PATCH v2 00/10] Fix Elan I2C touchpads in latest generation from Lenovo Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 01/10] Input: elantech - query the min/max information beforehand too Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 02/10] Input: elantech - add helper function elantech_is_buttonpad() Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 03/10] Input: elantech - detect middle button based on firmware version Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 04/10] dt-bindings: add more optional properties for elan_i2c touchpads Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 05/10] Input: elan_i2c - do not query the info if they are provided Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 06/10] Input: elantech/SMBus - export all capabilities from the PS/2 node Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 07/10] Input: elan_i2c - handle physical middle button Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 08/10] Input: elan_i2c - export true width/height Benjamin Tissoires
2019-05-24 9:37 ` Benjamin Tissoires
2019-05-27 3:55 ` 廖崇榮
2019-05-27 3:55 ` 廖崇榮
2019-05-28 1:21 ` 'Dmitry Torokhov'
2019-05-28 18:13 ` Harry Cutts
2019-05-29 0:12 ` Sean O'Brien
2019-05-29 7:16 ` Benjamin Tissoires
2019-05-29 12:55 ` 廖崇榮
2019-05-29 12:55 ` 廖崇榮
2019-05-29 13:16 ` Benjamin Tissoires
2019-05-30 0:22 ` Peter Hutterer
2019-05-21 13:27 ` Benjamin Tissoires [this message]
2019-05-24 3:13 ` [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value 廖崇榮
2019-05-24 3:13 ` 廖崇榮
2019-05-24 7:05 ` Benjamin Tissoires
2019-05-24 9:00 ` 廖崇榮
2019-05-24 9:00 ` 廖崇榮
2019-05-24 9:19 ` Benjamin Tissoires
2019-05-21 13:27 ` [PATCH v2 10/10] Input: elantech: remove P52 from SMBus blacklist Benjamin Tissoires
2019-05-23 13:25 ` [PATCH v2 00/10] Fix Elan I2C touchpads in latest generation from Lenovo Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521132712.2818-10-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aaron.ma@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kt.liao@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.