From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADAC8C04AAF for ; Tue, 21 May 2019 14:25:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 881C721773 for ; Tue, 21 May 2019 14:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728497AbfEUOZv (ORCPT ); Tue, 21 May 2019 10:25:51 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38571 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727812AbfEUOZu (ORCPT ); Tue, 21 May 2019 10:25:50 -0400 X-Originating-IP: 90.88.22.185 Received: from localhost (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6AEC61BF207; Tue, 21 May 2019 14:25:45 +0000 (UTC) Date: Tue, 21 May 2019 16:25:44 +0200 From: Maxime Ripard To: luca@z3ntu.xyz Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Message-ID: <20190521142544.ma2xfu77bamk4hvc@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190520110742.ykgxwaabzzwovgpl@flea> <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz> <20190521130955.3omqwpx3i7njsb3t@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eeqdxbq7qtv325ow" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eeqdxbq7qtv325ow Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = ; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --eeqdxbq7qtv325ow Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOQKZAAKCRDj7w1vZxhR xYxPAP0RFrmcAu/HPaXx9NqfF09TS+z60yL3d1lDXfuclCegcgD+NfHTU6LGqLtM AhoJHl0w0tcNUUIyMxL3GKzynwT7bgY= =OQh4 -----END PGP SIGNATURE----- --eeqdxbq7qtv325ow-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Tue, 21 May 2019 16:25:44 +0200 Message-ID: <20190521142544.ma2xfu77bamk4hvc@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190520110742.ykgxwaabzzwovgpl@flea> <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz> <20190521130955.3omqwpx3i7njsb3t@flea> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eeqdxbq7qtv325ow" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: luca@z3ntu.xyz Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org --eeqdxbq7qtv325ow Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = ; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --eeqdxbq7qtv325ow Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOQKZAAKCRDj7w1vZxhR xYxPAP0RFrmcAu/HPaXx9NqfF09TS+z60yL3d1lDXfuclCegcgD+NfHTU6LGqLtM AhoJHl0w0tcNUUIyMxL3GKzynwT7bgY= =OQh4 -----END PGP SIGNATURE----- --eeqdxbq7qtv325ow-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8370EC04AAF for ; Tue, 21 May 2019 14:26:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5693221773 for ; Tue, 21 May 2019 14:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YL2dlqCQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5693221773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XRe7WQZPXIUjrKqKhtDFT7b99Ch4kOhwBrRSSBPlmJg=; b=YL2dlqCQEEFwu+2z2A+mpZdq5 +stP9msYCFfAZhsKy9jqSCU+J71HBKsngH2EvkdsmQ7Vtxha9ch+TmxrQV6xxRDILsa6ZcbOebvLr Zo73gIAVe9UKRdd3bLoHUAZFv7xBdPHFtUkFgbNl+LRh/ueyPp54wbNU7qhiSarXvsP4bDV9sRBVj d1R33A3fYg0/SuE5H5WSC4gWNhfamkGvKvlgQ+LIpzc7A+AV5HdxWLUXYgGWjS0NHOHjAKg18kpXt hSjEr4g9lVDCeCr6lfora2yBVS3eAuypQ9tOmx21G+f9m+xznT8dFV7qLUvC+BP1syzUaLb+gE1Rl InEn5mulQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT5iU-0006RG-J1; Tue, 21 May 2019 14:26:10 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT5iG-0006GY-Pp for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 14:26:04 +0000 X-Originating-IP: 90.88.22.185 Received: from localhost (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6AEC61BF207; Tue, 21 May 2019 14:25:45 +0000 (UTC) Date: Tue, 21 May 2019 16:25:44 +0200 From: Maxime Ripard To: luca@z3ntu.xyz Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Message-ID: <20190521142544.ma2xfu77bamk4hvc@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190520110742.ykgxwaabzzwovgpl@flea> <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz> <20190521130955.3omqwpx3i7njsb3t@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_072557_552012_C1CEA8AD X-CRM114-Status: GOOD ( 23.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Chen-Yu Tsai , Rob Herring , "moderated list:ARM/Allwinner sunXi SoC support" Content-Type: multipart/mixed; boundary="===============8837238669078984220==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8837238669078984220== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eeqdxbq7qtv325ow" Content-Disposition: inline --eeqdxbq7qtv325ow Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 21, 2019 at 03:52:47PM +0200, luca@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > wrote: > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> >> Add a node describing the KEYADC on the A64. > >> >> > >> >> Signed-off-by: Luca Weiss > >> >> --- > >> >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> >> @@ -704,6 +704,13 @@ > >> >> status = "disabled"; > >> >> }; > >> >> > >> >> + lradc: lradc@1c21800 { > >> >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> >> + reg = <0x01c21800 0x100>; > >> >> + interrupts = ; > >> >> + status = "disabled"; > >> >> + }; > >> >> + > >> > > >> >The controller is pretty different on the A64 compared to the A10. > >The > >> >A10 has two channels for example, while the A64 has only one. > >> > > >> >It looks like the one in the A83t though, so you can use that > >> >compatible instead. > >> > >> Looking at the patch for the A83t, the only difference is that it > >> uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > >> the channels. > > > >I guess you can reuse the A83t compatible here then, and a more > >specific a64 compatible in case we ever need to fix this. > > > >> But I'm also not sure which one (or a different one) > >> is used from looking at the "A64 User Manual". > > > >I'm sorry, what are you referring to with "one" in that sentence? > > Sorry, I meant I didn't find anything in the A64 user manual whether > a 3/4 or a 2/3 voltage divider (or one with different values) is > used on the A64. Ok :) I guess you can just reuse the A83t compatible then, together with the A64's. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --eeqdxbq7qtv325ow Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOQKZAAKCRDj7w1vZxhR xYxPAP0RFrmcAu/HPaXx9NqfF09TS+z60yL3d1lDXfuclCegcgD+NfHTU6LGqLtM AhoJHl0w0tcNUUIyMxL3GKzynwT7bgY= =OQh4 -----END PGP SIGNATURE----- --eeqdxbq7qtv325ow-- --===============8837238669078984220== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8837238669078984220==--