From: "J. Bruce Fields" <bfields@fieldses.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: Xuewei Zhang <xueweiz@google.com>,
jlayton@kernel.org, Grigor Avagyan <grigora@google.com>,
Trevor Bourget <bourget@google.com>,
Nauman Rafique <nauman@google.com>,
trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] lockd: Show pid of lockd for remote locks
Date: Tue, 21 May 2019 10:49:35 -0400 [thread overview]
Message-ID: <20190521144935.GB9499@fieldses.org> (raw)
In-Reply-To: <C3DA91E7-B905-4A74-94A0-2BF4AFE1FD05@redhat.com>
On Tue, May 21, 2019 at 07:18:57AM -0400, Benjamin Coddington wrote:
> On 20 May 2019, at 16:51, J. Bruce Fields wrote:
>
> >On Mon, May 20, 2019 at 10:22:00AM -0400, Benjamin Coddington wrote:
> >>Ok, I just noticed that we set fl_owner to the nlm_host in
> >>nlm4svc_retrieve_args, so things are not as dire as I thought. What
> >>would be nice is a sane set of tests for NLM..
> >
> >What would we have needed to catch this? Sounds like it turns
> >multi-client testing wouldn't have been required? (Not that that
> >would
> >be a bad idea.)
>
> Two NLM clients would be ideal to exercise the full range of
> expected lock behavior. I suspect that's something I can do with
> what's in pynfs today, but I haven't looked yet. I suppose if
> there's a test for NLM I should make one for v4 too..
There isn't any pynfs NLM code. Some isilon folks did NLM/NSM/NFSv2/v3
pynfs tests:
https://github.com/sthaber/pynfs
I just never got a chance to incorporate them and try them. It's been a
while, and I think there were one or two odd things about it, but maybe
it'd be a good starting point.
--b.
next prev parent reply other threads:[~2019-05-21 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 21:45 Re: [PATCH] lockd: Show pid of lockd for remote locks Xuewei Zhang
2019-05-18 12:09 ` Benjamin Coddington
2019-05-19 2:15 ` Xuewei Zhang
2019-05-20 13:12 ` Benjamin Coddington
2019-05-20 14:22 ` Benjamin Coddington
2019-05-20 20:51 ` J. Bruce Fields
2019-05-21 11:18 ` Benjamin Coddington
2019-05-21 14:49 ` J. Bruce Fields [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-01 17:39 Benjamin Coddington
2018-11-02 18:45 ` J. Bruce Fields
2018-12-14 17:50 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521144935.GB9499@fieldses.org \
--to=bfields@fieldses.org \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=bourget@google.com \
--cc=grigora@google.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nauman@google.com \
--cc=trond.myklebust@hammerspace.com \
--cc=xueweiz@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.