From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D61BC04AAF for ; Tue, 21 May 2019 17:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58CF22183F for ; Tue, 21 May 2019 17:33:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="dIy/gWb9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbfEURdc (ORCPT ); Tue, 21 May 2019 13:33:32 -0400 Received: from vps.xff.cz ([195.181.215.36]:45898 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbfEURdc (ORCPT ); Tue, 21 May 2019 13:33:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1558460009; bh=8XpWGxJiEQwnYFL7fQjANvL039ojO3exLChRMSO028s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dIy/gWb9Qz7kwegZvq4raKYo3HNXNjX27y7C9IzTA5mcebmVIWVMdCkUupCWGaQ81 OsUGgwvtEx5tMhX2kmvM0cNrc11Pw9UHzcX9MB1GXziih22AgLwnp68mqh2WvI5JsJ LgGTnKlBmlSUwO5izjC1MK0JURrtSDg9FUT8p8+A= Date: Tue, 21 May 2019 19:33:28 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Cc: Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Message-ID: <20190521173328.bzwbyuy6mobzyvb5@core.my.home> Mail-Followup-To: Maxime Ripard , Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> <20190521102721.5hgks6guzlhubj6d@core.my.home> <20190521142734.fvhdomqhuntpop52@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190521142734.fvhdomqhuntpop52@flea> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 04:27:34PM +0200, Maxime Ripard wrote: > On Tue, May 21, 2019 at 12:27:21PM +0200, Ondřej Jirman wrote: > > On Tue, May 21, 2019 at 10:05:15AM +0200, Maxime Ripard wrote: > > > On Sat, May 18, 2019 at 01:27:39AM +0800, Frank Lee wrote: > > > > On Fri, May 17, 2019 at 3:36 PM Maxime Ripard wrote: > > > > > > > > > > On Fri, May 17, 2019 at 01:51:56AM +0800, Frank Lee wrote: > > > > > > > > +struct sun50i_thermal_chip { > > > > > > > > + int sensor_num; > > > > > > > > + int offset; > > > > > > > > + int scale; > > > > > > > > + int ft_deviation; > > > > > > > > + int temp_calib_base; > > > > > > > > + int temp_data_base; > > > > > > > > + int (*enable)(struct tsens_device *tmdev); > > > > > > > > + int (*disable)(struct tsens_device *tmdev); > > > > > > > > +}; > > > > > > > > > > > > > > I'm not super fond of having a lot of quirks that are not needed. If > > > > > > > we ever need those quirks when adding support for a new SoC, then > > > > > > > yeah, we should totally have some, but only when and if it's needed. > > > > > > > > > > > > > > Otherwise, the driver is more complicated for no particular reason. > > > > > > > > > > > > This is unavoidable because of the difference in soc. > > > > > > > > > > I know, but this isn't my point. > > > > > > > > > > My point is that at this time of the driver development, we don't know > > > > > what is going to be needed to support all of those SoCs. > > > > > > > > > > Some of the parameters you added might not be needed, some parameters > > > > > might be missing, we don't know. So let's keep it simple for now. > > > > > > > > > > > > > +static int tsens_probe(struct platform_device *pdev) > > > > > > > > +{ > > > > > > > > + struct tsens_device *tmdev; > > > > > > > > + struct device *dev = &pdev->dev; > > > > > > > > + int ret; > > > > > > > > + > > > > > > > > + tmdev = devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > > > > > > > + if (!tmdev) > > > > > > > > + return -ENOMEM; > > > > > > > > + > > > > > > > > + tmdev->dev = dev; > > > > > > > > + tmdev->chip = of_device_get_match_data(&pdev->dev); > > > > > > > > + if (!tmdev->chip) > > > > > > > > + return -EINVAL; > > > > > > > > + > > > > > > > > + ret = tsens_init(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > + > > > > > > > > + ret = tsens_register(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > + > > > > > > > > + ret = tmdev->chip->enable(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > > > > > > > > > + platform_set_drvdata(pdev, tmdev); > > > > > > > > > > > > > > Your registration should be the very last thing you do. Otherwise, you > > > > > > > have a small window where the get_temp callback can be called, but the > > > > > > > driver will not be functional yet. > > > > > > > > > > > > No. Anyway, ths data qcquisition is ms level. > > > > > > > > > > That's kind of irrelevant. There's nothing preventing get_temp to be > > > > > called right away. > > > > > > > > As Ondřej said, > > > > > > > > Registration after enabling will lead to call tz update on non-registered tz > > > > from an interrupt handler. > > > > > > I'm probably missing something but you're not using the interrupts, so > > > how could an interrupt handler call it? > > > > > > Also, other drivers seem to be doing that just fine (mtk_thermal for > > > example), so surely there's a way? > > > > Last version is using the interrupts. > > > > Drivers do it in various ways. For example imx_thermal (and others like > > hisi_thermal) does it the suggested way. It enables interrupts after thermal > > zone registration, so that IRQ handler doesn't get invoked before the tzd is > > registered. > > Enabling the interrupts after the registration makes sense, yes, but > filling the device private pointer with the private structure, > enabling the clocks, setting up the controller and so on can be done > before. I agree. o. > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ond=C5=99ej?= Jirman Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Date: Tue, 21 May 2019 19:33:28 +0200 Message-ID: <20190521173328.bzwbyuy6mobzyvb5@core.my.home> References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> <20190521102721.5hgks6guzlhubj6d@core.my.home> <20190521142734.fvhdomqhuntpop52@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190521142734.fvhdomqhuntpop52@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On Tue, May 21, 2019 at 04:27:34PM +0200, Maxime Ripard wrote: > On Tue, May 21, 2019 at 12:27:21PM +0200, Ondřej Jirman wrote: > > On Tue, May 21, 2019 at 10:05:15AM +0200, Maxime Ripard wrote: > > > On Sat, May 18, 2019 at 01:27:39AM +0800, Frank Lee wrote: > > > > On Fri, May 17, 2019 at 3:36 PM Maxime Ripard wrote: > > > > > > > > > > On Fri, May 17, 2019 at 01:51:56AM +0800, Frank Lee wrote: > > > > > > > > +struct sun50i_thermal_chip { > > > > > > > > + int sensor_num; > > > > > > > > + int offset; > > > > > > > > + int scale; > > > > > > > > + int ft_deviation; > > > > > > > > + int temp_calib_base; > > > > > > > > + int temp_data_base; > > > > > > > > + int (*enable)(struct tsens_device *tmdev); > > > > > > > > + int (*disable)(struct tsens_device *tmdev); > > > > > > > > +}; > > > > > > > > > > > > > > I'm not super fond of having a lot of quirks that are not needed. If > > > > > > > we ever need those quirks when adding support for a new SoC, then > > > > > > > yeah, we should totally have some, but only when and if it's needed. > > > > > > > > > > > > > > Otherwise, the driver is more complicated for no particular reason. > > > > > > > > > > > > This is unavoidable because of the difference in soc. > > > > > > > > > > I know, but this isn't my point. > > > > > > > > > > My point is that at this time of the driver development, we don't know > > > > > what is going to be needed to support all of those SoCs. > > > > > > > > > > Some of the parameters you added might not be needed, some parameters > > > > > might be missing, we don't know. So let's keep it simple for now. > > > > > > > > > > > > > +static int tsens_probe(struct platform_device *pdev) > > > > > > > > +{ > > > > > > > > + struct tsens_device *tmdev; > > > > > > > > + struct device *dev = &pdev->dev; > > > > > > > > + int ret; > > > > > > > > + > > > > > > > > + tmdev = devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > > > > > > > + if (!tmdev) > > > > > > > > + return -ENOMEM; > > > > > > > > + > > > > > > > > + tmdev->dev = dev; > > > > > > > > + tmdev->chip = of_device_get_match_data(&pdev->dev); > > > > > > > > + if (!tmdev->chip) > > > > > > > > + return -EINVAL; > > > > > > > > + > > > > > > > > + ret = tsens_init(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > + > > > > > > > > + ret = tsens_register(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > + > > > > > > > > + ret = tmdev->chip->enable(tmdev); > > > > > > > > + if (ret) > > > > > > > > + return ret; > > > > > > > > > > > > > > > > + platform_set_drvdata(pdev, tmdev); > > > > > > > > > > > > > > Your registration should be the very last thing you do. Otherwise, you > > > > > > > have a small window where the get_temp callback can be called, but the > > > > > > > driver will not be functional yet. > > > > > > > > > > > > No. Anyway, ths data qcquisition is ms level. > > > > > > > > > > That's kind of irrelevant. There's nothing preventing get_temp to be > > > > > called right away. > > > > > > > > As Ondřej said, > > > > > > > > Registration after enabling will lead to call tz update on non-registered tz > > > > from an interrupt handler. > > > > > > I'm probably missing something but you're not using the interrupts, so > > > how could an interrupt handler call it? > > > > > > Also, other drivers seem to be doing that just fine (mtk_thermal for > > > example), so surely there's a way? > > > > Last version is using the interrupts. > > > > Drivers do it in various ways. For example imx_thermal (and others like > > hisi_thermal) does it the suggested way. It enables interrupts after thermal > > zone registration, so that IRQ handler doesn't get invoked before the tzd is > > registered. > > Enabling the interrupts after the registration makes sense, yes, but > filling the device private pointer with the private structure, > enabling the clocks, setting up the controller and so on can be done > before. I agree. o. > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BD2C04AB4 for ; Tue, 21 May 2019 17:33:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D0D3217D9 for ; Tue, 21 May 2019 17:33:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cEy0thGd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="dIy/gWb9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D0D3217D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EmnHaxmuCNRM9Zg4hFmLJfsVhRoeLnYcagcFQ3Sk1XI=; b=cEy0thGdnlDn9S edFetnSfvpGumrL8sI6dskOCHOaftPXZgWUQuMg6D0QmQrk+izOXR2AlFpfRvHB+l0YEz6l6vVD1P OKAV0IH1bkUc2oDwl8b6bwySf+z3y4bowKjk/4NfZ4gRqQbtBTgKK18cK7wXmBcpqh3e/FC1N7vtj czYvgrPfpaiNwTkXglcQfHE35sfjWFsclgjmIpRhQxHarmPQSZqgrH3dWg7k9Kv0a5rnTjqf0fxR6 BCjU19/ZTNU8szyW3wnYIFkoAPcnjAKoFQpR8dlMOo4XAOoaATZtiRpG3L8sIwZuy+U/3MaTdAgLM fdtc27K5d+LHaK7X4Y0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT8du-0007te-8m; Tue, 21 May 2019 17:33:38 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT8dp-0007sr-Md for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 17:33:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1558460009; bh=8XpWGxJiEQwnYFL7fQjANvL039ojO3exLChRMSO028s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dIy/gWb9Qz7kwegZvq4raKYo3HNXNjX27y7C9IzTA5mcebmVIWVMdCkUupCWGaQ81 OsUGgwvtEx5tMhX2kmvM0cNrc11Pw9UHzcX9MB1GXziih22AgLwnp68mqh2WvI5JsJ LgGTnKlBmlSUwO5izjC1MK0JURrtSDg9FUT8p8+A= Date: Tue, 21 May 2019 19:33:28 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Maxime Ripard Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Message-ID: <20190521173328.bzwbyuy6mobzyvb5@core.my.home> Mail-Followup-To: Maxime Ripard , Frank Lee , Mark Rutland , Daniel Lezcano , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Linux PM , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, marc.w.gonzalez@free.fr, Eduardo Valentin , enric.balletbo@collabora.com, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , olof@lixom.net, David Miller References: <20190512082614.9045-1-tiny.windzz@gmail.com> <20190512082614.9045-3-tiny.windzz@gmail.com> <20190512133930.t5txssl7mou2gljt@flea> <20190517073634.izdmba3yqvxviyg3@flea> <20190521080515.qlni2lnmcwh7itl7@flea> <20190521102721.5hgks6guzlhubj6d@core.my.home> <20190521142734.fvhdomqhuntpop52@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190521142734.fvhdomqhuntpop52@flea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_103334_243385_419EDF80 X-CRM114-Status: GOOD ( 29.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Frank Lee , catalin.marinas@arm.com, will.deacon@arm.com, bjorn.andersson@linaro.org, marc.w.gonzalez@free.fr, Mauro Carvalho Chehab , paulmck@linux.ibm.com, stefan.wahren@i2se.com, Daniel Lezcano , Chen-Yu Tsai , Jagan Teki , Andy Gross , rui.zhang@intel.com, devicetree@vger.kernel.org, Linux PM , Eduardo Valentin , olof@lixom.net, robh+dt@kernel.org, Jonathan.Cameron@huawei.com, Linux ARM , Greg Kroah-Hartman , Linux Kernel Mailing List , enric.balletbo@collabora.com, David Miller Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXkgMjEsIDIwMTkgYXQgMDQ6Mjc6MzRQTSArMDIwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBPbiBUdWUsIE1heSAyMSwgMjAxOSBhdCAxMjoyNzoyMVBNICswMjAwLCBPbmTFmWVq IEppcm1hbiB3cm90ZToKPiA+IE9uIFR1ZSwgTWF5IDIxLCAyMDE5IGF0IDEwOjA1OjE1QU0gKzAy MDAsIE1heGltZSBSaXBhcmQgd3JvdGU6Cj4gPiA+IE9uIFNhdCwgTWF5IDE4LCAyMDE5IGF0IDAx OjI3OjM5QU0gKzA4MDAsIEZyYW5rIExlZSB3cm90ZToKPiA+ID4gPiBPbiBGcmksIE1heSAxNywg MjAxOSBhdCAzOjM2IFBNIE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+ IHdyb3RlOgo+ID4gPiA+ID4KPiA+ID4gPiA+IE9uIEZyaSwgTWF5IDE3LCAyMDE5IGF0IDAxOjUx OjU2QU0gKzA4MDAsIEZyYW5rIExlZSB3cm90ZToKPiA+ID4gPiA+ID4gPiA+ICtzdHJ1Y3Qgc3Vu NTBpX3RoZXJtYWxfY2hpcCB7Cj4gPiA+ID4gPiA+ID4gPiArICAgICBpbnQgICAgIHNlbnNvcl9u dW07Cj4gPiA+ID4gPiA+ID4gPiArICAgICBpbnQgICAgIG9mZnNldDsKPiA+ID4gPiA+ID4gPiA+ ICsgICAgIGludCAgICAgc2NhbGU7Cj4gPiA+ID4gPiA+ID4gPiArICAgICBpbnQgICAgIGZ0X2Rl dmlhdGlvbjsKPiA+ID4gPiA+ID4gPiA+ICsgICAgIGludCAgICAgdGVtcF9jYWxpYl9iYXNlOwo+ ID4gPiA+ID4gPiA+ID4gKyAgICAgaW50ICAgICB0ZW1wX2RhdGFfYmFzZTsKPiA+ID4gPiA+ID4g PiA+ICsgICAgIGludCAgICAgKCplbmFibGUpKHN0cnVjdCB0c2Vuc19kZXZpY2UgKnRtZGV2KTsK PiA+ID4gPiA+ID4gPiA+ICsgICAgIGludCAgICAgKCpkaXNhYmxlKShzdHJ1Y3QgdHNlbnNfZGV2 aWNlICp0bWRldik7Cj4gPiA+ID4gPiA+ID4gPiArfTsKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+IEknbSBub3Qgc3VwZXIgZm9uZCBvZiBoYXZpbmcgYSBsb3Qgb2YgcXVpcmtzIHRoYXQgYXJl IG5vdCBuZWVkZWQuIElmCj4gPiA+ID4gPiA+ID4gd2UgZXZlciBuZWVkIHRob3NlIHF1aXJrcyB3 aGVuIGFkZGluZyBzdXBwb3J0IGZvciBhIG5ldyBTb0MsIHRoZW4KPiA+ID4gPiA+ID4gPiB5ZWFo LCB3ZSBzaG91bGQgdG90YWxseSBoYXZlIHNvbWUsIGJ1dCBvbmx5IHdoZW4gYW5kIGlmIGl0J3Mg bmVlZGVkLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gT3RoZXJ3aXNlLCB0aGUgZHJpdmVy IGlzIG1vcmUgY29tcGxpY2F0ZWQgZm9yIG5vIHBhcnRpY3VsYXIgcmVhc29uLgo+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiBUaGlzIGlzIHVuYXZvaWRhYmxlIGJlY2F1c2Ugb2YgdGhlIGRpZmZlcmVu Y2UgaW4gc29jLgo+ID4gPiA+ID4KPiA+ID4gPiA+IEkga25vdywgYnV0IHRoaXMgaXNuJ3QgbXkg cG9pbnQuCj4gPiA+ID4gPgo+ID4gPiA+ID4gTXkgcG9pbnQgaXMgdGhhdCBhdCB0aGlzIHRpbWUg b2YgdGhlIGRyaXZlciBkZXZlbG9wbWVudCwgd2UgZG9uJ3Qga25vdwo+ID4gPiA+ID4gd2hhdCBp cyBnb2luZyB0byBiZSBuZWVkZWQgdG8gc3VwcG9ydCBhbGwgb2YgdGhvc2UgU29Dcy4KPiA+ID4g PiA+Cj4gPiA+ID4gPiBTb21lIG9mIHRoZSBwYXJhbWV0ZXJzIHlvdSBhZGRlZCBtaWdodCBub3Qg YmUgbmVlZGVkLCBzb21lIHBhcmFtZXRlcnMKPiA+ID4gPiA+IG1pZ2h0IGJlIG1pc3NpbmcsIHdl IGRvbid0IGtub3cuIFNvIGxldCdzIGtlZXAgaXQgc2ltcGxlIGZvciBub3cuCj4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+ID4gK3N0YXRpYyBpbnQgdHNlbnNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiA+ID4gPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiA+ID4gPiArICAgICBzdHJ1 Y3QgdHNlbnNfZGV2aWNlICp0bWRldjsKPiA+ID4gPiA+ID4gPiA+ICsgICAgIHN0cnVjdCBkZXZp Y2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gPiA+ID4gPiA+ID4gPiArICAgICBpbnQgcmV0Owo+ID4g PiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gKyAgICAgdG1kZXYgPSBkZXZtX2t6YWxsb2Mo ZGV2LCBzaXplb2YoKnRtZGV2KSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ID4gPiA+ID4gPiArICAgICBp ZiAoIXRtZGV2KQo+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsK PiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ICsgICAgIHRtZGV2LT5kZXYgPSBkZXY7 Cj4gPiA+ID4gPiA+ID4gPiArICAgICB0bWRldi0+Y2hpcCA9IG9mX2RldmljZV9nZXRfbWF0Y2hf ZGF0YSgmcGRldi0+ZGV2KTsKPiA+ID4gPiA+ID4gPiA+ICsgICAgIGlmICghdG1kZXYtPmNoaXAp Cj4gPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4gPiA+ID4g PiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gKyAgICAgcmV0ID0gdHNlbnNfaW5pdCh0bWRldik7Cj4g PiA+ID4gPiA+ID4gPiArICAgICBpZiAocmV0KQo+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAg ICByZXR1cm4gcmV0Owo+ID4gPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiA+ID4gKyAgICAgcmV0 ID0gdHNlbnNfcmVnaXN0ZXIodG1kZXYpOwo+ID4gPiA+ID4gPiA+ID4gKyAgICAgaWYgKHJldCkK PiA+ID4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ID4gPiA+ID4gPiA+ ICsKPiA+ID4gPiA+ID4gPiA+ICsgICAgIHJldCA9IHRtZGV2LT5jaGlwLT5lbmFibGUodG1kZXYp Owo+ID4gPiA+ID4gPiA+ID4gKyAgICAgaWYgKHJldCkKPiA+ID4gPiA+ID4gPiA+ICsgICAgICAg ICAgICAgcmV0dXJuIHJldDsKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiArICAgICBw bGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCB0bWRldik7Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiBZb3VyIHJlZ2lzdHJhdGlvbiBzaG91bGQgYmUgdGhlIHZlcnkgbGFzdCB0aGluZyB5b3Ug ZG8uIE90aGVyd2lzZSwgeW91Cj4gPiA+ID4gPiA+ID4gaGF2ZSBhIHNtYWxsIHdpbmRvdyB3aGVy ZSB0aGUgZ2V0X3RlbXAgY2FsbGJhY2sgY2FuIGJlIGNhbGxlZCwgYnV0IHRoZQo+ID4gPiA+ID4g PiA+IGRyaXZlciB3aWxsIG5vdCBiZSBmdW5jdGlvbmFsIHlldC4KPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gTm8uIEFueXdheSwgdGhzIGRhdGEgcWNxdWlzaXRpb24gaXMgbXMgbGV2ZWwuCj4gPiA+ ID4gPgo+ID4gPiA+ID4gVGhhdCdzIGtpbmQgb2YgaXJyZWxldmFudC4gVGhlcmUncyBub3RoaW5n IHByZXZlbnRpbmcgZ2V0X3RlbXAgdG8gYmUKPiA+ID4gPiA+IGNhbGxlZCByaWdodCBhd2F5Lgo+ ID4gPiA+Cj4gPiA+ID4gQXMgT25kxZllaiBzYWlkLAo+ID4gPiA+Cj4gPiA+ID4gUmVnaXN0cmF0 aW9uIGFmdGVyIGVuYWJsaW5nIHdpbGwgbGVhZCB0byBjYWxsIHR6IHVwZGF0ZSBvbiBub24tcmVn aXN0ZXJlZCB0ego+ID4gPiA+IGZyb20gYW4gaW50ZXJydXB0IGhhbmRsZXIuCj4gPiA+Cj4gPiA+ IEknbSBwcm9iYWJseSBtaXNzaW5nIHNvbWV0aGluZyBidXQgeW91J3JlIG5vdCB1c2luZyB0aGUg aW50ZXJydXB0cywgc28KPiA+ID4gaG93IGNvdWxkIGFuIGludGVycnVwdCBoYW5kbGVyIGNhbGwg aXQ/Cj4gPiA+Cj4gPiA+IEFsc28sIG90aGVyIGRyaXZlcnMgc2VlbSB0byBiZSBkb2luZyB0aGF0 IGp1c3QgZmluZSAobXRrX3RoZXJtYWwgZm9yCj4gPiA+IGV4YW1wbGUpLCBzbyBzdXJlbHkgdGhl cmUncyBhIHdheT8KPiA+Cj4gPiBMYXN0IHZlcnNpb24gaXMgdXNpbmcgdGhlIGludGVycnVwdHMu Cj4gPgo+ID4gRHJpdmVycyBkbyBpdCBpbiB2YXJpb3VzIHdheXMuIEZvciBleGFtcGxlIGlteF90 aGVybWFsIChhbmQgb3RoZXJzIGxpa2UKPiA+IGhpc2lfdGhlcm1hbCkgZG9lcyBpdCB0aGUgc3Vn Z2VzdGVkIHdheS4gSXQgZW5hYmxlcyBpbnRlcnJ1cHRzIGFmdGVyIHRoZXJtYWwKPiA+IHpvbmUg cmVnaXN0cmF0aW9uLCBzbyB0aGF0IElSUSBoYW5kbGVyIGRvZXNuJ3QgZ2V0IGludm9rZWQgYmVm b3JlIHRoZSB0emQgaXMKPiA+IHJlZ2lzdGVyZWQuCj4gCj4gRW5hYmxpbmcgdGhlIGludGVycnVw dHMgYWZ0ZXIgdGhlIHJlZ2lzdHJhdGlvbiBtYWtlcyBzZW5zZSwgeWVzLCBidXQKPiBmaWxsaW5n IHRoZSBkZXZpY2UgcHJpdmF0ZSBwb2ludGVyIHdpdGggdGhlIHByaXZhdGUgc3RydWN0dXJlLAo+ IGVuYWJsaW5nIHRoZSBjbG9ja3MsIHNldHRpbmcgdXAgdGhlIGNvbnRyb2xsZXIgYW5kIHNvIG9u IGNhbiBiZSBkb25lCj4gYmVmb3JlLgoKSSBhZ3JlZS4gCgoJby4KCj4gTWF4aW1lCj4gCj4gLS0K PiBNYXhpbWUgUmlwYXJkLCBCb290bGluCj4gRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdp bmVlcmluZwo+IGh0dHBzOi8vYm9vdGxpbi5jb20KCgoKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 Cj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=