From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Johannes Erdfelt <johannes@erdfelt.com>,
Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Oops caused by race between livepatch and ftrace
Date: Tue, 21 May 2019 16:00:14 -0500 [thread overview]
Message-ID: <20190521210014.aoew7p7y3jbl7na4@treble> (raw)
In-Reply-To: <a2075a5b-e048-4a7b-2813-01ed7e75bde8@redhat.com>
On Tue, May 21, 2019 at 03:27:47PM -0400, Joe Lawrence wrote:
> BTW, livepatching folks -- speaking of this window, does it make sense for
> klp_init_object_loaded() to unconditionally frob the module section
> permissions? Should it only bother iff it's going to apply
> relocations/alternatives/paravirt?
Yeah, technically there shouldn't be a need to do the frobbing unless
there are .klp.rela or .klp.arch sections for the given object. Though
I'm not sure it really matters all that much since loading a livepatch
is a pretty rare event.
--
Josh
prev parent reply other threads:[~2019-05-21 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 19:49 Oops caused by race between livepatch and ftrace Johannes Erdfelt
2019-05-20 20:46 ` Joe Lawrence
2019-05-20 21:09 ` Johannes Erdfelt
2019-05-20 21:19 ` Josh Poimboeuf
2019-05-20 21:39 ` Steven Rostedt
2019-05-21 14:16 ` Josh Poimboeuf
2019-05-21 14:42 ` Steven Rostedt
2019-05-21 16:42 ` Josh Poimboeuf
2019-05-21 16:53 ` Steven Rostedt
2019-05-29 11:17 ` Jiri Kosina
2019-05-29 12:06 ` Steven Rostedt
2019-05-29 12:30 ` Josh Poimboeuf
2019-05-22 13:00 ` Josh Poimboeuf
2019-05-29 17:29 ` Jessica Yu
2019-05-29 17:39 ` Josh Poimboeuf
2019-05-29 18:34 ` Jessica Yu
2019-05-20 21:48 ` Johannes Erdfelt
2019-05-20 21:19 ` Joe Lawrence
2019-05-21 19:27 ` Joe Lawrence
2019-05-21 21:00 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521210014.aoew7p7y3jbl7na4@treble \
--to=jpoimboe@redhat.com \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=johannes@erdfelt.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.