All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Ted Tso <tytso@mit.edu>
Cc: <linux-ext4@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>,
	Jan Kara <jack@suse.cz>
Subject: [PATCH 2/3] ext4: Do not delete unlinked inode from orphan list on failed truncate
Date: Wed, 22 May 2019 11:03:16 +0200	[thread overview]
Message-ID: <20190522090317.28716-3-jack@suse.cz> (raw)
In-Reply-To: <20190522090317.28716-1-jack@suse.cz>

It is possible that unlinked inode enters ext4_setattr() (e.g. if
somebody calls ftruncate(2) on unlinked but still open file). In such
case we should not delete the inode from the orphan list if truncate
fails. Note that this is mostly a theoretical concern as filesystem is
corrupted if we reach this path anyway but let's be consistent in our
orphan handling.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9bcb7f2b86dd..c7f77c643008 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5625,7 +5625,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
 			up_write(&EXT4_I(inode)->i_data_sem);
 			ext4_journal_stop(handle);
 			if (error) {
-				if (orphan)
+				if (orphan && inode->i_nlink)
 					ext4_orphan_del(NULL, inode);
 				goto err_out;
 			}
-- 
2.16.4


  parent reply	other threads:[~2019-05-22  9:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  9:03 [PATCH 0/3 v2] ext4: Fix issues in ext4 truncate handling Jan Kara
2019-05-22  9:03 ` [PATCH 1/3] ext4: Wait for outstanding dio during truncate in nojournal mode Jan Kara
2019-05-24  3:46   ` Theodore Ts'o
2019-05-22  9:03 ` Jan Kara [this message]
2019-05-24  3:47   ` [PATCH 2/3] ext4: Do not delete unlinked inode from orphan list on failed truncate Theodore Ts'o
2019-05-22  9:03 ` [PATCH 3/3] ext4: Gracefully handle ext4_break_layouts() failure during truncate Jan Kara
2019-05-24  4:18   ` Theodore Ts'o
2019-05-24  8:13     ` Jan Kara
2019-05-25  3:32   ` Theodore Ts'o
2019-05-27 14:53     ` Jan Kara
  -- strict thread matches above, loose matches on Subject: below --
2019-05-21  7:43 [PATCH 0/3] ext4: Fix issues in ext4 truncate handling Jan Kara
2019-05-21  7:43 ` [PATCH 2/3] ext4: Do not delete unlinked inode from orphan list on failed truncate Jan Kara
2019-05-21 18:13   ` Ira Weiny
2019-05-22  9:00     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522090317.28716-3-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=ira.weiny@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.