All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 3/9] drm/i915/selftests: Use prepare/finish during atomic reset test
Date: Wed, 22 May 2019 19:31:57 +0000	[thread overview]
Message-ID: <20190522193203.23932-4-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20190522193203.23932-1-michal.wajdeczko@intel.com>

We were testing full GPU reset in atomic context without correctly
wrapping it by prepare/finish steps. This could confuse our GuC
reset handling code.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_reset.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/selftest_reset.c b/drivers/gpu/drm/i915/gt/selftest_reset.c
index 0f8ccd8845ab..93860d9856ae 100644
--- a/drivers/gpu/drm/i915/gt/selftest_reset.c
+++ b/drivers/gpu/drm/i915/gt/selftest_reset.c
@@ -74,7 +74,9 @@ static int igt_atomic_reset(void *arg)
 		GEM_TRACE("intel_gpu_reset under %s\n", p->name);
 
 		p->critical_section_begin();
+		reset_prepare(i915);
 		err = intel_gpu_reset(i915, ALL_ENGINES);
+		reset_finish(i915);
 		p->critical_section_end();
 
 		if (err) {
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-22 19:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 19:31 [PATCH v2 0/9] GuC fixes Michal Wajdeczko
2019-05-22 19:31 ` [PATCH v2 1/9] drm/i915/selftests: Move some reset testcases to separate file Michal Wajdeczko
2019-05-22 19:53   ` Chris Wilson
2019-05-22 19:31 ` [PATCH v2 2/9] drm/i915/selftests: Split igt_atomic_reset testcase Michal Wajdeczko
2019-05-22 19:55   ` Chris Wilson
2019-05-22 19:31 ` Michal Wajdeczko [this message]
2019-05-22 19:56   ` [PATCH v2 3/9] drm/i915/selftests: Use prepare/finish during atomic reset test Chris Wilson
2019-05-22 19:31 ` [PATCH v2 4/9] drm/i915/guc: Rename intel_guc_is_alive to intel_guc_is_loaded Michal Wajdeczko
2019-05-22 19:56   ` Chris Wilson
2019-05-22 19:31 ` [PATCH v2 5/9] drm/i915/uc: Explicitly sanitize GuC/HuC on failure and finish Michal Wajdeczko
2019-05-22 19:58   ` Chris Wilson
2019-05-22 19:32 ` [PATCH v2 6/9] drm/i915/uc: Use GuC firmware status helper Michal Wajdeczko
2019-05-22 19:58   ` Chris Wilson
2019-05-22 19:32 ` [PATCH v2 7/9] drm/i915/uc: Skip GuC HW unwinding if GuC is already dead Michal Wajdeczko
2019-05-22 19:59   ` Chris Wilson
2019-05-22 19:32 ` [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting Michal Wajdeczko
2019-05-22 20:06   ` Chris Wilson
2019-05-23 15:53     ` Michal Wajdeczko
2019-05-23 16:08       ` Chris Wilson
2019-05-23 17:25   ` Michal Wajdeczko
2019-05-23 20:50     ` Chris Wilson
2019-05-22 19:32 ` [PATCH v2 9/9] drm/i915/uc: Skip reset preparation if GuC is already dead Michal Wajdeczko
2019-05-22 20:04   ` Chris Wilson
2019-05-22 20:34 ` ✗ Fi.CI.CHECKPATCH: warning for GuC fixes (rev2) Patchwork
2019-05-22 20:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-05-23 14:46   ` Michal Wajdeczko
2019-05-23 20:58     ` Chris Wilson
2019-05-23 17:40 ` ✗ Fi.CI.CHECKPATCH: warning for GuC fixes (rev3) Patchwork
2019-05-23 18:39 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190522193203.23932-4-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.