From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB1DC282CE for ; Wed, 22 May 2019 22:14:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A908A20881 for ; Wed, 22 May 2019 22:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Fpp15kRu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728050AbfEVWOS (ORCPT ); Wed, 22 May 2019 18:14:18 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44026 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728027AbfEVWOS (ORCPT ); Wed, 22 May 2019 18:14:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M6/V4Ln58iaBP2dK063ZH7jTVRU4CX4qclMImPWh5nw=; b=Fpp15kRuim/5sce+Py/VvJm/P9 o5vfbEaWOSiw1QB7NVZp2lu/rBf5a7dlQkLz6oDISh/ch+Z2vzGymLYVHrUdROJpgEfo50ompuzia fxXDrjEixxycy51IgSWlT2Yx3Cnyoq/fxijCw7t2Srw/hI6WSYhdsZ42mIc8I0WDIqsk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hTZUt-0005JA-FC; Thu, 23 May 2019 00:14:07 +0200 Date: Thu, 23 May 2019 00:14:07 +0200 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, Florian Fainelli , Guenter Roeck , Heiner Kallweit , Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: [PATCH V5] net: phy: tja11xx: Add TJA11xx PHY driver Message-ID: <20190522221407.GB15257@lunn.ch> References: <20190517235123.32261-1-marex@denx.de> <20190518141456.GK14298@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Wed, May 22, 2019 at 11:48:06PM +0200, Marek Vasut wrote: > On 5/18/19 4:14 PM, Andrew Lunn wrote: > > On Sat, May 18, 2019 at 01:51:23AM +0200, Marek Vasut wrote: > >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > >> BroadRReach 100BaseT1 PHYs used in automotive. > > > > Hi Marek > > > >> + }, { > >> + PHY_ID_MATCH_MODEL(PHY_ID_TJA1101), > >> + .name = "NXP TJA1101", > >> + .features = PHY_BASIC_T1_FEATURES, > > > > One thing i would like to do before this patch goes in is define > > ETHTOOL_LINK_MODE_100baseT1_Full_BIT in ethtool.h, and use it here. > > We could not do it earlier because were ran out of bits. But with > > PHYLIB now using bitmaps, rather than u32, we can. > > So now that "[PATCH net-next 0/2] net: phy: T1 support" is posted, does > this patch require any change ? I don't think it does ? Hi Marek In the end, no it does not need any changes because of my patchset. Andrew