From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D808C282DD for ; Thu, 23 May 2019 15:14:41 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 989CD204EC for ; Thu, 23 May 2019 15:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="WIR72fcD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 989CD204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FE341B946; Thu, 23 May 2019 17:14:38 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 294E95689 for ; Thu, 23 May 2019 17:14:37 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id h2so243820pgg.1 for ; Thu, 23 May 2019 08:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OWfLgHspfeiQ0S2xSEBG5CaPsG7zLnlZNCHN1T4dlHE=; b=WIR72fcD9sMmA6Zh2v7YovxtdMRMdORlx1T4eAEQA5RbgTDrbmbh6I9IBoIKbOCWrq MMGhitEach764VTvHzQkRi3efJBy0kdoezaacvq+GZFx2tY4SjX6h94fPv7utA6zlWIC LB+Z8r0g6U2uFFKLanupFwy/hZHzwkc+TH6A61KF9mqkEtwomjv5Sfhgy4FWy+PKblBQ NQMWi/9jQ/Vpw/A3aIFxZiyk41cpXfYFQSIuJFSXfSiEPBTOl91nlaVLhXmi1UnxIWZA lBQ0HY+hh0EHWMxyCCnbgyIIDjjcPWRAFrn9ySAuo+4hpbx+A+5GvtR1t6kUwjlBDIdd oYkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OWfLgHspfeiQ0S2xSEBG5CaPsG7zLnlZNCHN1T4dlHE=; b=VLhypVFX3tuLf5qU8h0iSQA83BUvtOdiDPXtLIP7F3TlzNpEqlVMfaWdY3xuuLeVz0 roK/06m9x0/kgRmyr9tz6B3C7L1Ac/zk70geOjSkXXp32n8+cdtuGL8i6w8QQmuMwxhR X+Kyv5qIu0hAZcnNFm22ZqIqIhjcw1Z0rMHbCCJyn8gfZsAWT2TAM9K72FnzoYA7lPaY vv0SYFgOsxF9rwwi1ZaJE4fuXHQwPwzIwJONDfP/Ic+dZqLbMF6jL0w49rLmqJv7KHgm UTuPf5I0W21xsbXjsZzZmEWmUqFyl0x0xljZhlpUCPySQcT49qBG2LePlQHtucvpbHdJ sHMg== X-Gm-Message-State: APjAAAU35G0vGqHR/y0M8D3pGUZjc1f7pOXML/KoP2QnZHfYwsfakIwd B2Nx9Drj9Me2e5LmV44L2NKLJA== X-Google-Smtp-Source: APXvYqyIGk3bxpF9grm1jmQEBdKwSSPw0M/Iuq0TghItWDT7/Er5Kl57IqV0F8m4tEcPzSZVtfD5Cw== X-Received: by 2002:a62:590f:: with SMTP id n15mr13536765pfb.204.1558624476259; Thu, 23 May 2019 08:14:36 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q17sm49544718pfq.74.2019.05.23.08.14.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 May 2019 08:14:36 -0700 (PDT) Date: Thu, 23 May 2019 08:14:29 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20190523081429.3b4ad834@hermes.lan> In-Reply-To: <1558619942-9723-1-git-send-email-david.marchand@redhat.com> References: <20190408182510.16078-1-stephen@networkplumber.org> <1558619942-9723-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/5] make lcore_config internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 23 May 2019 15:58:56 +0200 David Marchand wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > Changelog since v3: > I took the liberty of taking over Stephen series. > I rebased and did some adjustments following [1] cleanups. > As stated before, we will still need a deprecation notice when hiding > lcore_config but this series does not break API nor ABI. > > Changelog since v2: > - new patch to use unsigned int in lcore.h first > - incorporate feedback from David > - don't include last patch to make it private > (to avoid accidental early merge) > > 1: http://patchwork.dpdk.org/patch/53621/ > Thanks for doing this. We still need the documentation update to indicate deprecation.