All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: Enable micmute LED for Huawei laptops
@ 2019-05-23  9:30 Ayman Bagabas
  2019-05-23 12:24   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Ayman Bagabas @ 2019-05-23  9:30 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Jian-Hong Pan,
	Daniel Drake, Chris Chiu, Hui Wang, alsa-devel, linux-kernel
  Cc: ayman.bagabas

Since this LED is found on all Huawei laptops, we can hook it to
huawei-wmi platform driver to control it.

Also, some renames have been made to use product name instead of common
name to avoid confusions.

Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f83f21d64dd4..ab6a856ec614 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5747,7 +5747,7 @@ enum {
 	ALC298_FIXUP_TPT470_DOCK,
 	ALC255_FIXUP_DUMMY_LINEOUT_VERB,
 	ALC255_FIXUP_DELL_HEADSET_MIC,
-	ALC256_FIXUP_HUAWEI_MBXP_PINS,
+	ALC256_FIXUP_HUAWEI_MACH_WX9_PINS,
 	ALC295_FIXUP_HP_X360,
 	ALC221_FIXUP_HP_HEADSET_MIC,
 	ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
@@ -6038,7 +6038,7 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
-	[ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
+	[ALC256_FIXUP_HUAWEI_MACH_WX9_PINS] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
 			{0x12, 0x90a60130},
@@ -7063,9 +7063,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
-	SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
-	SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
-	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
+	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
 	SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
 
 #if 0
@@ -7124,6 +7122,7 @@ static const struct snd_pci_quirk alc269_fixup_vendor_tbl[] = {
 	SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
 	SND_PCI_QUIRK_VENDOR(0x104d, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK_VENDOR(0x17aa, "Thinkpad", ALC269_FIXUP_THINKPAD_ACPI),
+	SND_PCI_QUIRK_VENDOR(0x19e5, "Huawei Matebook", ALC255_FIXUP_MIC_MUTE_LED),
 	{}
 };
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: Enable micmute LED for Huawei laptops
  2019-05-23  9:30 [PATCH] ALSA: Enable micmute LED for Huawei laptops Ayman Bagabas
@ 2019-05-23 12:24   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-05-23 12:24 UTC (permalink / raw)
  To: Ayman Bagabas
  Cc: alsa-devel, Hui Wang, Chris Chiu, Daniel Drake, Jian-Hong Pan,
	Jaroslav Kysela, Kailang Yang, linux-kernel

On Thu, 23 May 2019 11:30:11 +0200,
Ayman Bagabas wrote:
> 
> Since this LED is found on all Huawei laptops, we can hook it to
> huawei-wmi platform driver to control it.
> 
> Also, some renames have been made to use product name instead of common
> name to avoid confusions.
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: Enable micmute LED for Huawei laptops
@ 2019-05-23 12:24   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2019-05-23 12:24 UTC (permalink / raw)
  To: Ayman Bagabas
  Cc: alsa-devel, Hui Wang, Chris Chiu, Daniel Drake, Jian-Hong Pan,
	Jaroslav Kysela, Kailang Yang, linux-kernel

On Thu, 23 May 2019 11:30:11 +0200,
Ayman Bagabas wrote:
> 
> Since this LED is found on all Huawei laptops, we can hook it to
> huawei-wmi platform driver to control it.
> 
> Also, some renames have been made to use product name instead of common
> name to avoid confusions.
> 
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-23 12:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23  9:30 [PATCH] ALSA: Enable micmute LED for Huawei laptops Ayman Bagabas
2019-05-23 12:24 ` Takashi Iwai
2019-05-23 12:24   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.