All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names
Date: Thu, 23 May 2019 09:58:17 +0200	[thread overview]
Message-ID: <20190523095817.45ca9cae@redhat.com> (raw)
In-Reply-To: <20190522191106.15789-1-dsahern@kernel.org>

Hi David,

On Wed, 22 May 2019 12:11:06 -0700
David Ahern <dsahern@kernel.org> wrote:

> From: David Ahern <dsahern@gmail.com>
> 
> The point of the pause-on-fail argument is to leave the setup as is after
> a test fails to allow a user to debug why it failed. Move the cleanup
> after posting the result to the user to make it so.
> 
> Random names for the namespaces are not user friendly when trying to
> debug a failure. Make them simpler and more direct for the tests. Run
> cleanup at the beginning to ensure they are cleaned up if they already
> exist.

The reasons for picking per-instance unique names were:

- one can run multiple instances of the script in parallel. I
  couldn't trigger any bug this way *so far*, though

- cleanup might fail because of e.g. device reference count leaks (this
  happened quite frequently in the past), which are anyway visible in
  kernel logs. Unique names avoid the need to reboot

Sure, it's a trade-off with usability, and I also see the value of
having fixed names, so I'm fine with this too. I just wanted to make
sure you considered these points.

By the way, the comment to nsname() (that I would keep, it's still
somewhat convenient) is now inconsistent.

-- 
Stefano

  parent reply	other threads:[~2019-05-23  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 19:11 [PATCH net-next] selftests: pmtu: Simplify cleanup and namespace names David Ahern
2019-05-23  0:55 ` David Miller
2019-05-23  7:58 ` Stefano Brivio [this message]
2019-05-23 15:41   ` David Ahern
2019-05-23 16:17     ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523095817.45ca9cae@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.