All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Nagarjuna Kristam <nkristam@nvidia.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org,
	jonathanh@nvidia.com, mark.rutland@arm.com, robh+dt@kernel.org,
	linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [Patch V3 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller
Date: Thu, 23 May 2019 12:26:06 +0200	[thread overview]
Message-ID: <20190523102606.GF30331@ulmo> (raw)
In-Reply-To: <1557988772-15406-8-git-send-email-nkristam@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

On Thu, May 16, 2019 at 12:09:31PM +0530, Nagarjuna Kristam wrote:
> This patch adds UDC driver for tegra XUSB 3.0 device mode controller.
> XUSB device mode controller supports SS, HS and FS modes
> 
> Based on work by:
>   Mark Kuo <mkuo@nvidia.com>
>   Andrew Bresticker <abrestic@chromium.org>
> 
> Signed-off-by: Nagarjuna Kristam <nkristam@nvidia.com>
> ---
>  drivers/usb/gadget/udc/Kconfig      |   10 +
>  drivers/usb/gadget/udc/Makefile     |    1 +
>  drivers/usb/gadget/udc/tegra_xudc.c | 3807 +++++++++++++++++++++++++++++++++++
>  3 files changed, 3818 insertions(+)
>  create mode 100644 drivers/usb/gadget/udc/tegra_xudc.c

Looks good to me, but please address Chunfeng's comments:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2019-05-23 10:26 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  6:39 [Patch V3 0/8] Tegra XUSB gadget driver support Nagarjuna Kristam
2019-05-16  6:39 ` Nagarjuna Kristam
2019-05-16  6:39 ` [Patch V3 1/8] phy: tegra: xusb: t210: add XUSB dual mode support Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  2:16   ` jckuo
2019-05-21  2:16     ` jckuo
2019-05-23  9:39   ` Thierry Reding
2019-05-16  6:39 ` [Patch V3 2/8] phy: tegra: xusb: t210: add usb3 port fake support Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  3:00   ` jckuo
2019-05-21  3:00     ` jckuo
2019-05-23 11:16     ` Nagarjuna Kristam
2019-05-23 11:16       ` Nagarjuna Kristam
2019-05-23 10:01   ` Thierry Reding
2019-05-23 11:24     ` Nagarjuna Kristam
2019-05-23 11:24       ` Nagarjuna Kristam
2019-05-16  6:39 ` [Patch V3 3/8] phy: tegra: xusb: t210: add vbus override support Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  4:34   ` jckuo
2019-05-21  4:34     ` jckuo
2019-05-23 11:15     ` Nagarjuna Kristam
2019-05-23 11:15       ` Nagarjuna Kristam
2019-05-23 10:03   ` Thierry Reding
2019-05-23 11:13     ` Nagarjuna Kristam
2019-05-23 11:13       ` Nagarjuna Kristam
2019-05-16  6:39 ` [Patch V3 4/8] dt-bindings: usb: Add NVIDIA Tegra XUSB device mode controller binding Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  6:08   ` JC Kuo
2019-05-21  6:08     ` JC Kuo
2019-05-23 10:13   ` Thierry Reding
2019-05-23 11:41     ` Nagarjuna Kristam
2019-05-23 11:41       ` Nagarjuna Kristam
2019-06-13 21:32   ` Rob Herring
2019-06-18  6:18     ` Nagarjuna Kristam
2019-06-18  6:18       ` Nagarjuna Kristam
2019-05-16  6:39 ` [Patch V3 5/8] arm64: tegra: Add xudc node for Tegra210 Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  6:08   ` JC Kuo
2019-05-21  6:08     ` JC Kuo
2019-05-23 10:15   ` Thierry Reding
2019-05-16  6:39 ` [Patch V3 6/8] arm64: tegra: Enable xudc on Jetson TX1 Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-21  6:11   ` JC Kuo
2019-05-21  6:11     ` JC Kuo
2019-05-16  6:39 ` [Patch V3 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-16  9:08   ` Chunfeng Yun
2019-05-16  9:08     ` Chunfeng Yun
2019-05-24  6:50     ` Nagarjuna Kristam
2019-05-24  6:50       ` Nagarjuna Kristam
2019-05-29  8:06       ` Chunfeng Yun
2019-05-29  8:06         ` Chunfeng Yun
2019-05-23 10:26   ` Thierry Reding [this message]
2019-05-23 10:28   ` Thierry Reding
2019-05-16  6:39 ` [Patch V3 8/8] arm64: defconfig: Enable tegra XUDC driver Nagarjuna Kristam
2019-05-16  6:39   ` Nagarjuna Kristam
2019-05-23 10:30   ` Thierry Reding
2019-05-24  8:01     ` Nagarjuna Kristam
2019-05-24  8:01       ` Nagarjuna Kristam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523102606.GF30331@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nkristam@nvidia.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.