All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH PATCH v3 05/12] spl: fit: be more verbose when an error occurs when applying the overlays
Date: Thu, 23 May 2019 12:39:05 +0200	[thread overview]
Message-ID: <20190523103912.3790-6-jjhiblot@ti.com> (raw)
In-Reply-To: <20190523103912.3790-1-jjhiblot@ti.com>

There are many ways the overlay application can fail.
2 of them are probably the most common:
- the application itself failed. Usually this is comes from an unresolved
  reference
- DTBO not available in FIT (could be because of a typo)

In both case it is good to be more explicit about the error and at least
show which overlay is failing.

Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---

Changes in v3: None
Changes in v2: None

 common/spl/spl_fit.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
index d5e3858ed0..d772f2db64 100644
--- a/common/spl/spl_fit.c
+++ b/common/spl/spl_fit.c
@@ -106,7 +106,7 @@ static int spl_fit_get_image_node(const void *fit, int images,
 
 	node = fdt_subnode_offset(fit, images, str);
 	if (node < 0) {
-		debug("cannot find image node '%s': %d\n", str, node);
+		pr_err("cannot find image node '%s': %d\n", str, node);
 		return -EINVAL;
 	}
 
@@ -337,8 +337,11 @@ static int spl_fit_append_fdt(struct spl_image_info *spl_image,
 
 		ret = fdt_overlay_apply_verbose(spl_image->fdt_addr,
 						(void *)image_info.load_addr);
-		if (ret)
+		if (ret) {
+			pr_err("failed to apply DT overlay %s\n",
+			       fit_get_name(fit, node, NULL));
 			return ret;
+		}
 
 		debug("%s: DT overlay %s applied\n", __func__,
 		      fit_get_name(fit, node, NULL));
-- 
2.17.1

  parent reply	other threads:[~2019-05-23 10:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 10:39 [U-Boot] [PATCH PATCH v3 00/12] Add support for applications of overlays in SPL Jean-Jacques Hiblot
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 01/12] spl: fit: Add support for applying DT overlay Jean-Jacques Hiblot
2019-05-24 11:29   ` Michal Simek
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 02/12] spl: fit: Make room in the FDT before applying overlays Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 03/12] spl: fit: allocate a temporary buffer to load the overlays Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 04/12] spl: fit: Do not fail immediately if an overlay is not available Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` Jean-Jacques Hiblot [this message]
2019-06-22 19:09   ` [U-Boot] [PATCH PATCH v3 05/12] spl: fit: be more verbose when an error occurs when applying the overlays Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 06/12] Makefile.lib: include /__symbols__ in dtb if SPL_LOAD_FIT_APPLY_OVERLAY is enabled Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 07/12] Makefile: Fix tests for CONFIG_SPL_LOAD_FIT and CONFIG_SPL_FIT_GENERATOR Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 08/12] Makefile: Fix u-boot.itb generation when building outside the source tree Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 09/12] Makefile: Pass the board name to the FIT generator scripts Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 10/12] Makefile: Query the SPL Fit Generator for its dependencies Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 11/12] spl: fit: constify the output parameter of spl_fit_get_image_name() Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-05-23 10:39 ` [U-Boot] [PATCH PATCH v3 12/12] spl: fit: Allow the board to tell if more images must be loaded from FIT Jean-Jacques Hiblot
2019-06-22 19:09   ` Simon Glass
2019-06-22 19:09 ` [U-Boot] [PATCH PATCH v3 00/12] Add support for applications of overlays in SPL Simon Glass
2019-06-25 19:10   ` Jean-Jacques Hiblot
2019-06-26 15:07     ` Simon Glass
2019-07-26 19:46 ` Tom Rini
2019-07-29 16:49   ` Jean-Jacques Hiblot
2019-07-30  8:08   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523103912.3790-6-jjhiblot@ti.com \
    --to=jjhiblot@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.