From: Quentin Monnet <quentin.monnet@netronome.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com,
Quentin Monnet <quentin.monnet@netronome.com>,
Yonghong Song <yhs@fb.com>
Subject: [PATCH bpf-next v2 0/3] tools: bpftool: add an option for debug output from libbpf and verifier
Date: Thu, 23 May 2019 11:54:23 +0100 [thread overview]
Message-ID: <20190523105426.3938-1-quentin.monnet@netronome.com> (raw)
Hi,
This series adds an option to bpftool to make it print additional
information via libbpf and the kernel verifier when attempting to load
programs.
A new API function is added to libbpf in order to pass the log_level from
bpftool with the bpf_object__* part of the API.
Options for a finer control over the log levels to use for libbpf and the
verifier could be added in the future, if desired.
v2:
- Do not add distinct options for libbpf and verifier logs, just keep the
one that sets all log levels to their maximum. Rename the option.
- Do not offer a way to pick desired log levels. The choice is "use the
option to print all logs" or "stick with the defaults".
- Do not export BPF_LOG_* flags to user header.
- Update all man pages (most bpftool operations use libbpf and may print
libbpf logs). Verifier logs are only used when attempting to load
programs for now, so bpftool-prog.rst and bpftool.rst remain the only
pages updated in that regard.
Previous discussion available at:
https://lore.kernel.org/bpf/20190429095227.9745-1-quentin.monnet@netronome.com/
Quentin Monnet (3):
tools: bpftool: add -d option to get debug output from libbpf
libbpf: add bpf_object__load_xattr() API function to pass log_level
tools: bpftool: make -d option print debug output from verifier
.../bpf/bpftool/Documentation/bpftool-btf.rst | 4 +++
.../bpftool/Documentation/bpftool-cgroup.rst | 4 +++
.../bpftool/Documentation/bpftool-feature.rst | 4 +++
.../bpf/bpftool/Documentation/bpftool-map.rst | 4 +++
.../bpf/bpftool/Documentation/bpftool-net.rst | 4 +++
.../bpftool/Documentation/bpftool-perf.rst | 4 +++
.../bpftool/Documentation/bpftool-prog.rst | 5 ++++
tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++
tools/bpf/bpftool/bash-completion/bpftool | 2 +-
tools/bpf/bpftool/main.c | 16 ++++++++++-
tools/bpf/bpftool/main.h | 1 +
tools/bpf/bpftool/prog.c | 27 ++++++++++++-------
tools/lib/bpf/Makefile | 2 +-
tools/lib/bpf/libbpf.c | 20 +++++++++++---
tools/lib/bpf/libbpf.h | 6 +++++
tools/lib/bpf/libbpf.map | 5 ++++
16 files changed, 96 insertions(+), 16 deletions(-)
--
2.17.1
next reply other threads:[~2019-05-23 10:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:54 Quentin Monnet [this message]
2019-05-23 10:54 ` [PATCH bpf-next v2 1/3] tools: bpftool: add -d option to get debug output from libbpf Quentin Monnet
2019-05-23 16:20 ` Andrii Nakryiko
2019-05-23 20:44 ` Jakub Kicinski
2019-05-23 20:57 ` Andrii Nakryiko
2019-05-24 9:46 ` Quentin Monnet
2019-05-23 10:54 ` [PATCH bpf-next v2 2/3] libbpf: add bpf_object__load_xattr() API function to pass log_level Quentin Monnet
2019-05-23 16:19 ` Yonghong Song
2019-05-23 16:29 ` Yonghong Song
2019-05-24 9:47 ` Quentin Monnet
2019-05-23 10:54 ` [PATCH bpf-next v2 3/3] tools: bpftool: make -d option print debug output from verifier Quentin Monnet
2019-05-23 16:38 ` Yonghong Song
2019-05-24 9:47 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523105426.3938-1-quentin.monnet@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.