From: kbusch@kernel.org (Keith Busch)
Subject: [PATCHv3 1/2] nvme: Export get and set features
Date: Thu, 23 May 2019 09:42:39 -0600 [thread overview]
Message-ID: <20190523154239.GC14943@localhost.localdomain> (raw)
In-Reply-To: <20190523153626.GA21238@lst.de>
On Thu, May 23, 2019@05:36:26PM +0200, Christoph Hellwig wrote:
> > Change since v2: Use 'unsigned int' instead of just 'unsiged'
>
> Those are equivalent in C, why bother changing it?
Just to shut up checkpatch.pl:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> > +int nvme_set_features(struct nvme_ctrl *dev, unsigned int fid, unsigned int dword11,
>
> Especially as this now creates lines > 80 characters in various places.
*facepalm*
prev parent reply other threads:[~2019-05-23 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 15:27 [PATCHv3 1/2] nvme: Export get and set features Keith Busch
2019-05-23 15:27 ` [PATCHv3 2/2] nvme-pci: Use host managed power state for suspend Keith Busch
2019-05-24 5:42 ` Kai-Heng Feng
2019-05-24 15:14 ` Mario.Limonciello
2019-05-30 9:09 ` Rafael J. Wysocki
2019-06-01 9:09 ` Christoph Hellwig
2019-05-23 15:36 ` [PATCHv3 1/2] nvme: Export get and set features Christoph Hellwig
2019-05-23 15:42 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523154239.GC14943@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.