From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11072C282E1 for ; Thu, 23 May 2019 16:43:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E12BD2175B for ; Thu, 23 May 2019 16:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731655AbfEWQn6 (ORCPT ); Thu, 23 May 2019 12:43:58 -0400 Received: from verein.lst.de ([213.95.11.211]:47936 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731156AbfEWQn4 (ORCPT ); Thu, 23 May 2019 12:43:56 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 941CA68AFE; Thu, 23 May 2019 18:43:32 +0200 (CEST) Date: Thu, 23 May 2019 18:43:32 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: Robin Murphy , Christoph Hellwig , Horia =?utf-8?Q?Geant=C4=83?= , Konrad Rzeszutek Wilk , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE Message-ID: <20190523164332.GA22245@lst.de> References: <20190522072018.10660-1-horia.geanta@nxp.com> <20190522123243.GA26390@lst.de> <6cbe5470-16a6-17e9-337d-6ba18b16b6e8@arm.com> <20190522130921.GA26874@lst.de> <20190522133400.GA27229@lst.de> <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 07:35:07AM +0200, Marek Szyprowski wrote: > Don't we have DMA_BIDIRECTIONAL for such case? Not sure if it was intended for that case, but it definitively should do the right thing for swiotlb, and it should also do the right thing in terms of cache maintainance. > Maybe we should update > documentation a bit to point that DMA_FROM_DEVICE expects the whole > buffer to be filled by the device? Probably. Horia, can you try to use DMA_BIDIRECTIONAL? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8C3C282DD for ; Thu, 23 May 2019 16:43:58 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA4D72070D for ; Thu, 23 May 2019 16:43:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA4D72070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 86CFAF00; Thu, 23 May 2019 16:43:58 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 987A0EF7 for ; Thu, 23 May 2019 16:43:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 12786821 for ; Thu, 23 May 2019 16:43:55 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id 941CA68AFE; Thu, 23 May 2019 18:43:32 +0200 (CEST) Date: Thu, 23 May 2019 18:43:32 +0200 From: Christoph Hellwig To: Marek Szyprowski Subject: Re: [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE Message-ID: <20190523164332.GA22245@lst.de> References: <20190522072018.10660-1-horia.geanta@nxp.com> <20190522123243.GA26390@lst.de> <6cbe5470-16a6-17e9-337d-6ba18b16b6e8@arm.com> <20190522130921.GA26874@lst.de> <20190522133400.GA27229@lst.de> <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Horia =?utf-8?Q?Geant=C4=83?= , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-imx@nxp.com, Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Thu, May 23, 2019 at 07:35:07AM +0200, Marek Szyprowski wrote: > Don't we have DMA_BIDIRECTIONAL for such case? Not sure if it was intended for that case, but it definitively should do the right thing for swiotlb, and it should also do the right thing in terms of cache maintainance. > Maybe we should update > documentation a bit to point that DMA_FROM_DEVICE expects the whole > buffer to be filled by the device? Probably. Horia, can you try to use DMA_BIDIRECTIONAL? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu