From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FA2C282DD for ; Thu, 23 May 2019 17:56:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A20E2186A for ; Thu, 23 May 2019 17:56:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387407AbfEWR4q (ORCPT ); Thu, 23 May 2019 13:56:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731116AbfEWR4p (ORCPT ); Thu, 23 May 2019 13:56:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C9F3307CDF2; Thu, 23 May 2019 17:56:45 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ED9968386; Thu, 23 May 2019 17:56:40 +0000 (UTC) Date: Thu, 23 May 2019 19:56:38 +0200 From: Andrew Jones To: Thomas Huth Cc: Christian Borntraeger , Janosch Frank , kvm@vger.kernel.org, Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Shuah Khan , David Hildenbrand , Cornelia Huck , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 9/9] KVM: selftests: Move kvm_create_max_vcpus test to generic code Message-ID: <20190523175638.5sc5zjbgsqe4bkes@kamzik.brq.redhat.com> References: <20190523164309.13345-1-thuth@redhat.com> <20190523164309.13345-10-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523164309.13345-10-thuth@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 23 May 2019 17:56:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 06:43:09PM +0200, Thomas Huth wrote: > There is nothing x86-specific in the test apart from the VM_MODE_P52V48_4K > which we can now replace with VM_MODE_DEFAULT. Thus let's move the file to > the main folder and enable it for aarch64 and s390x, too. > > Signed-off-by: Thomas Huth > --- > tools/testing/selftests/kvm/Makefile | 4 +++- > .../testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > rename tools/testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c (93%) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index d8beb990c8f4..aef5bd1166cf 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -21,15 +21,17 @@ TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test > TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid > TEST_GEN_PROGS_x86_64 += x86_64/vmx_close_while_nested_test > TEST_GEN_PROGS_x86_64 += x86_64/smm_test > -TEST_GEN_PROGS_x86_64 += x86_64/kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += x86_64/vmx_set_nested_state_test > +TEST_GEN_PROGS_x86_64 += kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += dirty_log_test > TEST_GEN_PROGS_x86_64 += clear_dirty_log_test > > TEST_GEN_PROGS_aarch64 += dirty_log_test > TEST_GEN_PROGS_aarch64 += clear_dirty_log_test > +TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus > > TEST_GEN_PROGS_s390x += s390x/sync_regs_test > +TEST_GEN_PROGS_s390x += kvm_create_max_vcpus > > TEST_GEN_PROGS += $(TEST_GEN_PROGS_$(UNAME_M)) > LIBKVM += $(LIBKVM_$(UNAME_M)) > diff --git a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > similarity index 93% > rename from tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > rename to tools/testing/selftests/kvm/kvm_create_max_vcpus.c > index 50e92996f918..db78ce07c416 100644 > --- a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > +++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * kvm_create_max_vcpus > * > @@ -28,7 +29,7 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus) > printf("Testing creating %d vCPUs, with IDs %d...%d.\n", > num_vcpus, first_vcpu_id, first_vcpu_id + num_vcpus - 1); > > - vm = vm_create(VM_MODE_P52V48_4K, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > + vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > > for (i = 0; i < num_vcpus; i++) { > int vcpu_id = first_vcpu_id + i; > -- > 2.21.0 > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 From: drjones at redhat.com (Andrew Jones) Date: Thu, 23 May 2019 19:56:38 +0200 Subject: [PATCH 9/9] KVM: selftests: Move kvm_create_max_vcpus test to generic code In-Reply-To: <20190523164309.13345-10-thuth@redhat.com> References: <20190523164309.13345-1-thuth@redhat.com> <20190523164309.13345-10-thuth@redhat.com> Message-ID: <20190523175638.5sc5zjbgsqe4bkes@kamzik.brq.redhat.com> On Thu, May 23, 2019 at 06:43:09PM +0200, Thomas Huth wrote: > There is nothing x86-specific in the test apart from the VM_MODE_P52V48_4K > which we can now replace with VM_MODE_DEFAULT. Thus let's move the file to > the main folder and enable it for aarch64 and s390x, too. > > Signed-off-by: Thomas Huth > --- > tools/testing/selftests/kvm/Makefile | 4 +++- > .../testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > rename tools/testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c (93%) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index d8beb990c8f4..aef5bd1166cf 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -21,15 +21,17 @@ TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test > TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid > TEST_GEN_PROGS_x86_64 += x86_64/vmx_close_while_nested_test > TEST_GEN_PROGS_x86_64 += x86_64/smm_test > -TEST_GEN_PROGS_x86_64 += x86_64/kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += x86_64/vmx_set_nested_state_test > +TEST_GEN_PROGS_x86_64 += kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += dirty_log_test > TEST_GEN_PROGS_x86_64 += clear_dirty_log_test > > TEST_GEN_PROGS_aarch64 += dirty_log_test > TEST_GEN_PROGS_aarch64 += clear_dirty_log_test > +TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus > > TEST_GEN_PROGS_s390x += s390x/sync_regs_test > +TEST_GEN_PROGS_s390x += kvm_create_max_vcpus > > TEST_GEN_PROGS += $(TEST_GEN_PROGS_$(UNAME_M)) > LIBKVM += $(LIBKVM_$(UNAME_M)) > diff --git a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > similarity index 93% > rename from tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > rename to tools/testing/selftests/kvm/kvm_create_max_vcpus.c > index 50e92996f918..db78ce07c416 100644 > --- a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > +++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * kvm_create_max_vcpus > * > @@ -28,7 +29,7 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus) > printf("Testing creating %d vCPUs, with IDs %d...%d.\n", > num_vcpus, first_vcpu_id, first_vcpu_id + num_vcpus - 1); > > - vm = vm_create(VM_MODE_P52V48_4K, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > + vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > > for (i = 0; i < num_vcpus; i++) { > int vcpu_id = first_vcpu_id + i; > -- > 2.21.0 > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 From: drjones@redhat.com (Andrew Jones) Date: Thu, 23 May 2019 19:56:38 +0200 Subject: [PATCH 9/9] KVM: selftests: Move kvm_create_max_vcpus test to generic code In-Reply-To: <20190523164309.13345-10-thuth@redhat.com> References: <20190523164309.13345-1-thuth@redhat.com> <20190523164309.13345-10-thuth@redhat.com> Message-ID: <20190523175638.5sc5zjbgsqe4bkes@kamzik.brq.redhat.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190523175638.kgWvoa47DpyxooMzWdbzHHvGlNPSM_cRTFy6GXT0D8Q@z> On Thu, May 23, 2019@06:43:09PM +0200, Thomas Huth wrote: > There is nothing x86-specific in the test apart from the VM_MODE_P52V48_4K > which we can now replace with VM_MODE_DEFAULT. Thus let's move the file to > the main folder and enable it for aarch64 and s390x, too. > > Signed-off-by: Thomas Huth > --- > tools/testing/selftests/kvm/Makefile | 4 +++- > .../testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c | 3 ++- > 2 files changed, 5 insertions(+), 2 deletions(-) > rename tools/testing/selftests/kvm/{x86_64 => }/kvm_create_max_vcpus.c (93%) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index d8beb990c8f4..aef5bd1166cf 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -21,15 +21,17 @@ TEST_GEN_PROGS_x86_64 += x86_64/evmcs_test > TEST_GEN_PROGS_x86_64 += x86_64/hyperv_cpuid > TEST_GEN_PROGS_x86_64 += x86_64/vmx_close_while_nested_test > TEST_GEN_PROGS_x86_64 += x86_64/smm_test > -TEST_GEN_PROGS_x86_64 += x86_64/kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += x86_64/vmx_set_nested_state_test > +TEST_GEN_PROGS_x86_64 += kvm_create_max_vcpus > TEST_GEN_PROGS_x86_64 += dirty_log_test > TEST_GEN_PROGS_x86_64 += clear_dirty_log_test > > TEST_GEN_PROGS_aarch64 += dirty_log_test > TEST_GEN_PROGS_aarch64 += clear_dirty_log_test > +TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus > > TEST_GEN_PROGS_s390x += s390x/sync_regs_test > +TEST_GEN_PROGS_s390x += kvm_create_max_vcpus > > TEST_GEN_PROGS += $(TEST_GEN_PROGS_$(UNAME_M)) > LIBKVM += $(LIBKVM_$(UNAME_M)) > diff --git a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > similarity index 93% > rename from tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > rename to tools/testing/selftests/kvm/kvm_create_max_vcpus.c > index 50e92996f918..db78ce07c416 100644 > --- a/tools/testing/selftests/kvm/x86_64/kvm_create_max_vcpus.c > +++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-only > /* > * kvm_create_max_vcpus > * > @@ -28,7 +29,7 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus) > printf("Testing creating %d vCPUs, with IDs %d...%d.\n", > num_vcpus, first_vcpu_id, first_vcpu_id + num_vcpus - 1); > > - vm = vm_create(VM_MODE_P52V48_4K, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > + vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR); > > for (i = 0; i < num_vcpus; i++) { > int vcpu_id = first_vcpu_id + i; > -- > 2.21.0 > Reviewed-by: Andrew Jones