From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2514C282DD for ; Thu, 23 May 2019 19:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8B2B217D9 for ; Thu, 23 May 2019 19:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638585; bh=Wpgw0TDUGZYsGHzCIymzJWbj9GHxVRPuswZba+0s04s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MKLgnDCmvbze8A4/GOKDuTArJ5+G34mnjlUqqEFAQM1Dua2vuLn6XZBS1XVygg9/H TrTl9stE57K0wY98bqG2Dq3Ink88wwrbN/wB0remDCCkCBeguqtKfA8CmwVUJjpnHI zbKqJrF2ZSBlcDErRmelmJgJtHeJ0u2xMHglFCU0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387547AbfEWTJp (ORCPT ); Thu, 23 May 2019 15:09:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:42866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387521AbfEWTJm (ORCPT ); Thu, 23 May 2019 15:09:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0722C217D9; Thu, 23 May 2019 19:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638581; bh=Wpgw0TDUGZYsGHzCIymzJWbj9GHxVRPuswZba+0s04s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=phxBvPoCjy9/GTurLbdULgHtz6qp/Z2sv94X5Rgqxy4HElktAppPm0BpN6ujTVvM8 l8Gg7eksVMoyKVrWYr+ptghHjw7Vxp6PkuHjPa/AIqaTeqvIMQAF6lMWHalD3Falhm fOS3/nlKsEAdyWTMtwKOExFcPGfnj1jEaGp9kPSU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Osipenko , Thierry Reding Subject: [PATCH 4.9 25/53] memory: tegra: Fix integer overflow on tick value calculation Date: Thu, 23 May 2019 21:05:49 +0200 Message-Id: <20190523181714.850863580@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181710.981455400@linuxfoundation.org> References: <20190523181710.981455400@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Osipenko commit b906c056b6023c390f18347169071193fda57dde upstream. Multiplying the Memory Controller clock rate by the tick count results in an integer overflow and in result the truncated tick value is being programmed into hardware, such that the GR3D memory client performance is reduced by two times. Cc: stable Signed-off-by: Dmitry Osipenko Signed-off-by: Thierry Reding Signed-off-by: Greg Kroah-Hartman --- drivers/memory/tegra/mc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c @@ -72,7 +72,7 @@ static int tegra_mc_setup_latency_allowa u32 value; /* compute the number of MC clock cycles per tick */ - tick = mc->tick * clk_get_rate(mc->clk); + tick = (unsigned long long)mc->tick * clk_get_rate(mc->clk); do_div(tick, NSEC_PER_SEC); value = readl(mc->regs + MC_EMEM_ARB_CFG);