From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BF4C282DD for ; Thu, 23 May 2019 19:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FBE320863 for ; Thu, 23 May 2019 19:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638909; bh=7nKQyDwytzw/xeDj6uK0lwRzC4i4TY4rO9siIcdbXiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W67ihBX64xRfU54Mcg8kdBhn9MhD1cpol2I3wnaeZQEmWuRvy+kXaJPoyta804Rbp BQBEq2VUiG6NqSStLaZ26UT6vx8lEZQ6PO/JkyKDIhFdWxqpB2+UWuQhZ4w6XYfJgL F/ea30Le3Us+vxTEDR2QAer5rHhnkRIZseJScfcc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388905AbfEWTPI (ORCPT ); Thu, 23 May 2019 15:15:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:49342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388886AbfEWTPG (ORCPT ); Thu, 23 May 2019 15:15:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D049A20863; Thu, 23 May 2019 19:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638905; bh=7nKQyDwytzw/xeDj6uK0lwRzC4i4TY4rO9siIcdbXiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LpdkiCNjZzUrusBVrbUXoZ1oD79bRYee15YgKy4x/vgRe2nDgdoenLOM23rQgnd5c 9P0vrYB14E/Y8SUV+xJHzi/rYxNmIS4iShp/1uN/Nh6EciFzSaEk9wipdkglfeeQbz OkYxOhOBF+rdjVpZu87uhWOOG4TiIYnjj8s7Nm6k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "chengjian (D)" , Paul Moore , John Johansen , James Morris , Casey Schaufler Subject: [PATCH 4.19 024/114] proc: prevent changes to overridden credentials Date: Thu, 23 May 2019 21:05:23 +0200 Message-Id: <20190523181734.071456391@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181731.372074275@linuxfoundation.org> References: <20190523181731.372074275@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Moore commit 35a196bef449b5824033865b963ed9a43fb8c730 upstream. Prevent userspace from changing the the /proc/PID/attr values if the task's credentials are currently overriden. This not only makes sense conceptually, it also prevents some really bizarre error cases caused when trying to commit credentials to a task with overridden credentials. Cc: Reported-by: "chengjian (D)" Signed-off-by: Paul Moore Acked-by: John Johansen Acked-by: James Morris Acked-by: Casey Schaufler Signed-off-by: Greg Kroah-Hartman --- fs/proc/base.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2542,6 +2542,11 @@ static ssize_t proc_pid_attr_write(struc rcu_read_unlock(); return -EACCES; } + /* Prevent changes to overridden credentials. */ + if (current_cred() != current_real_cred()) { + rcu_read_unlock(); + return -EBUSY; + } rcu_read_unlock(); if (count > PAGE_SIZE)