From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6ACC282DD for ; Thu, 23 May 2019 19:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 420A62133D for ; Thu, 23 May 2019 19:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639127; bh=pqomUC/mB5B0Tu67ZwAH0uPUO3ocK5ML1K59knVGFLc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uvglxtn93UUiUl4IfwvtF+s5eCF3/Qt+4WIq9hguzmq2bSWpQdSB1vTc8InBLiggK bvoro6p2En4CcRt7AyK1mwD190xG821hFzCB61ib7JAWEvZgW5NYl7EfxJ1RqgacA4 EVdna806j/1NPlY2Ot0el2ZiaEPlyhFjqmVzy4rc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389200AbfEWTSq (ORCPT ); Thu, 23 May 2019 15:18:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:54362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389660AbfEWTSo (ORCPT ); Thu, 23 May 2019 15:18:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 206692184E; Thu, 23 May 2019 19:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639123; bh=pqomUC/mB5B0Tu67ZwAH0uPUO3ocK5ML1K59knVGFLc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VZKVKr63dIMIK16FCLtLIey8nr9K3cjNgXoBReaKfzwfFsusdZWKlIQsn4i6aWAb6 xxSEcglFMotYrKtyyHNqyZHm1VWW4S4o64z5v/9TK6/p6f/VvsB5MUV4ML0hVWbWHk VdA7EGFgcNxXxng1u452QtABJGsK//4U/tEbcPxU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Tobin C. Harding" , Linus Torvalds , Peter Zijlstra , "Rafael J. Wysocki" , Thomas Gleixner , Vincent Guittot , Viresh Kumar , Ingo Molnar , Sasha Levin Subject: [PATCH 4.19 103/114] sched/cpufreq: Fix kobject memleak Date: Thu, 23 May 2019 21:06:42 +0200 Message-Id: <20190523181740.376885118@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181731.372074275@linuxfoundation.org> References: <20190523181731.372074275@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 9a4f26cc98d81b67ecc23b890c28e2df324e29f3 ] Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding Cc: Greg Kroah-Hartman Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Thomas Gleixner Cc: Tobin C. Harding Cc: Vincent Guittot Cc: Viresh Kumar Link: http://lkml.kernel.org/r/20190430001144.24890-1-tobin@kernel.org Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- kernel/sched/cpufreq_schedutil.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 217f81ecae176..4e3625109b28d 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -751,6 +751,7 @@ out: return 0; fail: + kobject_put(&tunables->attr_set.kobj); policy->governor_data = NULL; sugov_tunables_free(tunables); -- 2.20.1