From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spl: add overall SPL size check
Date: Thu, 23 May 2019 16:16:34 -0400 [thread overview]
Message-ID: <20190523201634.GI22232@bill-the-cat> (raw)
In-Reply-To: <4d51152d-1236-ee77-5aa0-ca60bd3cfe7b@gmail.com>
On Thu, May 23, 2019 at 10:08:54PM +0200, Simon Goldschmidt wrote:
> Am 13.05.2019 um 14:45 schrieb Simon Goldschmidt:
> >On Sat, May 11, 2019 at 3:55 AM Tom Rini <trini@konsulko.com> wrote:
> >>
> >>On Mon, Apr 22, 2019 at 10:27:21PM +0200, Simon Goldschmidt wrote:
> >>
> >>>This adds a size check for SPL that can dynamically check generated
> >>>SPL binaries (including devicetree) for a size limit that ensures
> >>>this image plus global data, heap and stack fit in initial SRAM.
> >>>
> >>>Since some of these sizes are not available to make, a new host tool
> >>>'spl_size_limit' is added that dumps the resulting maximum size for
> >>>an SPL binary to stdout. This tool is used in toplevel Makefile to
> >>>implement the size check on SPL binaries.
> >>>
> >>>Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> >>
> >>OK, this has a race / dependency problem:
> >>https://travis-ci.org/trini/u-boot/jobs/530803338
> >
> >Hmm, let me check that.
>
> OK, so as I see it, this is not a race but a dependency problem: the
> "tools-only" target just does not generate the "generic-asm-offsets.h" file.
>
> However, just adding a dependency to include/generated/generic-asm-offsets.h
> leads to an error (no rule to build that file) since that file is generated
> by Kbuild magic that I don't really get...
>
> Any idea how to make this depend on /Kbuild being run?
For context, https://patchwork.ozlabs.org/patch/1088885/
Yamada-san, do you have any ideas? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190523/71b91c51/attachment.sig>
next prev parent reply other threads:[~2019-05-23 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 20:27 [U-Boot] [PATCH v2] spl: add overall SPL size check Simon Goldschmidt
2019-04-22 21:10 ` Tom Rini
2019-04-23 5:47 ` Simon Goldschmidt
2019-05-11 1:55 ` Tom Rini
2019-05-13 12:45 ` Simon Goldschmidt
2019-05-23 20:08 ` Simon Goldschmidt
2019-05-23 20:16 ` Tom Rini [this message]
2019-05-27 16:25 ` Masahiro Yamada
2019-05-28 18:05 ` Simon Goldschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523201634.GI22232@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.