From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F39C282DD for ; Thu, 23 May 2019 20:47:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 391EB20645 for ; Thu, 23 May 2019 20:47:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CZ3GnIH+"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CZ3GnIH+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387647AbfEWUrT (ORCPT ); Thu, 23 May 2019 16:47:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46524 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387394AbfEWUrT (ORCPT ); Thu, 23 May 2019 16:47:19 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DC7F760CF1; Thu, 23 May 2019 20:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558644438; bh=2EOjThIW8SBz24GgHp3wmH9WnNSCbrrRd8s2VkktnTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CZ3GnIH+YlW8LwT0Rn+pJPwxHMQOjhH235bEz1lWOowKFqTlEkInY01cCaiNhZiPA MOaCufl/nnQ3aniz4/37nOMyAHLOqsb7DyH547lAqHHxHmKZVJvKd5po3FDGDdWOKf /s4fx97tsyUKz9JSxA2auxrGm45TQ365e72yWlBs= Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E712160C8B; Thu, 23 May 2019 20:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1558644438; bh=2EOjThIW8SBz24GgHp3wmH9WnNSCbrrRd8s2VkktnTM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CZ3GnIH+YlW8LwT0Rn+pJPwxHMQOjhH235bEz1lWOowKFqTlEkInY01cCaiNhZiPA MOaCufl/nnQ3aniz4/37nOMyAHLOqsb7DyH547lAqHHxHmKZVJvKd5po3FDGDdWOKf /s4fx97tsyUKz9JSxA2auxrGm45TQ365e72yWlBs= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E712160C8B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org Date: Thu, 23 May 2019 14:47:16 -0600 From: Jordan Crouse To: Sean Paul Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Rob Clark , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/6] drm/msm/a6xx: Remove duplicate irq disable from remove Message-ID: <20190523204715.GC18360@jcrouse1-lnx.qualcomm.com> Mail-Followup-To: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Sean Paul , Rob Clark , linux-arm-msm@vger.kernel.org References: <20190523171653.138678-1-sean@poorly.run> <20190523171653.138678-2-sean@poorly.run> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523171653.138678-2-sean@poorly.run> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 23, 2019 at 01:16:41PM -0400, Sean Paul wrote: > From: Sean Paul > > a6xx_gmu_stop() already calls this function via shutdown or force_stop, > so it's not necessary to call it twice. Previously this would have > knocked the irq refcount out of sync, but now with the irqs_enabled flag > it's just housekeeping. > > Changes in v2: > - None > > Cc: Jordan Crouse > Signed-off-by: Sean Paul Reviewed-by: Jordan Crouse > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index aa84edb25d91..742c8ff9a61c 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -1239,7 +1239,6 @@ void a6xx_gmu_remove(struct a6xx_gpu *a6xx_gpu) > dev_pm_domain_detach(gmu->gxpd, false); > } > > - a6xx_gmu_irq_disable(gmu); > a6xx_gmu_memory_free(gmu, gmu->hfi); > > iommu_detach_device(gmu->domain, gmu->dev); > -- > Sean Paul, Software Engineer, Google / Chromium OS > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: Re: [PATCH v2 2/6] drm/msm/a6xx: Remove duplicate irq disable from remove Date: Thu, 23 May 2019 14:47:16 -0600 Message-ID: <20190523204715.GC18360@jcrouse1-lnx.qualcomm.com> References: <20190523171653.138678-1-sean@poorly.run> <20190523171653.138678-2-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190523171653.138678-2-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: Sean Paul , Rob Clark , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMjMsIDIwMTkgYXQgMDE6MTY6NDFQTSAtMDQwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IEZyb206IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IGE2eHhfZ211 X3N0b3AoKSBhbHJlYWR5IGNhbGxzIHRoaXMgZnVuY3Rpb24gdmlhIHNodXRkb3duIG9yIGZvcmNl X3N0b3AsCj4gc28gaXQncyBub3QgbmVjZXNzYXJ5IHRvIGNhbGwgaXQgdHdpY2UuIFByZXZpb3Vz bHkgdGhpcyB3b3VsZCBoYXZlCj4ga25vY2tlZCB0aGUgaXJxIHJlZmNvdW50IG91dCBvZiBzeW5j LCBidXQgbm93IHdpdGggdGhlIGlycXNfZW5hYmxlZCBmbGFnCj4gaXQncyBqdXN0IGhvdXNla2Vl cGluZy4KPiAKPiBDaGFuZ2VzIGluIHYyOgo+IC0gTm9uZQo+IAo+IENjOiBKb3JkYW4gQ3JvdXNl IDxqY3JvdXNlQGNvZGVhdXJvcmEub3JnPgo+IFNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2Vh bnBhdWxAY2hyb21pdW0ub3JnPgoKUmV2aWV3ZWQtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VA Y29kZWF1cm9yYS5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E2eHhf Z211LmMgfCAxIC0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9nbXUuYyBiL2RyaXZlcnMvZ3B1 L2RybS9tc20vYWRyZW5vL2E2eHhfZ211LmMKPiBpbmRleCBhYTg0ZWRiMjVkOTEuLjc0MmM4ZmY5 YTYxYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNnh4X2dtdS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9nbXUuYwo+IEBAIC0xMjM5 LDcgKzEyMzksNiBAQCB2b2lkIGE2eHhfZ211X3JlbW92ZShzdHJ1Y3QgYTZ4eF9ncHUgKmE2eHhf Z3B1KQo+ICAJCWRldl9wbV9kb21haW5fZGV0YWNoKGdtdS0+Z3hwZCwgZmFsc2UpOwo+ICAJfQo+ ICAKPiAtCWE2eHhfZ211X2lycV9kaXNhYmxlKGdtdSk7Cj4gIAlhNnh4X2dtdV9tZW1vcnlfZnJl ZShnbXUsIGdtdS0+aGZpKTsKPiAgCj4gIAlpb21tdV9kZXRhY2hfZGV2aWNlKGdtdS0+ZG9tYWlu LCBnbXUtPmRldik7Cj4gLS0gCj4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xl IC8gQ2hyb21pdW0gT1MKPiAKCi0tIApUaGUgUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIElu Yy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBD b2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZnJlZWRyZW5v