From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw
Date: Thu, 23 May 2019 22:27:56 +0100 [thread overview]
Message-ID: <20190523212756.4b25giji4vkxdl5q@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190523011958.14944-6-ioana.ciornei@nxp.com>
On Thu, May 23, 2019 at 01:20:40AM +0000, Ioana Ciornei wrote:
> @@ -111,7 +114,16 @@ static const char *phylink_an_mode_str(unsigned int mode)
> static int phylink_validate(struct phylink *pl, unsigned long *supported,
> struct phylink_link_state *state)
> {
> - pl->ops->validate(pl->netdev, supported, state);
> + struct phylink_notifier_info info = {
> + .supported = supported,
> + .state = state,
> + };
> +
> + if (pl->ops)
> + pl->ops->validate(pl->netdev, supported, state);
> + else
> + blocking_notifier_call_chain(&pl->notifier_chain,
> + PHYLINK_VALIDATE, &info);
I don't like this use of notifiers for several reasons:
1. It becomes harder to grep for users of this.
2. We lose documentation about what is passed for each method.
3. We lose const-ness for parameters, which then allows users to
modify phylink-internal data structures inappropriately from
these notifier calls.
Please find another way.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-05-23 21:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 1:20 [RFC PATCH net-next 0/9] Decoupling PHYLINK from struct net_device Ioana Ciornei
2019-05-23 1:20 ` [RFC PATCH net-next 1/9] net: phy: Add phy_sysfs_create_links helper function Ioana Ciornei
2019-05-23 2:00 ` Florian Fainelli
2019-05-23 1:20 ` [RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev Ioana Ciornei
2019-05-23 2:02 ` Florian Fainelli
2019-05-23 22:18 ` Andrew Lunn
2019-05-24 10:30 ` Ioana Ciornei
2019-05-24 13:10 ` Andrew Lunn
2019-05-24 13:55 ` Ioana Ciornei
2019-05-23 1:20 ` [RFC PATCH net-next 3/9] net: phy: Add phy_standalone sysfs entry Ioana Ciornei
2019-05-23 2:05 ` Florian Fainelli
2019-05-24 10:52 ` Ioana Ciornei
2019-05-23 1:20 ` [RFC PATCH net-next 4/9] net: phylink: Add phylink_mac_link_{up,down} wrapper functions Ioana Ciornei
2019-05-23 2:05 ` Florian Fainelli
2019-05-23 1:20 ` [RFC PATCH net-next 5/9] net: phylink: Add phylink_create_raw Ioana Ciornei
2019-05-23 2:25 ` Florian Fainelli
2019-05-23 2:29 ` Florian Fainelli
2019-05-23 12:10 ` Ioana Ciornei
2019-05-23 14:32 ` Florian Fainelli
2019-05-23 20:32 ` Vladimir Oltean
2019-05-23 21:30 ` Florian Fainelli
2019-05-23 21:27 ` Russell King - ARM Linux admin [this message]
2019-05-23 21:37 ` Vladimir Oltean
2019-05-23 21:55 ` Russell King - ARM Linux admin
2019-05-23 22:04 ` Vladimir Oltean
2019-05-23 22:35 ` Russell King - ARM Linux admin
2019-05-23 1:20 ` [RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c Ioana Ciornei
2019-05-23 2:13 ` Florian Fainelli
2019-05-23 22:03 ` Russell King - ARM Linux admin
2019-05-23 1:20 ` [RFC PATCH net-next 6/9] net: phylink: Make fixed link notifier calls edge-triggered Ioana Ciornei
2019-05-23 1:20 ` [RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports Ioana Ciornei
2019-05-23 2:17 ` Florian Fainelli
2019-05-23 20:01 ` Vladimir Oltean
2019-05-24 13:19 ` Andrew Lunn
2019-05-24 13:44 ` Vladimir Oltean
2019-05-23 1:20 ` [RFC PATCH net-next 9/9] net: dsa: sja1105: Fix broken fixed-link interfaces on user ports Ioana Ciornei
2019-05-23 2:26 ` Florian Fainelli
2019-05-23 15:12 ` [RFC PATCH net-next 0/9] Decoupling PHYLINK from struct net_device Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523212756.4b25giji4vkxdl5q@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.