From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFBC9C282E1 for ; Fri, 24 May 2019 20:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D7CF21871 for ; Fri, 24 May 2019 20:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391799AbfEXUqQ (ORCPT ); Fri, 24 May 2019 16:46:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43032 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390330AbfEXUqP (ORCPT ); Fri, 24 May 2019 16:46:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EE70814E300C7; Fri, 24 May 2019 13:46:14 -0700 (PDT) Date: Fri, 24 May 2019 13:46:14 -0700 (PDT) Message-Id: <20190524.134614.1742380864925013895.davem@davemloft.net> To: Jose.Abreu@synopsys.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Joao.Pinto@synopsys.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, clabbe.montjoie@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next v2 00/18] net: stmmac: Improvements and Selftests From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 May 2019 13:46:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jose Abreu Date: Fri, 24 May 2019 10:20:08 +0200 > [ Thanks to the introducion of selftests this series ended up being a misc > of improvements and the selftests additions per-se. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback support for all cores within the driver. This way > more tests can easily be added in the future and can be run in virtually > any MAC/GMAC/QoS/XGMAC platform. > > Having this we can find regressions and missing features in the driver > while at the same time we can check if the IP is correctly working. > > We have been using this for some time now and I do have more tests to > submit in the feature. My experience is that although writing the tests > adds more development time, the gain results are obvious. > > I let this feature optional within the driver under a Kconfig option. Series applied.