All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] efi_loader: implement deprecated Unicode collation protocol
Date: Fri, 24 May 2019 16:22:22 +0900	[thread overview]
Message-ID: <20190524072220.GB27279@linaro.org> (raw)
In-Reply-To: <1e256d92-9366-bd7e-6d28-b8ba68503374@gmx.de>

On Fri, May 24, 2019 at 07:12:37AM +0200, Heinrich Schuchardt wrote:
> On 5/24/19 3:02 AM, AKASHI Takahiro wrote:
> > Heinrich,
> >
> > On Thu, May 16, 2019 at 07:34:54PM +0200, Heinrich Schuchardt wrote:
> >> In EFI 1.10 a version of the Unicode collation protocol using ISO 639-2
> >> language codes existed. This protocol is not part of the UEFI specification
> >> any longer. Unfortunately it is required to run the UEFI Self Certification
> >> Test (SCT) II, version 2.6, 2017. So we implement it here for the sole
> >> purpose of running the SCT. It can be removed once a compliant SCT is
> >> available.
> >
> > I remember that Alex always rejected this kind of patch, saying
> > that an upstream (SCT in this case) should be fixed in the first place.
> >
> > Do you want to change this policy?
> > (I'm just asking.)
> 
> I am using SCT a lot to test my patches. I want to be able to run the
> tests on the final code.
> 
> I have raised a ticket for upstream SCT but did not see any reaction up
> to now.

but less than two weeks have passed. Why not ping again?

> Making this deprecated protocol a config option deselected by default is
> the most plausible solution to me. In the Kconfig comment I made it
> clear that this protocol is going to be removed when the SCT has been
> corrected.

It is likely that your patch will be reverted soon in 2019.09.
(I don't know release cycle of UEFI SCT though.)
I believe that such a patch should be maintained only in your local repository.

-Takahiro Akashi


> Best regards
> 
> Heinrich
> 
> >
> > -Takahiro Akashi
> >
> >> The configuration option defaults to no.
> >>
> >> Heinrich Schuchardt (2):
> >>   efi_loader: rename Unicode collation protocol 2 variables
> >>   efi_loader: implement deprecated Unicode collation protocol
> >>
> >>  include/efi_api.h                      |  5 ++++
> >>  include/efi_loader.h                   |  9 +++++--
> >>  lib/efi_loader/Kconfig                 | 15 ++++++++++--
> >>  lib/efi_loader/Makefile                |  2 +-
> >>  lib/efi_loader/efi_root_node.c         |  7 +++++-
> >>  lib/efi_loader/efi_unicode_collation.c | 33 +++++++++++++++++++++++---
> >>  lib/efi_selftest/Makefile              |  3 ++-
> >>  7 files changed, 64 insertions(+), 10 deletions(-)
> >>
> >> --
> >> 2.20.1
> >>
> >
> 

  reply	other threads:[~2019-05-24  7:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 17:34 [U-Boot] [PATCH 0/2] efi_loader: implement deprecated Unicode collation protocol Heinrich Schuchardt
2019-05-16 17:34 ` [U-Boot] [PATCH 1/2] efi_loader: rename Unicode collation protocol 2 variables Heinrich Schuchardt
2019-05-16 17:34 ` [U-Boot] [PATCH 2/2] efi_loader: implement deprecated Unicode collation protocol Heinrich Schuchardt
2019-05-24  1:02 ` [U-Boot] [PATCH 0/2] " AKASHI Takahiro
2019-05-24  5:12   ` Heinrich Schuchardt
2019-05-24  7:22     ` AKASHI Takahiro [this message]
2019-05-24 13:30     ` Peter Robinson
2019-05-24 18:52       ` Heinrich Schuchardt
2019-05-29 10:09       ` Alexander Graf
2019-05-29 10:33         ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524072220.GB27279@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.