All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Cc: hch@infradead.org, christophe.de.dinechin@gmail.com,
	linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
	James.Bottomley@hansenpartnership.com, linux-mm@kvack.org,
	jglisse@redhat.com, jrdr.linux@gmail.com, davem@davemloft.net,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 1/6] vhost: generalize adding used elem
Date: Fri, 24 May 2019 04:12:13 -0400	[thread overview]
Message-ID: <20190524081218.2502-2-jasowang__1924.94986565492$1558685581$gmane$org@redhat.com> (raw)
In-Reply-To: <20190524081218.2502-1-jasowang@redhat.com>

Use one generic vhost_copy_to_user() instead of two dedicated
accessor. This will simplify the conversion to fine grain
accessors. About 2% improvement of PPS were seen during vitio-user
txonly test.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/vhost/vhost.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 1e3ed41ae1f3..47fb3a297c29 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -2255,16 +2255,7 @@ static int __vhost_add_used_n(struct vhost_virtqueue *vq,
 
 	start = vq->last_used_idx & (vq->num - 1);
 	used = vq->used->ring + start;
-	if (count == 1) {
-		if (vhost_put_user(vq, heads[0].id, &used->id)) {
-			vq_err(vq, "Failed to write used id");
-			return -EFAULT;
-		}
-		if (vhost_put_user(vq, heads[0].len, &used->len)) {
-			vq_err(vq, "Failed to write used len");
-			return -EFAULT;
-		}
-	} else if (vhost_copy_to_user(vq, used, heads, count * sizeof *used)) {
+	if (vhost_copy_to_user(vq, used, heads, count * sizeof *used)) {
 		vq_err(vq, "Failed to write used");
 		return -EFAULT;
 	}
-- 
2.18.1

  reply	other threads:[~2019-05-24  8:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  8:12 [PATCH net-next 0/6] vhost: accelerate metadata access Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12 ` Jason Wang [this message]
2019-05-24  8:12 ` [PATCH net-next 1/6] vhost: generalize adding used elem Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-24  8:12 ` [PATCH net-next 2/6] vhost: fine grain userspace memory accessors Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-24  8:12 ` [PATCH net-next 3/6] vhost: rename vq_iotlb_prefetch() to vq_meta_prefetch() Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12 ` [PATCH net-next 4/6] vhost: introduce helpers to get the size of metadata area Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12 ` [PATCH net-next 5/6] vhost: factor out setting vring addr and num Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-24  8:12 ` [PATCH net-next 6/6] vhost: access vq metadata through kernel virtual address Jason Wang
2019-05-24  8:12 ` Jason Wang
2019-05-24  8:12   ` Jason Wang
2019-05-30 18:07 ` [PATCH net-next 0/6] vhost: accelerate metadata access David Miller
2019-05-30 18:07   ` David Miller
2019-05-30 18:07   ` David Miller
2019-05-30 18:13   ` Michael S. Tsirkin
2019-05-30 18:13   ` Michael S. Tsirkin
2019-05-30 18:13     ` Michael S. Tsirkin
2019-05-30 18:55     ` David Miller
2019-05-30 18:55     ` David Miller
2019-05-30 18:55       ` David Miller
2019-06-05 20:27 ` Michael S. Tsirkin
2019-06-05 20:27 ` Michael S. Tsirkin
2019-06-05 20:27   ` Michael S. Tsirkin
2019-06-10  3:50   ` Jason Wang
2019-06-10  3:50   ` Jason Wang
2019-06-10  3:50     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190524081218.2502-2-jasowang__1924.94986565492$1558685581$gmane$org@redhat.com' \
    --to=jasowang@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=christophe.de.dinechin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=jglisse@redhat.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.