From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAED0C072B5 for ; Fri, 24 May 2019 16:07:55 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7437520675 for ; Fri, 24 May 2019 16:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="rhLkTPCY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7437520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EBDA1B945; Fri, 24 May 2019 18:07:54 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 9B5F4A69 for ; Fri, 24 May 2019 18:07:52 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id c5so4350893pll.11 for ; Fri, 24 May 2019 09:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7vBR2AYvczkM0yiLWwSFci6h/DJqMkAtDoG4W7NYC3I=; b=rhLkTPCYuCAQ+Dg2eIEvYs6kNaUQbjn33Ph2MniLriyKDnRQlis5yFtBDsPA/wX5mV q+CE9o6npyU5iCSe+v3ZMiXZzFqFuK7Ue4et9yFH7dsr6IcHtpUPfHgmZH7QpJQnLGIU DsozsMv/95/vqo+5OTsNGVwfyhFA8SAGZTKPKgT5wjOm25rdbNtq0FVZhtIjd5M1gDZO Tq2Av23kymSB/SkY2mKhunJOjFT4ZlgMGO1oKpZNoHjCE/kHp54qu/zmvdtXi1U6v6NB oFms8AyfOeKNpz+6Qn/VK8Z/FfteKsvdsCvlWoPJhnrVpMZWkcCqaT5f1xYrTNh88esj J3fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7vBR2AYvczkM0yiLWwSFci6h/DJqMkAtDoG4W7NYC3I=; b=ciYMfxMVtCvT8T8k9/s/oSdKqksrP8nyviD0Hc8irKsaF0ISvb8Q1TZ6kEiAUVDbqc wqSiJ1D9xYki7+o8KcWYMpIOlDtp4W7POUVfvu6Iidj2zoEiUUlAts7F9Gi/1b9tJ1nP CZ20mgEBEJoK3VOzt4h/gQtoYW9Os7DpPp98uuBN4VWhEFWLToXzTlxCjKJtwu0rhIaI AOFCbD91XMxZ3oMBQtdlqd47WkRT4ZT0COnipnoIZWm29OKNxOJj26KkuzNIAfCkJlpx KQRXwBIY+SOd/1tCaVfGPG0p5sCQ8mI2JtjkrF5FZ/7JTrrmK9USzHHX1oD/J/q0zMxk 7CJA== X-Gm-Message-State: APjAAAV7K1BYNJ1mg+OMiKM21n8alxkthOSxhGgUD2Fjda2plknZ/H1U uCuP9h2ajy+cByNFSJwqdMiV4A== X-Google-Smtp-Source: APXvYqyfWhmKhllzs2zZZlfyb8Eie7GQj/ajzgTa6D9YQmz1pSH8aJA11OeRYAsj9j+wsLzXAGlu8g== X-Received: by 2002:a17:902:aa97:: with SMTP id d23mr107476297plr.313.1558714071754; Fri, 24 May 2019 09:07:51 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z6sm6218805pfr.135.2019.05.24.09.07.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 09:07:51 -0700 (PDT) Date: Fri, 24 May 2019 09:07:49 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: matan@mellanox.com, dev@dpdk.org, Stephen Hemminger Message-ID: <20190524090749.086ef683@hermes.lan> In-Reply-To: References: <20190523220124.18818-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 24 May 2019 14:26:40 +0100 Ferruh Yigit wrote: > On 5/23/2019 11:01 PM, Stephen Hemminger wrote: > > Several users have run into problems where the MLX drivers were not > > enabled in their build. And then trying to run their DPDK > > application on Azure. What happens is that all packets > > go over the slow path, and failsafe repeatedly probes for never > > existing sub-device. > > > > Both Mellanox drivers should be checked. MLX4 for current versions, > > and MLX5 for future upgrades. This code is only called if Hyper-V/Azure > > is detected. > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/vdev_netvsc/vdev_netvsc.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c > > index 801f54c96e01..64f9dbf66e18 100644 > > --- a/drivers/net/vdev_netvsc/vdev_netvsc.c > > +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c > > @@ -812,6 +812,13 @@ vdev_netvsc_scan_callback(__rte_unused void *arg) > > struct rte_devargs *devargs; > > struct rte_bus *vbus = rte_bus_find_by_name("vdev"); > > > > +#ifndef RTE_LIBRTE_MLX4_PMD > > + DRV_LOG(WARNING, "Mellanox MLX4 not configured."); > > +#endif > > +#ifndef RTE_LIBRTE_MLX5_PMD > > + DRV_LOG(WARNING, "Mellanox MLX5 not configured."); > > +#endif > > Is it OK a virtual PMD being this much aware of another PMD? > Can it be an option to add this check into build system? And if there is direct > dependency perhaps even don't compile the 'vdev_netvsc' when none mlx PMD is > enabled. vdev_netvsc is not a device, it is really just a hack to start other device drivers on Hyper-V/Azure. If the build system supported dependencies (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies so that doesn't help. This is a warning and not fatal only because application will still at least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. The warning is just to give users better immediate feedback rather than trying to diagnose poor performance or mystery device not found messages.