From: Andrew Lunn <andrew@lunn.ch>
To: Greg Ungerer <gerg@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports
Date: Fri, 24 May 2019 15:44:12 +0200 [thread overview]
Message-ID: <20190524134412.GE2979@lunn.ch> (raw)
In-Reply-To: <e27eeebb-44fb-ae42-d43d-b42b47510f76@kernel.org>
On Fri, May 24, 2019 at 11:25:03AM +1000, Greg Ungerer wrote:
> Hi Andrew,
>
> I have a problem with a Marvell 6390 switch that I have bisected
> back to commit 7cbbee050c95, "[PATCH] net: dsa: mv88e6xxx: Set correct
> interface mode for CPU/DSA ports".
>
> I have a Marvell 380 SoC based platform with a Marvell 6390 10 port
> switch, everything works with kernel 5.0 and older. As of 5.1 the
> switch ports no longer work - no packets are ever received and
> none get sent out.
>
> The ports are probed and all discovered ok, they just don't work.
>
> mv88e6085 f1072004.mdio-mii:10: switch 0x3900 detected: Marvell 88E6390, revision 1
> libphy: mv88e6xxx SMI: probed
> mv88e6085 f1072004.mdio-mii:10 lan1 (uninitialized): PHY [mv88e6xxx-1:01] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan2 (uninitialized): PHY [mv88e6xxx-1:02] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan3 (uninitialized): PHY [mv88e6xxx-1:03] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan4 (uninitialized): PHY [mv88e6xxx-1:04] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan5 (uninitialized): PHY [mv88e6xxx-1:05] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan6 (uninitialized): PHY [mv88e6xxx-1:06] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan7 (uninitialized): PHY [mv88e6xxx-1:07] driver [Marvell 88E6390]
> mv88e6085 f1072004.mdio-mii:10 lan8 (uninitialized): PHY [mv88e6xxx-1:08] driver [Marvell 88E6390]
> DSA: tree 0 setup
>
> Things like ethtool on the ports seem to work ok, reports link correctly.
> Configuring ports as part of a bridge or individually gets the same result.
Hi Greg
DSA by default should configure the CPU port and DSA ports to there
maximum speed. For port 10, that is 10Gbps. Your 380 cannot do that
speed. So you need to tell the switch driver to slow down. Add a fixed
link node to port ten, with speed 1000. You might also need to set the
phy-mode to rgmii.
Can the 380 do 2500BaseX? There is work in progress to support this
speed, so maybe next cycle you can change to that.
Andrew
next prev parent reply other threads:[~2019-05-24 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 1:25 [PATCH net] net: dsa: mv88e6xxx: Set correct interface mode for CPU/DSA ports Greg Ungerer
2019-05-24 13:44 ` Andrew Lunn [this message]
2019-05-27 1:26 ` Greg Ungerer
2019-05-28 13:17 ` Andrew Lunn
2019-05-29 1:12 ` Greg Ungerer
-- strict thread matches above, loose matches on Subject: below --
2019-03-08 0:21 Andrew Lunn
2019-03-09 7:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524134412.GE2979@lunn.ch \
--to=andrew@lunn.ch \
--cc=gerg@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.