From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A635BC072B5 for ; Fri, 24 May 2019 17:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7768B2133D for ; Fri, 24 May 2019 17:57:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mDgsvVGI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391148AbfEXR5z (ORCPT ); Fri, 24 May 2019 13:57:55 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:34593 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbfEXR5y (ORCPT ); Fri, 24 May 2019 13:57:54 -0400 Received: by mail-vs1-f68.google.com with SMTP id q64so6415301vsd.1; Fri, 24 May 2019 10:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=xsHpHXSkRG30rT1Gebig5Ode0f+Go1ChQZY26jIIXn8=; b=mDgsvVGICwKVo8Ff+lHccYlhJ3uc9K6ujYOICfC/U00blP02IIgpILC2MQbcNAoSQk srM9l51RM7U2OfoyeTqqffBh6cmUjyEnE6hvyEtlcOTK3GCZlTieZikSdmJD5CP/YAja afIrjked50mJppRtlNgkeY/oZgrWfJ7Z6+HZAwfMZy6pj3+XDUPePBO3gRKl2bDfvqB+ 7HAnZem3z1qJQ25lzvXHK1vJqLTuC4RGbD/Y9QzBZA6KWpZ/bnQ1Gja4LbKuBhkuzuXy CtNq/Sn9C+uzJcJUR7tezOJ/5XtMliRPRM+nQwwaUlgjuQLRR78T6RJ7oq1g/54eSRCT RhKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=xsHpHXSkRG30rT1Gebig5Ode0f+Go1ChQZY26jIIXn8=; b=bpME/qxIjREfzAH0YyXe8hIl1VvsM9Uk6tMdSWqq3Acp2loUEYCgXH5vMRuR4ahSGZ R6vfnLG0N5D9uIFDUy2M19TdVu7xbO21DZeLoZVL4Gs1rd3CxfwBpS1G3TxAK2RaozBK zZmmbKi3ckS+NaO59eTD+usBRdlrYSotV73fD3p2DkaWCbVaFoHGJs3TiwFk3usQftq0 4QJ4Ldl28m7WV2rpPtn7O0BPYV+EvmJ579xe1xFBWWE7GqbDtYg80X1sH8X/ePeaItI+ G0JNaezDoWQRuccK8+07yH/fWPV/VNZdsGTZxp62U3CsKJvJ1Zqqa+tuAsWvOeA77yC8 f2Og== X-Gm-Message-State: APjAAAUklSsMZVSgQoYptpYUoQ3mBOT6k9mxgPmgzuH5/lunY8y4/UCH Zq69DyGpbMEtZAi19cCbexs= X-Google-Smtp-Source: APXvYqyfzlUuV5m88iQ6s9M+IZkWp0j0bN7hq+4Ly5qwzkTH9gGYZXVt1lMVYqQqh3Ri3jBHK0x/kQ== X-Received: by 2002:a67:bc01:: with SMTP id t1mr16496492vsn.102.1558720674023; Fri, 24 May 2019 10:57:54 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id w131sm1448000vsw.7.2019.05.24.10.57.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 10:57:53 -0700 (PDT) Date: Fri, 24 May 2019 13:57:52 -0400 Message-ID: <20190524135752.GD17138@t480s.localdomain> From: Vivien Didelot To: Rasmus Villemoes Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Rasmus Villemoes , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/5] net: dsa: prepare mv88e6xxx_g1_atu_op() for the mv88e6250 In-Reply-To: <20190524085921.11108-3-rasmus.villemoes@prevas.dk> References: <20190501193126.19196-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-3-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 May 2019 09:00:26 +0000, Rasmus Villemoes wrote: > All the currently supported chips have .num_databases either 256 or > 4096, so this patch does not change behaviour for any of those. The > mv88e6250, however, has .num_databases == 64, and it does not put the > upper two bits in ATU control 13:12, but rather in ATU Operation > 9:8. So change the logic to prepare for supporting mv88e6250. > > Reviewed-by: Andrew Lunn > Signed-off-by: Rasmus Villemoes Reviewed-by: Vivien Didelot